Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43851/?format=api
{ "id": 43851, "url": "http://patches.dpdk.org/api/patches/43851/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1535113006-9393-5-git-send-email-tdu@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1535113006-9393-5-git-send-email-tdu@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1535113006-9393-5-git-send-email-tdu@semihalf.com", "date": "2018-08-24T12:16:44", "name": "[4/6] net/mvpp2: fix comments and error messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "54d8eaed7bbae03919ddbd9aff33624cc8a01aff", "submitter": { "id": 846, "url": "http://patches.dpdk.org/api/people/846/?format=api", "name": "Tomasz Duszynski", "email": "tdu@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1535113006-9393-5-git-send-email-tdu@semihalf.com/mbox/", "series": [ { "id": 1044, "url": "http://patches.dpdk.org/api/series/1044/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1044", "date": "2018-08-24T12:16:40", "name": "mvpp2 changes and features", "version": 1, "mbox": "http://patches.dpdk.org/series/1044/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43851/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43851/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CAA3C4CC3;\n\tFri, 24 Aug 2018 14:17:10 +0200 (CEST)", "from mail-lf1-f67.google.com (mail-lf1-f67.google.com\n\t[209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 8D4764CA1\n\tfor <dev@dpdk.org>; Fri, 24 Aug 2018 14:17:05 +0200 (CEST)", "by mail-lf1-f67.google.com with SMTP id q13-v6so6552134lfc.2\n\tfor <dev@dpdk.org>; Fri, 24 Aug 2018 05:17:05 -0700 (PDT)", "from sh.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\ta18-v6sm1177672ljk.47.2018.08.24.05.17.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 24 Aug 2018 05:17:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=DuNIJKs2ebfo80SbqgaSWcAxNGMIp5DumfTiALAK+uI=;\n\tb=uJY5kGQyXqocihMq/IZlrGHlls1nZpVpbreSaiLxw+DCzRuV/ayapKD0t7SzSjAikh\n\t8TiHmJ7hVwSRlr5mHOsBmOd26di+dBTG9mF53/j/4uUZ647qz0JYhuklpbGyuubYQXSO\n\tH2qChE6iKfCbQA+daN5AyTIijsF5rwbayFkSJ5JN3fmr3tV7CI9ar9lWYl2Ut95UfONJ\n\t8O+v4vxqZIbABjs1baSR8s3BYlgSklpPdADebLkgEGRuu2AjabDIny2wL9fwXtLowWku\n\tGeLLj4HLrkGNsUffvi++AQuAM51LP1f67PdyAKCqcfeDDjwTCXJtWifPVC2wB/XeA7Bj\n\t8SOw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=DuNIJKs2ebfo80SbqgaSWcAxNGMIp5DumfTiALAK+uI=;\n\tb=uZppmkkECOTxo2faFLuXrqEPhfWDuAgVDJ/lNvJAq3enpC2/5MJycbBkVppJFxsmW4\n\tXo8n4jTl7yWp8Tms7T6ToanWDd6d28TkgkxrGncc5ZcSOMjDWZ8H2jYiT2ciOeROJtBS\n\tb/5/KPt/hLHPvRvWmq9sCdFBF4T6Qyq/j+YxUT2EpDP+u0hmaXkPiQWDOHWwoyOuN8aP\n\tj3ZtPyS9qWQr6pfp3k3igSjHchJNHLWVmzYeQO3SJe9vw1CDYF5Qjhj27W7hVl19nE1q\n\tnMVKzuZr2DecDftLsxoLioft0QBsVdlpdBvEuziZvPHOI3rwtFiugxa/SeTn6895lc0P\n\tEY8g==", "X-Gm-Message-State": "APzg51B6RiQBud1Gnm1En2PF6cSW6fQYvrA5Yjskpt0lQFBxe5mK70DD\n\tRXikWrl5muMhV/gakSAqG8tcgR+cKr8=", "X-Google-Smtp-Source": "ANB0VdZj8hzREZ56Bt4Kq+UEUWzD3s0JJubBKkYIpjead0XPoVpSrDLnQOX8JbVQReMhpCAZAK3bYw==", "X-Received": "by 2002:a19:1a05:: with SMTP id\n\ta5-v6mr1198939lfa.54.1535113024947; \n\tFri, 24 Aug 2018 05:17:04 -0700 (PDT)", "From": "Tomasz Duszynski <tdu@semihalf.com>", "To": "dev@dpdk.org", "Cc": "nsamsono@marvell.com,\n\tmw@semihalf.com,\n\ttdu@semihalf.com", "Date": "Fri, 24 Aug 2018 14:16:44 +0200", "Message-Id": "<1535113006-9393-5-git-send-email-tdu@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1535113006-9393-1-git-send-email-tdu@semihalf.com>", "References": "<1535113006-9393-1-git-send-email-tdu@semihalf.com>", "Subject": "[dpdk-dev] [PATCH 4/6] net/mvpp2: fix comments and error messages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Natalie Samsonov <nsamsono@marvell.com>\n\nFix comments and error messages.\n\nFixes: 7235341d7517 (\"net/mrvl: support classifier\")\nCc: tdu@semihalf.com\n\nSigned-off-by: Natalie Samsonov <nsamsono@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_flow.c | 29 +++++++++++++++++++++--------\n 1 file changed, 21 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_flow.c b/drivers/net/mvpp2/mrvl_flow.c\nindex ecc3419..13295e6 100644\n--- a/drivers/net/mvpp2/mrvl_flow.c\n+++ b/drivers/net/mvpp2/mrvl_flow.c\n@@ -394,7 +394,8 @@ mrvl_parse_init(const struct rte_flow_item *item,\n *\n * @param spec Pointer to the specific flow item.\n * @param mask Pointer to the specific flow item's mask.\n- * @param mask Pointer to the flow.\n+ * @param parse_dst Parse either destination or source mac address.\n+ * @param flow Pointer to the flow.\n * @return 0 in case of success, negative error value otherwise.\n */\n static int\n@@ -613,6 +614,7 @@ mrvl_parse_ip4_dscp(const struct rte_flow_item_ipv4 *spec,\n *\n * @param spec Pointer to the specific flow item.\n * @param mask Pointer to the specific flow item's mask.\n+ * @param parse_dst Parse either destination or source ip address.\n * @param flow Pointer to the flow.\n * @return 0 in case of success, negative error value otherwise.\n */\n@@ -726,6 +728,7 @@ mrvl_parse_ip4_proto(const struct rte_flow_item_ipv4 *spec,\n *\n * @param spec Pointer to the specific flow item.\n * @param mask Pointer to the specific flow item's mask.\n+ * @param parse_dst Parse either destination or source ipv6 address.\n * @param flow Pointer to the flow.\n * @return 0 in case of success, negative error value otherwise.\n */\n@@ -874,6 +877,7 @@ mrvl_parse_ip6_next_hdr(const struct rte_flow_item_ipv6 *spec,\n *\n * @param spec Pointer to the specific flow item.\n * @param mask Pointer to the specific flow item's mask.\n+ * @param parse_dst Parse either destination or source port.\n * @param flow Pointer to the flow.\n * @return 0 in case of success, negative error value otherwise.\n */\n@@ -949,6 +953,7 @@ mrvl_parse_tcp_dport(const struct rte_flow_item_tcp *spec,\n *\n * @param spec Pointer to the specific flow item.\n * @param mask Pointer to the specific flow item's mask.\n+ * @param parse_dst Parse either destination or source port.\n * @param flow Pointer to the flow.\n * @return 0 in case of success, negative error value otherwise.\n */\n@@ -1022,7 +1027,6 @@ mrvl_parse_udp_dport(const struct rte_flow_item_udp *spec,\n * @param item Pointer to the flow item.\n * @param flow Pointer to the flow.\n * @param error Pointer to the flow error.\n- * @param fields Pointer to the parsed parsed fields enum.\n * @returns 0 on success, negative value otherwise.\n */\n static int\n@@ -1073,7 +1077,6 @@ mrvl_parse_eth(const struct rte_flow_item *item, struct rte_flow *flow,\n * @param item Pointer to the flow item.\n * @param flow Pointer to the flow.\n * @param error Pointer to the flow error.\n- * @param fields Pointer to the parsed parsed fields enum.\n * @returns 0 on success, negative value otherwise.\n */\n static int\n@@ -1139,7 +1142,6 @@ mrvl_parse_vlan(const struct rte_flow_item *item,\n * @param item Pointer to the flow item.\n * @param flow Pointer to the flow.\n * @param error Pointer to the flow error.\n- * @param fields Pointer to the parsed parsed fields enum.\n * @returns 0 on success, negative value otherwise.\n */\n static int\n@@ -1205,7 +1207,6 @@ mrvl_parse_ip4(const struct rte_flow_item *item,\n * @param item Pointer to the flow item.\n * @param flow Pointer to the flow.\n * @param error Pointer to the flow error.\n- * @param fields Pointer to the parsed parsed fields enum.\n * @returns 0 on success, negative value otherwise.\n */\n static int\n@@ -1276,7 +1277,6 @@ mrvl_parse_ip6(const struct rte_flow_item *item,\n * @param item Pointer to the flow item.\n * @param flow Pointer to the flow.\n * @param error Pointer to the flow error.\n- * @param fields Pointer to the parsed parsed fields enum.\n * @returns 0 on success, negative value otherwise.\n */\n static int\n@@ -1332,7 +1332,6 @@ mrvl_parse_tcp(const struct rte_flow_item *item,\n * @param item Pointer to the flow item.\n * @param flow Pointer to the flow.\n * @param error Pointer to the flow error.\n- * @param fields Pointer to the parsed parsed fields enum.\n * @returns 0 on success, negative value otherwise.\n */\n static int\n@@ -1981,6 +1980,7 @@ mrvl_parse_pattern_ip6_tcp(const struct rte_flow_item pattern[],\n * @param pattern Pointer to the flow pattern table.\n * @param flow Pointer to the flow.\n * @param error Pointer to the flow error.\n+ * @param ip6 1 to parse ip6 item, 0 to parse ip4 item.\n * @returns 0 in case of success, negative value otherwise.\n */\n static int\n@@ -2350,6 +2350,12 @@ mrvl_flow_parse(struct mrvl_priv *priv, const struct rte_flow_attr *attr,\n \treturn mrvl_flow_parse_actions(priv, actions, flow, error);\n }\n \n+/**\n+ * Get engine type for the given flow.\n+ *\n+ * @param field Pointer to the flow.\n+ * @returns The type of the engine.\n+ */\n static inline enum pp2_cls_tbl_type\n mrvl_engine_type(const struct rte_flow *flow)\n {\n@@ -2369,6 +2375,13 @@ mrvl_engine_type(const struct rte_flow *flow)\n \treturn PP2_CLS_TBL_MASKABLE;\n }\n \n+/**\n+ * Create classifier table.\n+ *\n+ * @param dev Pointer to the device.\n+ * @param flow Pointer to the very first flow.\n+ * @returns 0 in case of success, negative value otherwise.\n+ */\n static int\n mrvl_create_cls_table(struct rte_eth_dev *dev, struct rte_flow *first_flow)\n {\n@@ -2655,7 +2668,7 @@ mrvl_flow_remove(struct mrvl_priv *priv, struct rte_flow *flow,\n /**\n * DPDK flow destroy callback called when flow is to be removed.\n *\n- * @param priv Pointer to the port's private data.\n+ * @param dev Pointer to the device.\n * @param flow Pointer to the flow.\n * @param error Pointer to the flow error.\n * @returns 0 in case of success, negative value otherwise.\n", "prefixes": [ "4/6" ] }