Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43848/?format=api
{ "id": 43848, "url": "http://patches.dpdk.org/api/patches/43848/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1535113006-9393-2-git-send-email-tdu@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1535113006-9393-2-git-send-email-tdu@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1535113006-9393-2-git-send-email-tdu@semihalf.com", "date": "2018-08-24T12:16:41", "name": "[1/6] drivers/common: add mvep common code for MRVL PMDs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1f851c679633ed16f4b36f9b081aa46b5900f7e4", "submitter": { "id": 846, "url": "http://patches.dpdk.org/api/people/846/?format=api", "name": "Tomasz Duszynski", "email": "tdu@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1535113006-9393-2-git-send-email-tdu@semihalf.com/mbox/", "series": [ { "id": 1044, "url": "http://patches.dpdk.org/api/series/1044/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1044", "date": "2018-08-24T12:16:40", "name": "mvpp2 changes and features", "version": 1, "mbox": "http://patches.dpdk.org/series/1044/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43848/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43848/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A498E4C99;\n\tFri, 24 Aug 2018 14:17:04 +0200 (CEST)", "from mail-lf1-f67.google.com (mail-lf1-f67.google.com\n\t[209.85.167.67]) by dpdk.org (Postfix) with ESMTP id B33282C0C\n\tfor <dev@dpdk.org>; Fri, 24 Aug 2018 14:17:01 +0200 (CEST)", "by mail-lf1-f67.google.com with SMTP id r4-v6so6517559lff.12\n\tfor <dev@dpdk.org>; Fri, 24 Aug 2018 05:17:01 -0700 (PDT)", "from sh.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\ta18-v6sm1177672ljk.47.2018.08.24.05.16.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 24 Aug 2018 05:17:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=whQCTFmUsFodd4jf4DSppMYjFlndEVDuT+eYk5+PsKU=;\n\tb=F3eJXwmtdNYmigGkDI9XvDT3V7aU7lKi5d6wmOXPtGnovMIVU/Vp4Shtc1BVzaAhYV\n\tR7rc15FWHcGqqYhoE4VLhd3Sx152DlkHoe7jvaTFoYSDCCsyZEH6/2Mb6gNeBFoCGhGF\n\tWbHkdeKic/EFyf0fFGfcPcVEZLOke1i3wrkkghMJi3UChQp+0U15ON0NV4+Io7tjVRiy\n\t5lM6/P7LiPEWeuUtGE7TEhhw2y9Zzs1x81koqJi4Ujht9hRGOO7ZYA5fNJuJbNk3IrxT\n\tf5Z5IBRs35W5YTlCknRgypHwhB1/gnXVQnZnStwwis4oQYPy8m3B6q7jfLy5Sm+dCkHx\n\tZlOw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=whQCTFmUsFodd4jf4DSppMYjFlndEVDuT+eYk5+PsKU=;\n\tb=nspo1Jl9PGkg0YqQU6Nltfmt4nYERaH7KDqkM/r+VycZRrVpwDzcCjfVBKFF9z/fdU\n\tu0dK1mzWngtcpMv7jGxQUVSYa+9NyHC12Iy4uzSCmxGGTt8hZB5GpLxA4fWP0ZOXcw6S\n\tt/yngE0ee3gk6RvZp+4K9k6NXQznZJtY3yBqyf56vfE82UI3BsU3ZZxSU4VNGj4VZaDc\n\tHjz3r0L3KWT72MU0XOg/Oh8QMvbH+w/9srEo3PiEyGKI2G6XI7z6YdXj1hOXlaJtgNSI\n\tbnjDFekkk6bDHDTNsyTwAUdGNfRxRH6dilTYfAxF3ELI09805NzxUcQC0+cAIQ0vDKSM\n\t3p+Q==", "X-Gm-Message-State": "APzg51AtcuOGreBiTxyLGEtEDgPqALKr8da4ERi14Sw/tkgIEpa/d/OK\n\tO/KDb2yxmgKFcuUdmxz8c2jk/k4PmEA=", "X-Google-Smtp-Source": "ANB0VdZ7tjD9ygx6XsQthHaQHQuYFWMaWn7ysvglAlnkuCdwJ7dYD1i2a0pWfeuaKNlNGGr1r5gNcA==", "X-Received": "by 2002:a19:3bd4:: with SMTP id\n\td81-v6mr1170490lfl.96.1535113021127; \n\tFri, 24 Aug 2018 05:17:01 -0700 (PDT)", "From": "Tomasz Duszynski <tdu@semihalf.com>", "To": "dev@dpdk.org", "Cc": "nsamsono@marvell.com, mw@semihalf.com, Liron Himi <lironh@marvell.com>, \n\tTomasz Duszynski <tdu@semihalf.com>", "Date": "Fri, 24 Aug 2018 14:16:41 +0200", "Message-Id": "<1535113006-9393-2-git-send-email-tdu@semihalf.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1535113006-9393-1-git-send-email-tdu@semihalf.com>", "References": "<1535113006-9393-1-git-send-email-tdu@semihalf.com>", "Subject": "[dpdk-dev] [PATCH 1/6] drivers/common: add mvep common code for\n\tMRVL PMDs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Liron Himi <lironh@marvell.com>\n\nAdd MVEP (Marvell Embedded Processors) to drivers/common which\nwill keep code reused by current and future MRVL PMDs.\nRight now we have only common DMA memory initialization routines there.\n\nSigned-off-by: Liron Himi <lironh@marvell.com>\nSigned-off-by: Tomasz Duszynski <tdu@semihalf.com>\nReviewed-by: Natalie Samsonov <nsamsono@marvell.com>\n---\n config/common_base | 5 +++\n devtools/test-build.sh | 2 ++\n drivers/common/Makefile | 4 +++\n drivers/common/meson.build | 2 +-\n drivers/common/mvep/Makefile | 38 +++++++++++++++++++++\n drivers/common/mvep/meson.build | 19 +++++++++++\n drivers/common/mvep/mvep_common.c | 45 +++++++++++++++++++++++++\n drivers/common/mvep/rte_common_mvep_version.map | 6 ++++\n drivers/common/mvep/rte_mvep_common.h | 20 +++++++++++\n mk/rte.app.mk | 4 +++\n 10 files changed, 144 insertions(+), 1 deletion(-)\n create mode 100644 drivers/common/mvep/Makefile\n create mode 100644 drivers/common/mvep/meson.build\n create mode 100644 drivers/common/mvep/mvep_common.c\n create mode 100644 drivers/common/mvep/rte_common_mvep_version.map\n create mode 100644 drivers/common/mvep/rte_mvep_common.h", "diff": "diff --git a/config/common_base b/config/common_base\nindex 4bcbaf9..978592d 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -395,6 +395,11 @@ CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n\n CONFIG_RTE_LIBRTE_PMD_FAILSAFE=y\n \n #\n+# Compile Marvell Embedded Processors Common\n+#\n+CONFIG_RTE_LIBRTE_MVEP_COMMON=n\n+\n+#\n # Compile Marvell PMD driver\n #\n CONFIG_RTE_LIBRTE_MVPP2_PMD=n\ndiff --git a/devtools/test-build.sh b/devtools/test-build.sh\nindex 1eee241..82861b2 100755\n--- a/devtools/test-build.sh\n+++ b/devtools/test-build.sh\n@@ -182,6 +182,8 @@ config () # <directory> <target> <options>\n \t\tsed -ri 's,(PMD_MVSAM_CRYPTO=)n,\\1y,' $1/.config\n \t\ttest -z \"$LIBMUSDK_PATH\" || \\\n \t\tsed -ri 's,(MVPP2_PMD=)n,\\1y,' $1/.config\n+\t\ttest -z \"$LIBMUSDK_PATH\" || \\\n+\t\tsed -ri 's,(MVEP_COMMON=)n,\\1y,' $1/.config\n \t\tbuild_config_hook $1 $2 $3\n \n \t\t# Explicit enabler/disabler (uppercase)\ndiff --git a/drivers/common/Makefile b/drivers/common/Makefile\nindex 0fd2237..1795133 100644\n--- a/drivers/common/Makefile\n+++ b/drivers/common/Makefile\n@@ -8,4 +8,8 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOO\n DIRS-y += octeontx\n endif\n \n+ifeq ($(CONFIG_RTE_LIBRTE_MVEP_COMMON),y)\n+DIRS-$(CONFIG_RTE_LIBRTE_MVEP_COMMON) += mvep\n+endif\n+\n include $(RTE_SDK)/mk/rte.subdir.mk\ndiff --git a/drivers/common/meson.build b/drivers/common/meson.build\nindex d7b7d8c..f828ce7 100644\n--- a/drivers/common/meson.build\n+++ b/drivers/common/meson.build\n@@ -2,6 +2,6 @@\n # Copyright(c) 2018 Cavium, Inc\n \n std_deps = ['eal']\n-drivers = ['octeontx', 'qat']\n+drivers = ['mvep', 'octeontx', 'qat']\n config_flag_fmt = 'RTE_LIBRTE_@0@_COMMON'\n driver_name_fmt = 'rte_common_@0@'\ndiff --git a/drivers/common/mvep/Makefile b/drivers/common/mvep/Makefile\nnew file mode 100644\nindex 0000000..845bb47\n--- /dev/null\n+++ b/drivers/common/mvep/Makefile\n@@ -0,0 +1,38 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2018 Marvell International Ltd.\n+#\n+\n+include $(RTE_SDK)/mk/rte.vars.mk\n+\n+ifneq ($(MAKECMDGOALS),clean)\n+ifneq ($(MAKECMDGOALS),config)\n+ifeq ($(LIBMUSDK_PATH),)\n+$(error \"Please define LIBMUSDK_PATH environment variable\")\n+endif\n+endif\n+endif\n+\n+# library name\n+LIB = librte_common_mvep.a\n+\n+# library version\n+LIBABIVER := 1\n+\n+# versioning export map\n+EXPORT_MAP := rte_common_mvep_version.map\n+\n+# external library dependencies\n+CFLAGS += -I$($RTE_SDK)/drivers/common/mvep\n+CFLAGS += -I$(LIBMUSDK_PATH)/include\n+CFLAGS += -DMVCONF_TYPES_PUBLIC\n+CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC\n+CFLAGS += $(WERROR_FLAGS)\n+CFLAGS += -O3\n+LDLIBS += -L$(LIBMUSDK_PATH)/lib\n+LDLIBS += -lmusdk\n+LDLIBS += -lrte_eal -lrte_kvargs\n+\n+# library source files\n+SRCS-$(CONFIG_RTE_LIBRTE_MVEP_COMMON) += mvep_common.c\n+\n+include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/drivers/common/mvep/meson.build b/drivers/common/mvep/meson.build\nnew file mode 100644\nindex 0000000..8ccfacb\n--- /dev/null\n+++ b/drivers/common/mvep/meson.build\n@@ -0,0 +1,19 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2018 Marvell International Ltd.\n+# Copyright(c) 2018 Semihalf.\n+# All rights reserved.\n+#\n+path = get_option('lib_musdk_dir')\n+lib_dir = path + '/lib'\n+inc_dir = path + '/include'\n+\n+lib = cc.find_library('libmusdk', dirs: [lib_dir], required: false)\n+if not lib.found()\n+\tbuild = false\n+else\n+\text_deps += lib\n+\tincludes += include_directories(inc_dir)\n+\tcflags += ['-DMVCONF_TYPES_PUBLIC', '-DMVCONF_DMA_PHYS_ADDR_T_PUBLIC']\n+endif\n+\n+sources = files('mvep_common.c')\ndiff --git a/drivers/common/mvep/mvep_common.c b/drivers/common/mvep/mvep_common.c\nnew file mode 100644\nindex 0000000..67fa65b\n--- /dev/null\n+++ b/drivers/common/mvep/mvep_common.c\n@@ -0,0 +1,45 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Marvell International Ltd.\n+ */\n+\n+#include <rte_common.h>\n+\n+#include <env/mv_autogen_comp_flags.h>\n+#include <env/mv_sys_dma.h>\n+\n+#include \"rte_mvep_common.h\"\n+\n+/* Memory size (in bytes) for MUSDK dma buffers */\n+#define MRVL_MUSDK_DMA_MEMSIZE (40 * 1024 * 1024)\n+\n+struct mvep {\n+\tuint32_t ref_count;\n+};\n+\n+static struct mvep mvep;\n+\n+int rte_mvep_init(enum mvep_module_type module __rte_unused,\n+\t\t struct rte_kvargs *kvlist __rte_unused)\n+{\n+\tint ret;\n+\n+\tif (!mvep.ref_count) {\n+\t\tret = mv_sys_dma_mem_init(MRVL_MUSDK_DMA_MEMSIZE);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n+\n+\tmvep.ref_count++;\n+\n+\treturn 0;\n+}\n+\n+int rte_mvep_deinit(enum mvep_module_type module __rte_unused)\n+{\n+\tmvep.ref_count--;\n+\n+\tif (!mvep.ref_count)\n+\t\tmv_sys_dma_mem_destroy();\n+\n+\treturn 0;\n+}\ndiff --git a/drivers/common/mvep/rte_common_mvep_version.map b/drivers/common/mvep/rte_common_mvep_version.map\nnew file mode 100644\nindex 0000000..fa1a1b8\n--- /dev/null\n+++ b/drivers/common/mvep/rte_common_mvep_version.map\n@@ -0,0 +1,6 @@\n+DPDK_18.08 {\n+\tglobal:\n+\n+\trte_mvep_init;\n+\trte_mvep_deinit;\n+};\ndiff --git a/drivers/common/mvep/rte_mvep_common.h b/drivers/common/mvep/rte_mvep_common.h\nnew file mode 100644\nindex 0000000..ba47e16\n--- /dev/null\n+++ b/drivers/common/mvep/rte_mvep_common.h\n@@ -0,0 +1,20 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Marvell International Ltd.\n+ */\n+\n+#ifndef __RTE_MVEP_COMMON_H__\n+#define __RTE_MVEP_COMMON_H__\n+\n+#include <rte_kvargs.h>\n+\n+enum mvep_module_type {\n+\tMVEP_MOD_T_NONE = 0,\n+\tMVEP_MOD_T_PP2,\n+\tMVEP_MOD_T_SAM,\n+\tMVEP_MOD_T_LAST\n+};\n+\n+int rte_mvep_init(enum mvep_module_type module, struct rte_kvargs *kvlist);\n+int rte_mvep_deinit(enum mvep_module_type module);\n+\n+#endif /* __RTE_MVEP_COMMON_H__ */\ndiff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex de33883..a9c9b4f 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -98,6 +98,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOO\n _LDLIBS-y += -lrte_common_octeontx\n endif\n \n+ifeq ($(CONFIG_RTE_LIBRTE_MVEP_COMMON),y)\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_MVEP_COMMON) += -lrte_common_mvep -L$(LIBMUSDK_PATH)/lib -lmusdk\n+endif\n+\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI_BUS) += -lrte_bus_pci\n _LDLIBS-$(CONFIG_RTE_LIBRTE_VDEV_BUS) += -lrte_bus_vdev\n _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_BUS) += -lrte_bus_dpaa\n", "prefixes": [ "1/6" ] }