Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43834/?format=api
{ "id": 43834, "url": "http://patches.dpdk.org/api/patches/43834/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/e23e16fdb2e7a8ac527203401e177d6ae37eeb3c.1535041359.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<e23e16fdb2e7a8ac527203401e177d6ae37eeb3c.1535041359.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e23e16fdb2e7a8ac527203401e177d6ae37eeb3c.1535041359.git.anatoly.burakov@intel.com", "date": "2018-08-23T16:59:48", "name": "[1/8] fbarray: fix detach in noshconf mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a436430f73b40c384afdf01e6a8e3838c6e38d05", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/e23e16fdb2e7a8ac527203401e177d6ae37eeb3c.1535041359.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 1040, "url": "http://patches.dpdk.org/api/series/1040/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1040", "date": "2018-08-23T16:59:47", "name": "Improve running DPDK without hugetlbfs mounpoint", "version": 1, "mbox": "http://patches.dpdk.org/series/1040/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43834/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43834/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3939F4C99;\n\tThu, 23 Aug 2018 19:00:02 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 0564F2C38;\n\tThu, 23 Aug 2018 18:59:58 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Aug 2018 09:59:58 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga007.fm.intel.com with ESMTP; 23 Aug 2018 09:59:56 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw7NGxtAD025427; Thu, 23 Aug 2018 17:59:55 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w7NGxtCS006689;\n\tThu, 23 Aug 2018 17:59:55 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w7NGxtUx006685;\n\tThu, 23 Aug 2018 17:59:55 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,278,1531810800\"; d=\"scan'208\";a=\"64676723\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "tiwei.bie@intel.com, ray.kinsella@intel.com, zhihong.wang@intel.com,\n\tmaxime.coquelin@redhat.com, kuralamudhan.ramakrishnan@intel.com,\n\tstable@dpdk.org", "Date": "Thu, 23 Aug 2018 17:59:48 +0100", "Message-Id": "<e23e16fdb2e7a8ac527203401e177d6ae37eeb3c.1535041359.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1535041359.git.anatoly.burakov@intel.com>", "<cover.1535041359.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1535041359.git.anatoly.burakov@intel.com>", "<cover.1535041359.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 1/8] fbarray: fix detach in noshconf mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In noshconf mode, no shared files are created, but we're still trying\nto unlink them, resulting in detach/destroy failure even though it\nshould have succeeded. Fix it by exiting early in noshconf mode.\n\nFixes: 3ee2cde248a7 (\"fbarray: support --no-shconf mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_fbarray.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c\nindex 43caf3ced..ba6c4ae39 100644\n--- a/lib/librte_eal/common/eal_common_fbarray.c\n+++ b/lib/librte_eal/common/eal_common_fbarray.c\n@@ -878,6 +878,10 @@ rte_fbarray_destroy(struct rte_fbarray *arr)\n \tif (ret)\n \t\treturn ret;\n \n+\t/* with no shconf, there were never any files to begin with */\n+\tif (internal_config.no_shconf)\n+\t\treturn 0;\n+\n \t/* try deleting the file */\n \teal_get_fbarray_path(path, sizeof(path), arr->name);\n \n", "prefixes": [ "1/8" ] }