Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43832/?format=api
{ "id": 43832, "url": "http://patches.dpdk.org/api/patches/43832/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180823165157.30001-11-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180823165157.30001-11-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180823165157.30001-11-maxime.coquelin@redhat.com", "date": "2018-08-23T16:51:57", "name": "[RFC,10/10] vhost: enable postcopy protocol feature", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "64263565c30c1e3c29c03a2654728540d7adc898", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180823165157.30001-11-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1039, "url": "http://patches.dpdk.org/api/series/1039/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1039", "date": "2018-08-23T16:51:47", "name": "vhost: add postcopy live-migration support", "version": 1, "mbox": "http://patches.dpdk.org/series/1039/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43832/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43832/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 555DF5A6E;\n\tThu, 23 Aug 2018 18:52:31 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id CC95858FA\n\tfor <dev@dpdk.org>; Thu, 23 Aug 2018 18:52:28 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 758F97A7EA;\n\tThu, 23 Aug 2018 16:52:28 +0000 (UTC)", "from localhost.localdomain (ovpn-112-46.ams2.redhat.com\n\t[10.36.112.46])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id ED4852166BA1;\n\tThu, 23 Aug 2018 16:52:26 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com", "Cc": "dgilbert@redhat.com,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 23 Aug 2018 18:51:57 +0200", "Message-Id": "<20180823165157.30001-11-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180823165157.30001-1-maxime.coquelin@redhat.com>", "References": "<20180823165157.30001-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.2]); Thu, 23 Aug 2018 16:52:28 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.2]); \n\tThu, 23 Aug 2018 16:52:28 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [RFC 10/10] vhost: enable postcopy protocol feature", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Enable postcopy protocol feature except if dequeue\nzero-copy is enabled. In this case, guest memory requires\nto be populated, which is not compatible with userfaultfd.\n\nSigned-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 7 +++++++\n lib/librte_vhost/vhost_user.h | 3 ++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 54692775c..1a31d8551 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1235,6 +1235,13 @@ vhost_user_get_protocol_features(struct virtio_net *dev,\n \tif (!(features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)))\n \t\tprotocol_features &= ~(1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK);\n \n+\t/*\n+\t * If dequeue zerocopy is enabled, guest memory requires to be\n+\t * populated, which is not compatible with postcopy.\n+\t */\n+\tif (dev->dequeue_zero_copy)\n+\t\tprotocol_features &= ~(1ULL << VHOST_USER_PROTOCOL_F_PAGEFAULT);\n+\n \tmsg->payload.u64 = protocol_features;\n \tmsg->size = sizeof(msg->payload.u64);\n \tmsg->fd_num = 0;\ndiff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h\nindex 73b1fe2b9..dc97be843 100644\n--- a/lib/librte_vhost/vhost_user.h\n+++ b/lib/librte_vhost/vhost_user.h\n@@ -22,7 +22,8 @@\n \t\t\t\t\t (1ULL << VHOST_USER_PROTOCOL_F_SLAVE_REQ) | \\\n \t\t\t\t\t (1ULL << VHOST_USER_PROTOCOL_F_CRYPTO_SESSION) | \\\n \t\t\t\t\t (1ULL << VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD) | \\\n-\t\t\t\t\t (1ULL << VHOST_USER_PROTOCOL_F_HOST_NOTIFIER))\n+\t\t\t\t\t (1ULL << VHOST_USER_PROTOCOL_F_HOST_NOTIFIER) | \\\n+\t\t\t\t\t (1ULL << VHOST_USER_PROTOCOL_F_PAGEFAULT))\n \n typedef enum VhostUserRequest {\n \tVHOST_USER_NONE = 0,\n", "prefixes": [ "RFC", "10/10" ] }