Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43829/?format=api
{ "id": 43829, "url": "http://patches.dpdk.org/api/patches/43829/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180823165157.30001-8-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180823165157.30001-8-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180823165157.30001-8-maxime.coquelin@redhat.com", "date": "2018-08-23T16:51:54", "name": "[RFC,07/10] vhost: avoid useless VhostUserMemory copy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7d205b86518a5f82fe99a9be286b17e20dfcbade", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180823165157.30001-8-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1039, "url": "http://patches.dpdk.org/api/series/1039/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1039", "date": "2018-08-23T16:51:47", "name": "vhost: add postcopy live-migration support", "version": 1, "mbox": "http://patches.dpdk.org/series/1039/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43829/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43829/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D42CE5699;\n\tThu, 23 Aug 2018 18:52:22 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id 140164CC3\n\tfor <dev@dpdk.org>; Thu, 23 Aug 2018 18:52:20 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9EECA87A78;\n\tThu, 23 Aug 2018 16:52:19 +0000 (UTC)", "from localhost.localdomain (ovpn-112-46.ams2.redhat.com\n\t[10.36.112.46])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 385BF2166BA1;\n\tThu, 23 Aug 2018 16:52:18 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com", "Cc": "dgilbert@redhat.com,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 23 Aug 2018 18:51:54 +0200", "Message-Id": "<20180823165157.30001-8-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180823165157.30001-1-maxime.coquelin@redhat.com>", "References": "<20180823165157.30001-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.1]); Thu, 23 Aug 2018 16:52:19 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.1]); \n\tThu, 23 Aug 2018 16:52:19 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [RFC 07/10] vhost: avoid useless VhostUserMemory copy", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The VHOST_USER_SET_MEM_TABLE payload is copied when handled,\nwhereas it could directly be referenced.\n\nThis is not very important, but next, we'll need to update the\npayload and send it back to Qemu.\n\nSigned-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 1c75d8015..0861feff1 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -787,7 +787,7 @@ static int\n vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)\n {\n \tstruct virtio_net *dev = *pdev;\n-\tstruct VhostUserMemory memory = pmsg->payload.memory;\n+\tstruct VhostUserMemory *memory = &pmsg->payload.memory;\n \tstruct rte_vhost_mem_region *reg;\n \tvoid *mmap_addr;\n \tuint64_t mmap_size;\n@@ -797,17 +797,17 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)\n \tint populate;\n \tint fd;\n \n-\tif (memory.nregions > VHOST_MEMORY_MAX_NREGIONS) {\n+\tif (memory->nregions > VHOST_MEMORY_MAX_NREGIONS) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n-\t\t\t\"too many memory regions (%u)\\n\", memory.nregions);\n+\t\t\t\"too many memory regions (%u)\\n\", memory->nregions);\n \t\treturn -1;\n \t}\n \n-\tif (dev->mem && !vhost_memory_changed(&memory, dev->mem)) {\n+\tif (dev->mem && !vhost_memory_changed(memory, dev->mem)) {\n \t\tRTE_LOG(INFO, VHOST_CONFIG,\n \t\t\t\"(%d) memory regions not changed\\n\", dev->vid);\n \n-\t\tfor (i = 0; i < memory.nregions; i++)\n+\t\tfor (i = 0; i < memory->nregions; i++)\n \t\t\tclose(pmsg->fds[i]);\n \n \t\treturn 0;\n@@ -839,25 +839,25 @@ vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *pmsg)\n \t}\n \n \tdev->mem = rte_zmalloc(\"vhost-mem-table\", sizeof(struct rte_vhost_memory) +\n-\t\tsizeof(struct rte_vhost_mem_region) * memory.nregions, 0);\n+\t\tsizeof(struct rte_vhost_mem_region) * memory->nregions, 0);\n \tif (dev->mem == NULL) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\"(%d) failed to allocate memory for dev->mem\\n\",\n \t\t\tdev->vid);\n \t\treturn -1;\n \t}\n-\tdev->mem->nregions = memory.nregions;\n+\tdev->mem->nregions = memory->nregions;\n \n-\tfor (i = 0; i < memory.nregions; i++) {\n+\tfor (i = 0; i < memory->nregions; i++) {\n \t\tfd = pmsg->fds[i];\n \t\treg = &dev->mem->regions[i];\n \n-\t\treg->guest_phys_addr = memory.regions[i].guest_phys_addr;\n-\t\treg->guest_user_addr = memory.regions[i].userspace_addr;\n-\t\treg->size = memory.regions[i].memory_size;\n+\t\treg->guest_phys_addr = memory->regions[i].guest_phys_addr;\n+\t\treg->guest_user_addr = memory->regions[i].userspace_addr;\n+\t\treg->size = memory->regions[i].memory_size;\n \t\treg->fd = fd;\n \n-\t\tmmap_offset = memory.regions[i].mmap_offset;\n+\t\tmmap_offset = memory->regions[i].mmap_offset;\n \n \t\t/* Check for memory_size + mmap_offset overflow */\n \t\tif (mmap_offset >= -reg->size) {\n", "prefixes": [ "RFC", "07/10" ] }