Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43826/?format=api
{ "id": 43826, "url": "http://patches.dpdk.org/api/patches/43826/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180823165157.30001-5-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180823165157.30001-5-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180823165157.30001-5-maxime.coquelin@redhat.com", "date": "2018-08-23T16:51:51", "name": "[RFC,04/10] vhost: introduce postcopy's advise message", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d4479b71957508c437debbca3946d8a7bb49631c", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180823165157.30001-5-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1039, "url": "http://patches.dpdk.org/api/series/1039/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1039", "date": "2018-08-23T16:51:47", "name": "vhost: add postcopy live-migration support", "version": 1, "mbox": "http://patches.dpdk.org/series/1039/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43826/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43826/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 952B34CB5;\n\tThu, 23 Aug 2018 18:52:17 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id 929CB4CA5\n\tfor <dev@dpdk.org>; Thu, 23 Aug 2018 18:52:14 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 39FB9401B1F7;\n\tThu, 23 Aug 2018 16:52:14 +0000 (UTC)", "from localhost.localdomain (ovpn-112-46.ams2.redhat.com\n\t[10.36.112.46])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AE3902166BA1;\n\tThu, 23 Aug 2018 16:52:12 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com", "Cc": "dgilbert@redhat.com,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 23 Aug 2018 18:51:51 +0200", "Message-Id": "<20180823165157.30001-5-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180823165157.30001-1-maxime.coquelin@redhat.com>", "References": "<20180823165157.30001-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.6]); Thu, 23 Aug 2018 16:52:14 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.6]); \n\tThu, 23 Aug 2018 16:52:14 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [RFC 04/10] vhost: introduce postcopy's advise message", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch opens a userfaultfd and sends it back to Qemu's\nVHOST_USER_POSTCOPY_ADVISE request.\n\nSigned-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost.h | 2 ++\n lib/librte_vhost/vhost_user.c | 37 +++++++++++++++++++++++++++++++++++\n lib/librte_vhost/vhost_user.h | 3 ++-\n 3 files changed, 41 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex 760a09c0d..2606743d9 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -363,6 +363,8 @@ struct virtio_net {\n \tint\t\t\tslave_req_fd;\n \trte_spinlock_t\t\tslave_req_lock;\n \n+\tint\t\t\tpostcopy_ufd;\n+\n \t/*\n \t * Device id to identify a specific backend device.\n \t * It's set to -1 for the default software implementation.\ndiff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 9d1e9cf75..beca18a18 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -24,9 +24,13 @@\n #include <stdlib.h>\n #include <string.h>\n #include <unistd.h>\n+#include <fcntl.h>\n+#include <linux/userfaultfd.h>\n+#include <sys/ioctl.h>\n #include <sys/mman.h>\n #include <sys/types.h>\n #include <sys/stat.h>\n+#include <sys/syscall.h>\n #include <assert.h>\n #ifdef RTE_LIBRTE_VHOST_NUMA\n #include <numaif.h>\n@@ -69,6 +73,7 @@ static const char *vhost_message_str[VHOST_USER_MAX] = {\n \t[VHOST_USER_IOTLB_MSG] = \"VHOST_USER_IOTLB_MSG\",\n \t[VHOST_USER_CRYPTO_CREATE_SESS] = \"VHOST_USER_CRYPTO_CREATE_SESS\",\n \t[VHOST_USER_CRYPTO_CLOSE_SESS] = \"VHOST_USER_CRYPTO_CLOSE_SESS\",\n+\t[VHOST_USER_POSTCOPY_ADVISE] = \"VHOST_USER_POSTCOPY_ADVISE\",\n };\n \n static uint64_t\n@@ -1404,6 +1409,33 @@ vhost_user_iotlb_msg(struct virtio_net **pdev, struct VhostUserMsg *msg)\n \treturn 0;\n }\n \n+static int\n+vhost_user_set_postcopy_advise(struct virtio_net *dev, struct VhostUserMsg *msg)\n+{\n+\tstruct uffdio_api api_struct;\n+\n+\n+\tdev->postcopy_ufd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK);\n+\n+\tif (dev->postcopy_ufd == -1) {\n+\t\tRTE_LOG(ERR, VHOST_CONFIG, \"Userfaultfd not available: %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\treturn -1;\n+\t}\n+\tapi_struct.api = UFFD_API;\n+\tapi_struct.features = 0;\n+\tif (ioctl(dev->postcopy_ufd, UFFDIO_API, &api_struct)) {\n+\t\tRTE_LOG(ERR, VHOST_CONFIG, \"UFFDIO_API ioctl failure: %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\tclose(dev->postcopy_ufd);\n+\t\treturn -1;\n+\t}\n+\tmsg->fds[0] = dev->postcopy_ufd;\n+\tmsg->fd_num = 1;\n+\n+\treturn 0;\n+}\n+\n /* return bytes# of read on success or negative val on failure. */\n static int\n read_vhost_message(int sockfd, struct VhostUserMsg *msg)\n@@ -1747,6 +1779,11 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tret = vhost_user_iotlb_msg(&dev, &msg);\n \t\tbreak;\n \n+\tcase VHOST_USER_POSTCOPY_ADVISE:\n+\t\tvhost_user_set_postcopy_advise(dev, &msg);\n+\t\tsend_vhost_reply(fd, &msg);\n+\t\tbreak;\n+\n \tdefault:\n \t\tret = -1;\n \t\tbreak;\ndiff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h\nindex dd0262f8f..2030b40a5 100644\n--- a/lib/librte_vhost/vhost_user.h\n+++ b/lib/librte_vhost/vhost_user.h\n@@ -50,7 +50,8 @@ typedef enum VhostUserRequest {\n \tVHOST_USER_IOTLB_MSG = 22,\n \tVHOST_USER_CRYPTO_CREATE_SESS = 26,\n \tVHOST_USER_CRYPTO_CLOSE_SESS = 27,\n-\tVHOST_USER_MAX = 28\n+\tVHOST_USER_POSTCOPY_ADVISE = 28,\n+\tVHOST_USER_MAX = 29\n } VhostUserRequest;\n \n typedef enum VhostUserSlaveRequest {\n", "prefixes": [ "RFC", "04/10" ] }