Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43825/?format=api
http://patches.dpdk.org/api/patches/43825/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180823165157.30001-4-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180823165157.30001-4-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180823165157.30001-4-maxime.coquelin@redhat.com", "date": "2018-08-23T16:51:50", "name": "[RFC,03/10] vhost: enable fds passing when sending vhost-user messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a7f5deeebe5140ca57acb43363431bea17c689f8", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180823165157.30001-4-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1039, "url": "http://patches.dpdk.org/api/series/1039/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1039", "date": "2018-08-23T16:51:47", "name": "vhost: add postcopy live-migration support", "version": 1, "mbox": "http://patches.dpdk.org/series/1039/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43825/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43825/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BD7EA4CAD;\n\tThu, 23 Aug 2018 18:52:15 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id BFBA44C9F\n\tfor <dev@dpdk.org>; Thu, 23 Aug 2018 18:52:12 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 661A6401B1F7;\n\tThu, 23 Aug 2018 16:52:12 +0000 (UTC)", "from localhost.localdomain (ovpn-112-46.ams2.redhat.com\n\t[10.36.112.46])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 72D182166BA1;\n\tThu, 23 Aug 2018 16:52:10 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com", "Cc": "dgilbert@redhat.com,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 23 Aug 2018 18:51:50 +0200", "Message-Id": "<20180823165157.30001-4-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180823165157.30001-1-maxime.coquelin@redhat.com>", "References": "<20180823165157.30001-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.6]); Thu, 23 Aug 2018 16:52:12 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.6]); \n\tThu, 23 Aug 2018 16:52:12 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [RFC 03/10] vhost: enable fds passing when sending\n\tvhost-user messages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Passing userfault fds to Qemu will be required for postcopy\nlive-migration feature.\n\nSigned-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 26 ++++++++++++++------------\n 1 file changed, 14 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 0a7cbfa14..9d1e9cf75 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1168,6 +1168,7 @@ vhost_user_get_protocol_features(struct virtio_net *dev,\n \n \tmsg->payload.u64 = protocol_features;\n \tmsg->size = sizeof(msg->payload.u64);\n+\tmsg->fd_num = 0;\n }\n \n static void\n@@ -1434,13 +1435,13 @@ read_vhost_message(int sockfd, struct VhostUserMsg *msg)\n }\n \n static int\n-send_vhost_message(int sockfd, struct VhostUserMsg *msg, int *fds, int fd_num)\n+send_vhost_message(int sockfd, struct VhostUserMsg *msg)\n {\n \tif (!msg)\n \t\treturn 0;\n \n \treturn send_fd_message(sockfd, (char *)msg,\n-\t\tVHOST_USER_HDR_SIZE + msg->size, fds, fd_num);\n+\t\tVHOST_USER_HDR_SIZE + msg->size, msg->fds, msg->fd_num);\n }\n \n static int\n@@ -1454,19 +1455,18 @@ send_vhost_reply(int sockfd, struct VhostUserMsg *msg)\n \tmsg->flags |= VHOST_USER_VERSION;\n \tmsg->flags |= VHOST_USER_REPLY_MASK;\n \n-\treturn send_vhost_message(sockfd, msg, NULL, 0);\n+\treturn send_vhost_message(sockfd, msg);\n }\n \n static int\n-send_vhost_slave_message(struct virtio_net *dev, struct VhostUserMsg *msg,\n-\t\t\t int *fds, int fd_num)\n+send_vhost_slave_message(struct virtio_net *dev, struct VhostUserMsg *msg)\n {\n \tint ret;\n \n \tif (msg->flags & VHOST_USER_NEED_REPLY)\n \t\trte_spinlock_lock(&dev->slave_req_lock);\n \n-\tret = send_vhost_message(dev->slave_req_fd, msg, fds, fd_num);\n+\tret = send_vhost_message(dev->slave_req_fd, msg);\n \tif (ret < 0 && (msg->flags & VHOST_USER_NEED_REPLY))\n \t\trte_spinlock_unlock(&dev->slave_req_lock);\n \n@@ -1651,6 +1651,7 @@ vhost_user_msg_handler(int vid, int fd)\n \tcase VHOST_USER_GET_FEATURES:\n \t\tmsg.payload.u64 = vhost_user_get_features(dev);\n \t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tmsg.fd_num = 0;\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \tcase VHOST_USER_SET_FEATURES:\n@@ -1683,6 +1684,7 @@ vhost_user_msg_handler(int vid, int fd)\n \n \t\t/* it needs a reply */\n \t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tmsg.fd_num = 0;\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \tcase VHOST_USER_SET_LOG_FD:\n@@ -1722,6 +1724,7 @@ vhost_user_msg_handler(int vid, int fd)\n \tcase VHOST_USER_GET_QUEUE_NUM:\n \t\tmsg.payload.u64 = (uint64_t)vhost_user_get_queue_num(dev);\n \t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tmsg.fd_num = 0;\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \n@@ -1769,6 +1772,7 @@ vhost_user_msg_handler(int vid, int fd)\n \tif (msg.flags & VHOST_USER_NEED_REPLY) {\n \t\tmsg.payload.u64 = !!ret;\n \t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tmsg.fd_num = 0;\n \t\tsend_vhost_reply(fd, &msg);\n \t}\n \n@@ -1848,7 +1852,7 @@ vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm)\n \t\t},\n \t};\n \n-\tret = send_vhost_message(dev->slave_req_fd, &msg, NULL, 0);\n+\tret = send_vhost_message(dev->slave_req_fd, &msg);\n \tif (ret < 0) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\t\"Failed to send IOTLB miss message (%d)\\n\",\n@@ -1864,8 +1868,6 @@ static int vhost_user_slave_set_vring_host_notifier(struct virtio_net *dev,\n \t\t\t\t\t\t uint64_t offset,\n \t\t\t\t\t\t uint64_t size)\n {\n-\tint *fdp = NULL;\n-\tsize_t fd_num = 0;\n \tint ret;\n \tstruct VhostUserMsg msg = {\n \t\t.request.slave = VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG,\n@@ -1881,11 +1883,11 @@ static int vhost_user_slave_set_vring_host_notifier(struct virtio_net *dev,\n \tif (fd < 0)\n \t\tmsg.payload.area.u64 |= VHOST_USER_VRING_NOFD_MASK;\n \telse {\n-\t\tfdp = &fd;\n-\t\tfd_num = 1;\n+\t\tmsg.fds[0] = fd;\n+\t\tmsg.fd_num = 1;\n \t}\n \n-\tret = send_vhost_slave_message(dev, &msg, fdp, fd_num);\n+\tret = send_vhost_slave_message(dev, &msg);\n \tif (ret < 0) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\"Failed to set host notifier (%d)\\n\", ret);\n", "prefixes": [ "RFC", "03/10" ] }{ "id": 43825, "url": "