Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/4380/?format=api
{ "id": 4380, "url": "http://patches.dpdk.org/api/patches/4380/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1429544496-22532-3-git-send-email-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1429544496-22532-3-git-send-email-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1429544496-22532-3-git-send-email-olivier.matz@6wind.com", "date": "2015-04-20T15:41:26", "name": "[dpdk-dev,v4,02/12] examples: always initialize mbuf_pool private area", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5a68ba1817a3f33444ad732ce52aad8f90227439", "submitter": { "id": 8, "url": "http://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1429544496-22532-3-git-send-email-olivier.matz@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/4380/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/4380/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8ED33C314;\n\tMon, 20 Apr 2015 17:41:52 +0200 (CEST)", "from mail-wi0-f170.google.com (mail-wi0-f170.google.com\n\t[209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 62E3F5FEB\n\tfor <dev@dpdk.org>; Mon, 20 Apr 2015 17:41:49 +0200 (CEST)", "by widdi4 with SMTP id di4so104577267wid.0\n\tfor <dev@dpdk.org>; Mon, 20 Apr 2015 08:41:49 -0700 (PDT)", "from glumotte.dev.6wind.com (6wind.net2.nerim.net.\n\t[213.41.180.237]) by mx.google.com with ESMTPSA id\n\tfm8sm11258951wib.9.2015.04.20.08.41.48\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 20 Apr 2015 08:41:48 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=evv3ZJHE3ft3pqBtNos9SiyPhWbE+uvFuvtraqgskqE=;\n\tb=eVZ1Ms8HW+fEgLwfWvTWoqnKDkrH9/wMo7dWPHFKIUYjQjY0LZBUp9gbpVzKjHTYCb\n\tnFIBt0VI94cpoZkeXVVwKJD7xUPwQlNkbwFtFNJUJWlaJmuKTu6Z04B01y1+gDNfaD1Y\n\tshnf5YTN79BzX4sMb49KXJt+muUMToUjNk0OY2diB64isrWP/WJqe3POz6nb1snXYR+h\n\t6mBoHZJQPGxggWI66O11dcDaDKGxSIbdjTQHL92EZIjRxeMcnXza2RZVsvsE7n39sBug\n\tNp686tlOS6C3ptuhzPWTxCNDL2q1mr3ebZKFPBj8ZcCOYUvH40pGHOEaPuR6vB/HNYI6\n\tID3Q==", "X-Gm-Message-State": "ALoCoQnBJYPnpVZP8F6iRaVgZmT7lTK7FYSX4eHmXmOqth3ZWd2x1MxPev4oBMLpg4svW38lm00u", "X-Received": "by 10.180.74.37 with SMTP id q5mr26520916wiv.59.1429544509229;\n\tMon, 20 Apr 2015 08:41:49 -0700 (PDT)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 20 Apr 2015 17:41:26 +0200", "Message-Id": "<1429544496-22532-3-git-send-email-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1429544496-22532-1-git-send-email-olivier.matz@6wind.com>", "References": "<1427829784-12323-2-git-send-email-zer0@droids-corp.org>\n\t<1429544496-22532-1-git-send-email-olivier.matz@6wind.com>", "Subject": "[dpdk-dev] [PATCH v4 02/12] examples: always initialize mbuf_pool\n\tprivate area", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The mbuf pool private area must always be populated in a mbuf pool.\nThe applications or drivers may expect that for a mbuf pool, the mbuf\npool private area (mbuf_data_room_size and mbuf_priv_size) are\nproperly filled.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n examples/ip_fragmentation/main.c | 4 ++--\n examples/ip_pipeline/init.c | 8 ++++++--\n examples/ipv4_multicast/main.c | 6 ++++--\n 3 files changed, 12 insertions(+), 6 deletions(-)", "diff": "diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c\nindex 93ea2a1..cf63718 100644\n--- a/examples/ip_fragmentation/main.c\n+++ b/examples/ip_fragmentation/main.c\n@@ -764,8 +764,8 @@ init_mem(void)\n \n \t\t\tmp = rte_mempool_create(buf, NB_MBUF,\n \t\t\t\t\t\t\t sizeof(struct rte_mbuf), 32,\n-\t\t\t\t\t\t\t 0,\n-\t\t\t\t\t\t\t NULL, NULL,\n+\t\t\t\t\t\t\t sizeof(struct rte_pktmbuf_pool_private),\n+\t\t\t\t\t\t\t rte_pktmbuf_pool_init, NULL,\n \t\t\t\t\t\t\t rte_pktmbuf_init, NULL,\n \t\t\t\t\t\t\t socket, 0);\n \t\t\tif (mp == NULL) {\ndiff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c\nindex 96aee2b..61d71c3 100644\n--- a/examples/ip_pipeline/init.c\n+++ b/examples/ip_pipeline/init.c\n@@ -363,6 +363,8 @@ app_get_ring_resp(uint32_t core_id)\n static void\n app_init_mbuf_pools(void)\n {\n+\tstruct rte_pktmbuf_pool_private indirect_mbp_priv;\n+\n \t/* Init the buffer pool */\n \tRTE_LOG(INFO, USER1, \"Creating the mbuf pool ...\\n\");\n \tapp.pool = rte_mempool_create(\n@@ -380,13 +382,15 @@ app_init_mbuf_pools(void)\n \n \t/* Init the indirect buffer pool */\n \tRTE_LOG(INFO, USER1, \"Creating the indirect mbuf pool ...\\n\");\n+\tindirect_mbp_priv.mbuf_data_room_size = 0;\n+\tindirect_mbp_priv.mbuf_priv_size = sizeof(struct app_pkt_metadata);\n \tapp.indirect_pool = rte_mempool_create(\n \t\t\"indirect mempool\",\n \t\tapp.pool_size,\n \t\tsizeof(struct rte_mbuf) + sizeof(struct app_pkt_metadata),\n \t\tapp.pool_cache_size,\n-\t\t0,\n-\t\tNULL, NULL,\n+\t\tsizeof(struct rte_pktmbuf_pool_private),\n+\t\trte_pktmbuf_pool_init, &indirect_mbp_priv,\n \t\trte_pktmbuf_init, NULL,\n \t\trte_socket_id(),\n \t\t0);\ndiff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c\nindex eed5611..19832d8 100644\n--- a/examples/ipv4_multicast/main.c\n+++ b/examples/ipv4_multicast/main.c\n@@ -699,14 +699,16 @@ main(int argc, char **argv)\n \t\trte_exit(EXIT_FAILURE, \"Cannot init packet mbuf pool\\n\");\n \n \theader_pool = rte_mempool_create(\"header_pool\", NB_HDR_MBUF,\n-\t HDR_MBUF_SIZE, 32, 0, NULL, NULL, rte_pktmbuf_init, NULL,\n+\t HDR_MBUF_SIZE, 32, sizeof(struct rte_pktmbuf_pool_private),\n+\t rte_pktmbuf_pool_init, NULL, rte_pktmbuf_init, NULL,\n \t rte_socket_id(), 0);\n \n \tif (header_pool == NULL)\n \t\trte_exit(EXIT_FAILURE, \"Cannot init header mbuf pool\\n\");\n \n \tclone_pool = rte_mempool_create(\"clone_pool\", NB_CLONE_MBUF,\n-\t CLONE_MBUF_SIZE, 32, 0, NULL, NULL, rte_pktmbuf_init, NULL,\n+\t CLONE_MBUF_SIZE, 32, sizeof(struct rte_pktmbuf_pool_private),\n+\t rte_pktmbuf_pool_init, NULL, rte_pktmbuf_init, NULL,\n \t rte_socket_id(), 0);\n \n \tif (clone_pool == NULL)\n", "prefixes": [ "dpdk-dev", "v4", "02/12" ] }