Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43777/?format=api
{ "id": 43777, "url": "http://patches.dpdk.org/api/patches/43777/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1534503091-31910-2-git-send-email-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1534503091-31910-2-git-send-email-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1534503091-31910-2-git-send-email-jia.guo@intel.com", "date": "2018-08-17T10:51:27", "name": "[v1,1/5] eal: add a new req notifier to eal interrupt", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "123c3b55e6596cd8a962574845efc57fd23fdd09", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1534503091-31910-2-git-send-email-jia.guo@intel.com/mbox/", "series": [ { "id": 1010, "url": "http://patches.dpdk.org/api/series/1010/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1010", "date": "2018-08-17T10:51:26", "name": "Enable hotplug in vfio", "version": 1, "mbox": "http://patches.dpdk.org/series/1010/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43777/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/43777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AFDA02BBD;\n\tFri, 17 Aug 2018 12:54:18 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 2E99E2674\n\tfor <dev@dpdk.org>; Fri, 17 Aug 2018 12:54:17 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Aug 2018 03:54:16 -0700", "from jeffguo-z170x-ud5.sh.intel.com (HELO localhost.localdomain)\n\t([10.67.104.10])\n\tby FMSMGA003.fm.intel.com with ESMTP; 17 Aug 2018 03:54:14 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,250,1531810800\"; d=\"scan'208\";a=\"73536782\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tgaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,\n\tmotih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com,\n\tbernard.iremonger@intel.com, arybchenko@solarflare.com", "Cc": "jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\tjia.guo@intel.com, helin.zhang@intel.com", "Date": "Fri, 17 Aug 2018 18:51:27 +0800", "Message-Id": "<1534503091-31910-2-git-send-email-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1534503091-31910-1-git-send-email-jia.guo@intel.com>", "References": "<1534503091-31910-1-git-send-email-jia.guo@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 1/5] eal: add a new req notifier to eal\n\tinterrupt", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add a new req notifier in eal interrupt for enable vfio hotplug.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\n lib/librte_eal/common/include/rte_eal_interrupts.h | 1 +\n lib/librte_eal/linuxapp/eal/eal_interrupts.c | 71 ++++++++++++++++++++++\n 2 files changed, 72 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/include/rte_eal_interrupts.h b/lib/librte_eal/common/include/rte_eal_interrupts.h\nindex 6eb4932..2c47738 100644\n--- a/lib/librte_eal/common/include/rte_eal_interrupts.h\n+++ b/lib/librte_eal/common/include/rte_eal_interrupts.h\n@@ -35,6 +35,7 @@ enum rte_intr_handle_type {\n \tRTE_INTR_HANDLE_EXT, /**< external handler */\n \tRTE_INTR_HANDLE_VDEV, /**< virtual device */\n \tRTE_INTR_HANDLE_DEV_EVENT, /**< device event handle */\n+\tRTE_INTR_HANDLE_VFIO_REQ, /**< vfio device handle (req) */\n \tRTE_INTR_HANDLE_MAX /**< count of elements */\n };\n \ndiff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\nindex 4076c6d..7f611b3 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n@@ -308,6 +308,64 @@ vfio_disable_msix(const struct rte_intr_handle *intr_handle) {\n \n \treturn ret;\n }\n+\n+/* enable req notifier */\n+static int\n+vfio_enable_req(const struct rte_intr_handle *intr_handle)\n+{\n+\tint len, ret;\n+\tchar irq_set_buf[IRQ_SET_BUF_LEN];\n+\tstruct vfio_irq_set *irq_set;\n+\tint *fd_ptr;\n+\n+\tlen = sizeof(irq_set_buf);\n+\n+\tirq_set = (struct vfio_irq_set *) irq_set_buf;\n+\tirq_set->argsz = len;\n+\tirq_set->count = 1;\n+\tirq_set->flags = VFIO_IRQ_SET_DATA_EVENTFD |\n+\t\t\t VFIO_IRQ_SET_ACTION_TRIGGER;\n+\tirq_set->index = VFIO_PCI_REQ_IRQ_INDEX;\n+\tirq_set->start = 0;\n+\tfd_ptr = (int *) &irq_set->data;\n+\t*fd_ptr = intr_handle->fd;\n+\n+\tret = ioctl(intr_handle->vfio_dev_fd, VFIO_DEVICE_SET_IRQS, irq_set);\n+\n+\tif (ret) {\n+\t\tRTE_LOG(ERR, EAL, \"Error enabling req interrupts for fd %d\\n\",\n+\t\t\t\t\t\tintr_handle->fd);\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+/* disable req notifier */\n+static int\n+vfio_disable_req(const struct rte_intr_handle *intr_handle)\n+{\n+\tstruct vfio_irq_set *irq_set;\n+\tchar irq_set_buf[IRQ_SET_BUF_LEN];\n+\tint len, ret;\n+\n+\tlen = sizeof(struct vfio_irq_set);\n+\n+\tirq_set = (struct vfio_irq_set *) irq_set_buf;\n+\tirq_set->argsz = len;\n+\tirq_set->count = 0;\n+\tirq_set->flags = VFIO_IRQ_SET_DATA_NONE | VFIO_IRQ_SET_ACTION_TRIGGER;\n+\tirq_set->index = VFIO_PCI_REQ_IRQ_INDEX;\n+\tirq_set->start = 0;\n+\n+\tret = ioctl(intr_handle->vfio_dev_fd, VFIO_DEVICE_SET_IRQS, irq_set);\n+\n+\tif (ret)\n+\t\tRTE_LOG(ERR, EAL, \"Error disabling req interrupts for fd %d\\n\",\n+\t\t\tintr_handle->fd);\n+\n+\treturn ret;\n+}\n #endif\n \n static int\n@@ -556,6 +614,10 @@ rte_intr_enable(const struct rte_intr_handle *intr_handle)\n \t\tif (vfio_enable_intx(intr_handle))\n \t\t\treturn -1;\n \t\tbreak;\n+\tcase RTE_INTR_HANDLE_VFIO_REQ:\n+\t\tif (vfio_enable_req(intr_handle))\n+\t\t\treturn -1;\n+\t\tbreak;\n #endif\n \t/* not used at this moment */\n \tcase RTE_INTR_HANDLE_DEV_EVENT:\n@@ -606,6 +668,11 @@ rte_intr_disable(const struct rte_intr_handle *intr_handle)\n \t\tif (vfio_disable_intx(intr_handle))\n \t\t\treturn -1;\n \t\tbreak;\n+\tcase RTE_INTR_HANDLE_VFIO_REQ:\n+\t\tif (vfio_disable_req(intr_handle))\n+\t\t\treturn -1;\n+\t\tbreak;\n+\n #endif\n \t/* not used at this moment */\n \tcase RTE_INTR_HANDLE_DEV_EVENT:\n@@ -682,6 +749,10 @@ eal_intr_process_interrupts(struct epoll_event *events, int nfds)\n \t\t\tbytes_read = 0;\n \t\t\tcall = true;\n \t\t\tbreak;\n+\t\tcase RTE_INTR_HANDLE_VFIO_REQ:\n+\t\t\tbytes_read = 0;\n+\t\t\tcall = true;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\tbytes_read = 1;\n \t\t\tbreak;\n", "prefixes": [ "v1", "1/5" ] }