Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43774/?format=api
{ "id": 43774, "url": "http://patches.dpdk.org/api/patches/43774/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1534503016-31805-3-git-send-email-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1534503016-31805-3-git-send-email-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1534503016-31805-3-git-send-email-jia.guo@intel.com", "date": "2018-08-17T10:50:14", "name": "[v6,2/4] net/ixgbe: install ethdev hotplug handler in ixgbe", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d20895d09f239836830caf368096ab273fcac3d6", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1534503016-31805-3-git-send-email-jia.guo@intel.com/mbox/", "series": [ { "id": 1009, "url": "http://patches.dpdk.org/api/series/1009/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1009", "date": "2018-08-17T10:50:12", "name": "Install eal event handler in i40e/ixgbe", "version": 6, "mbox": "http://patches.dpdk.org/series/1009/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43774/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/43774/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AA7A74C72;\n\tFri, 17 Aug 2018 12:53:31 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 6977E2A62\n\tfor <dev@dpdk.org>; Fri, 17 Aug 2018 12:53:22 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Aug 2018 03:53:20 -0700", "from jeffguo-z170x-ud5.sh.intel.com (HELO localhost.localdomain)\n\t([10.67.104.10])\n\tby orsmga003.jf.intel.com with ESMTP; 17 Aug 2018 03:53:04 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,250,1531810800\"; d=\"scan'208\";a=\"76129679\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tgaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,\n\tmotih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com,\n\tbernard.iremonger@intel.com, arybchenko@solarflare.com", "Cc": "jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\tjia.guo@intel.com, helin.zhang@intel.com", "Date": "Fri, 17 Aug 2018 18:50:14 +0800", "Message-Id": "<1534503016-31805-3-git-send-email-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1534503016-31805-1-git-send-email-jia.guo@intel.com>", "References": "<1530787185-5915-1-git-send-email-jia.guo@intel.com>\n\t<1534503016-31805-1-git-send-email-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 2/4] net/ixgbe: install ethdev hotplug handler\n\tin ixgbe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch aims to enable hotplug detection in ixgbe PMD.\n\nFirst, it sets the “RTE_PCI_DRV_INTR_RMV” flag in drv_flags to\nannounce the ability of hotplug processing. Then, it calls the\n“rte_eth_dev_event_handler_install” API to install the device\nevent handler for ethdev. When the eal device event be detected,\nit calls the ethdev callback to process it. If the event is the\nhotplug-out event, it will trigger the “RTE_ETH_EVENT_INTR_RMV”\nevent into the ethdev callback to allow the application's callback\nto process hotplug for this ethdev.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\nAcked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\nv6->v5:\nrefine commit log\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 26b1927..37404cf 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1678,6 +1678,9 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev)\n \trte_intr_enable(intr_handle);\n \tixgbevf_intr_enable(eth_dev);\n \n+\t/* install the dev event handler for ethdev. */\n+\trte_eth_dev_event_handler_install(eth_dev);\n+\n \tPMD_INIT_LOG(DEBUG, \"port %d vendorID=0x%x deviceID=0x%x mac.type=%s\",\n \t\t eth_dev->data->port_id, pci_dev->id.vendor_id,\n \t\t pci_dev->id.device_id, \"ixgbe_mac_82599_vf\");\n@@ -1718,6 +1721,9 @@ eth_ixgbevf_dev_uninit(struct rte_eth_dev *eth_dev)\n \trte_intr_callback_unregister(intr_handle,\n \t\t\t\t ixgbevf_dev_interrupt_handler, eth_dev);\n \n+\t/* uninstall the dev event handler for ethdev. */\n+\trte_eth_dev_event_handler_uninstall(eth_dev);\n+\n \treturn 0;\n }\n \n@@ -1801,7 +1807,7 @@ static int eth_ixgbe_pci_remove(struct rte_pci_device *pci_dev)\n static struct rte_pci_driver rte_ixgbe_pmd = {\n \t.id_table = pci_id_ixgbe_map,\n \t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |\n-\t\t RTE_PCI_DRV_IOVA_AS_VA,\n+\t\t RTE_PCI_DRV_IOVA_AS_VA | RTE_PCI_DRV_INTR_RMV,\n \t.probe = eth_ixgbe_pci_probe,\n \t.remove = eth_ixgbe_pci_remove,\n };\n", "prefixes": [ "v6", "2/4" ] }