Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43770/?format=api
{ "id": 43770, "url": "http://patches.dpdk.org/api/patches/43770/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1534502916-31636-10-git-send-email-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1534502916-31636-10-git-send-email-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1534502916-31636-10-git-send-email-jia.guo@intel.com", "date": "2018-08-17T10:48:36", "name": "[v10,8/8] testpmd: use hotplug failure handle mechanism", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "516ede74f6f12c2c593d2cee993fe1c0534687c8", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1534502916-31636-10-git-send-email-jia.guo@intel.com/mbox/", "series": [ { "id": 1007, "url": "http://patches.dpdk.org/api/series/1007/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1007", "date": "2018-08-17T10:48:27", "name": "hotplug failure handle mechanism", "version": 10, "mbox": "http://patches.dpdk.org/series/1007/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43770/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43770/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9E66058C3;\n\tFri, 17 Aug 2018 12:51:50 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 9A8584C72\n\tfor <dev@dpdk.org>; Fri, 17 Aug 2018 12:51:46 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Aug 2018 03:51:46 -0700", "from jeffguo-z170x-ud5.sh.intel.com (HELO localhost.localdomain)\n\t([10.67.104.10])\n\tby fmsmga007.fm.intel.com with ESMTP; 17 Aug 2018 03:51:43 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,250,1531810800\"; d=\"scan'208\";a=\"63131886\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tgaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,\n\tmotih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com,\n\tbernard.iremonger@intel.com, \n\tarybchenko@solarflare.com, wenzhuo.lu@intel.com", "Cc": "jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\tjia.guo@intel.com, helin.zhang@intel.com", "Date": "Fri, 17 Aug 2018 18:48:36 +0800", "Message-Id": "<1534502916-31636-10-git-send-email-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1534502916-31636-1-git-send-email-jia.guo@intel.com>", "References": "<1498711073-42917-1-git-send-email-jia.guo@intel.com>\n\t<1534502916-31636-1-git-send-email-jia.guo@intel.com>", "Subject": "[dpdk-dev] [PATCH v10 8/8] testpmd: use hotplug failure handle\n\tmechanism", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch use testpmd for example to show how to use failure handle\nmechanism for hotplug in app.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\nv10->v9:\nuse new APIs to manage hotplug handling.\n---\n app/test-pmd/testpmd.c | 27 ++++++++++++++++++++++-----\n 1 file changed, 22 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex ee48db2..12fc497 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2098,14 +2098,22 @@ pmd_test_exit(void)\n \n \tif (hot_plug) {\n \t\tret = rte_dev_event_monitor_stop();\n-\t\tif (ret)\n+\t\tif (ret) {\n \t\t\tRTE_LOG(ERR, EAL,\n \t\t\t\t\"fail to stop device event monitor.\");\n+\t\t\treturn;\n+\t\t}\n \n \t\tret = eth_dev_event_callback_unregister();\n \t\tif (ret)\n+\t\t\treturn;\n+\n+\t\tret = rte_dev_hotplug_handle_disable();\n+\t\tif (ret) {\n \t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"fail to unregister all event callbacks.\");\n+\t\t\t\t\"fail to disable hotplug handling.\");\n+\t\t\treturn;\n+\t\t}\n \t}\n \n \tprintf(\"\\nBye...\\n\");\n@@ -2784,14 +2792,23 @@ main(int argc, char** argv)\n \tinit_config();\n \n \tif (hot_plug) {\n-\t\t/* enable hot plug monitoring */\n+\t\tret = rte_dev_hotplug_handle_enable();\n+\t\tif (ret) {\n+\t\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\t\"fail to enable hotplug handling.\");\n+\t\t\treturn -1;\n+\t\t}\n+\n \t\tret = rte_dev_event_monitor_start();\n \t\tif (ret) {\n-\t\t\trte_errno = EINVAL;\n+\t\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\t\"fail to start device event monitoring.\");\n \t\t\treturn -1;\n \t\t}\n-\t\teth_dev_event_callback_register();\n \n+\t\tret = eth_dev_event_callback_register();\n+\t\tif (ret)\n+\t\t\treturn -1;\n \t}\n \n \tif (start_port(RTE_PORT_ALL) != 0)\n", "prefixes": [ "v10", "8/8" ] }