Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 43763,
    "url": "http://patches.dpdk.org/api/patches/43763/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1534502916-31636-3-git-send-email-jia.guo@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1534502916-31636-3-git-send-email-jia.guo@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1534502916-31636-3-git-send-email-jia.guo@intel.com",
    "date": "2018-08-17T10:48:29",
    "name": "[v10,2/8] bus/pci: implement memory failure handler ops",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "4ed5fb9020d79fb982e7d77c8dadcbf370ab239b",
    "submitter": {
        "id": 507,
        "url": "http://patches.dpdk.org/api/people/507/?format=api",
        "name": "Guo, Jia",
        "email": "jia.guo@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1534502916-31636-3-git-send-email-jia.guo@intel.com/mbox/",
    "series": [
        {
            "id": 1007,
            "url": "http://patches.dpdk.org/api/series/1007/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1007",
            "date": "2018-08-17T10:48:27",
            "name": "hotplug failure handle mechanism",
            "version": 10,
            "mbox": "http://patches.dpdk.org/series/1007/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/43763/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/43763/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9C572324D;\n\tFri, 17 Aug 2018 12:51:27 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 2E0E62C6A\n\tfor <dev@dpdk.org>; Fri, 17 Aug 2018 12:51:26 +0200 (CEST)",
            "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Aug 2018 03:51:25 -0700",
            "from jeffguo-z170x-ud5.sh.intel.com (HELO localhost.localdomain)\n\t([10.67.104.10])\n\tby fmsmga007.fm.intel.com with ESMTP; 17 Aug 2018 03:51:23 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.53,250,1531810800\"; d=\"scan'208\";a=\"63131830\"",
        "From": "Jeff Guo <jia.guo@intel.com>",
        "To": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tgaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,\n\tmotih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com,\n\tbernard.iremonger@intel.com, \n\tarybchenko@solarflare.com, wenzhuo.lu@intel.com",
        "Cc": "jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\tjia.guo@intel.com, helin.zhang@intel.com",
        "Date": "Fri, 17 Aug 2018 18:48:29 +0800",
        "Message-Id": "<1534502916-31636-3-git-send-email-jia.guo@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1534502916-31636-1-git-send-email-jia.guo@intel.com>",
        "References": "<1498711073-42917-1-git-send-email-jia.guo@intel.com>\n\t<1534502916-31636-1-git-send-email-jia.guo@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v10 2/8] bus/pci: implement memory failure\n\thandler ops",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch implements the ops to handle memory failures on the PCI bus. It\navoids MMIO read/write errors by creating a new dummy memory to remap the\nmemory where the failure is.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\nAcked-by: Shaopeng He <shaopeng.he@intel.com>\n---\nv10->v9:\nchange pci bus ops name\n---\n drivers/bus/pci/pci_common.c     | 28 ++++++++++++++++++++++++++++\n drivers/bus/pci/pci_common_uio.c | 33 +++++++++++++++++++++++++++++++++\n drivers/bus/pci/private.h        | 12 ++++++++++++\n 3 files changed, 73 insertions(+)",
    "diff": "diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 7736b3f..759ccc3 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -406,6 +406,33 @@ pci_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,\n }\n \n static int\n+pci_memory_failure_handler(struct rte_device *dev)\n+{\n+\tstruct rte_pci_device *pdev = NULL;\n+\tint ret = 0;\n+\n+\tpdev = RTE_DEV_TO_PCI(dev);\n+\tif (!pdev)\n+\t\treturn -1;\n+\n+\tswitch (pdev->kdrv) {\n+\tcase RTE_KDRV_IGB_UIO:\n+\tcase RTE_KDRV_UIO_GENERIC:\n+\tcase RTE_KDRV_NIC_UIO:\n+\t\t/* mmio resource is invalid, remap it to be safe. */\n+\t\tret = pci_uio_remap_resource(pdev);\n+\t\tbreak;\n+\tdefault:\n+\t\tRTE_LOG(DEBUG, EAL,\n+\t\t\t\"Not managed by a supported kernel driver, skipped\\n\");\n+\t\tret = -1;\n+\t\tbreak;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static int\n pci_plug(struct rte_device *dev)\n {\n \treturn pci_probe_all_drivers(RTE_DEV_TO_PCI(dev));\n@@ -435,6 +462,7 @@ struct rte_pci_bus rte_pci_bus = {\n \t\t.unplug = pci_unplug,\n \t\t.parse = pci_parse,\n \t\t.get_iommu_class = rte_pci_get_iommu_class,\n+\t\t.memory_failure_handler = pci_memory_failure_handler,\n \t},\n \t.device_list = TAILQ_HEAD_INITIALIZER(rte_pci_bus.device_list),\n \t.driver_list = TAILQ_HEAD_INITIALIZER(rte_pci_bus.driver_list),\ndiff --git a/drivers/bus/pci/pci_common_uio.c b/drivers/bus/pci/pci_common_uio.c\nindex 54bc20b..7ea73db 100644\n--- a/drivers/bus/pci/pci_common_uio.c\n+++ b/drivers/bus/pci/pci_common_uio.c\n@@ -146,6 +146,39 @@ pci_uio_unmap(struct mapped_pci_resource *uio_res)\n \t}\n }\n \n+/* remap the PCI resource of a PCI device in anonymous virtual memory */\n+int\n+pci_uio_remap_resource(struct rte_pci_device *dev)\n+{\n+\tint i;\n+\tvoid *map_address;\n+\n+\tif (dev == NULL)\n+\t\treturn -1;\n+\n+\t/* Remap all BARs */\n+\tfor (i = 0; i != PCI_MAX_RESOURCE; i++) {\n+\t\t/* skip empty BAR */\n+\t\tif (dev->mem_resource[i].phys_addr == 0)\n+\t\t\tcontinue;\n+\t\tmap_address = mmap(dev->mem_resource[i].addr,\n+\t\t\t\t(size_t)dev->mem_resource[i].len,\n+\t\t\t\tPROT_READ | PROT_WRITE,\n+\t\t\t\tMAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0);\n+\t\tif (map_address == MAP_FAILED) {\n+\t\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\t\"Cannot remap resource for device %s\\n\",\n+\t\t\t\tdev->name);\n+\t\t\treturn -1;\n+\t\t}\n+\t\tRTE_LOG(INFO, EAL,\n+\t\t\t\"Successful remap resource for device %s\\n\",\n+\t\t\tdev->name);\n+\t}\n+\n+\treturn 0;\n+}\n+\n static struct mapped_pci_resource *\n pci_uio_find_resource(struct rte_pci_device *dev)\n {\ndiff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h\nindex 8ddd03e..6b312e5 100644\n--- a/drivers/bus/pci/private.h\n+++ b/drivers/bus/pci/private.h\n@@ -123,6 +123,18 @@ void pci_uio_free_resource(struct rte_pci_device *dev,\n \t\tstruct mapped_pci_resource *uio_res);\n \n /**\n+ * Remap the PCI resource of a PCI device in anonymous virtual memory.\n+ *\n+ * @param dev\n+ *   Point to the struct rte pci device.\n+ * @return\n+ *   - On success, zero.\n+ *   - On failure, a negative value.\n+ */\n+int\n+pci_uio_remap_resource(struct rte_pci_device *dev);\n+\n+/**\n  * Map device memory to uio resource\n  *\n  * This function is private to EAL.\n",
    "prefixes": [
        "v10",
        "2/8"
    ]
}