Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43754/?format=api
{ "id": 43754, "url": "http://patches.dpdk.org/api/patches/43754/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180816224409.5719-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180816224409.5719-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180816224409.5719-2-stephen@networkplumber.org", "date": "2018-08-16T22:44:08", "name": "[1/2] ethdev: silence error message on rte_eth_dev_owner_unset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a13cb8f4b6938852f5e5424e18d4af95d41e2913", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180816224409.5719-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 1004, "url": "http://patches.dpdk.org/api/series/1004/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1004", "date": "2018-08-16T22:44:07", "name": "ethdev: minor ownership changes", "version": 1, "mbox": "http://patches.dpdk.org/series/1004/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43754/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43754/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8F29A4C99;\n\tFri, 17 Aug 2018 00:44:16 +0200 (CEST)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id ABAC64C93\n\tfor <dev@dpdk.org>; Fri, 17 Aug 2018 00:44:13 +0200 (CEST)", "by mail-pf1-f195.google.com with SMTP id d4-v6so2657821pfn.0\n\tfor <dev@dpdk.org>; Thu, 16 Aug 2018 15:44:13 -0700 (PDT)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tn9-v6sm426666pfg.21.2018.08.16.15.44.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 16 Aug 2018 15:44:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=wbGdWXxM5XlfSiU5+Zui7E7Ksv+9eV/tHdLHFlMf680=;\n\tb=mkOz+4zHrSdpAy9lzGjiMWxBGAmZ6pqBFslYfTDLD13da45zbKCvBJaU8t1iSpzf3n\n\tnHpUutTheHlzZONAYyB4RzemqWVC5rnCJxj84ZcS0AkNxJTfpAvDlvxO2ouYhI376PXV\n\teGGqniy/UHERZrRKb3JZHwlmVaNCu7diI3iS5hI3SSy8bMl5CzYy7ZQzZehIEuoUKBDP\n\tQWIRb3eRx854kNL9TO0++UxNW0um6U+6816CKtkPEpQOyt4LnjAtFNMsDYVgWzwOte+S\n\toBgCrd8Lnkq2JixJ2DojrHRnzAA9jiB/BI4SXsx9jE5jBALuNxYlBRsmNbi5Ns6WVNMp\n\tjE+A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=wbGdWXxM5XlfSiU5+Zui7E7Ksv+9eV/tHdLHFlMf680=;\n\tb=NJnE+Vvb7GiZsvAkGxcLeuUrIxKaPnYH/ylG1mM5pAEWNrZBQjQX+JVhCpkGPZAL6v\n\thpny+IhMQg2gNo7ewEG3YJIU1oMlo/iBQqp5piXCERIRYz6QXKfP5usXCrbQm3EZZ0oC\n\tlej0zKciAe9byY6Qos4vpS65d79ObiN3vP7cmG30FBu7S7Tqkmd+6wz3VrnXsJ7hbNb+\n\tN0WjYPi5NSIK5k4gQ/bcoOe1QD8YBdwO04fxi/a0XdoKFn5Y60oQjrblFkFJYh1GHi0i\n\tnWs5/q8/GXO5n6M7ZrqZL6PQelLePHteOZ6ht6Hg9pPEaNnZE9mcGvaVJxfl4AzQee8i\n\tC7fA==", "X-Gm-Message-State": "AOUpUlHiyqV4fcUuDHwCmyijIzSFTwXWZy23L1LLGjow0unDoiSzBbZV\n\tw6CY8kCh39E4yvL9y038NEXudQ==", "X-Google-Smtp-Source": "AA+uWPxhMq8fLKkZTcfyxBzHNcxcoRo3qPItGaSw9hVknSuZlKxxe+14Z56MBhGcsNrUFBbmZZIG/A==", "X-Received": "by 2002:a62:6cc7:: with SMTP id\n\th190-v6mr34390628pfc.113.1534459452869; \n\tThu, 16 Aug 2018 15:44:12 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "matan@mellanox.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 16 Aug 2018 15:44:08 -0700", "Message-Id": "<20180816224409.5719-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20180816224409.5719-1-stephen@networkplumber.org>", "References": "<20180814001926.19630-1-stephen@networkplumber.org>\n\t<20180816224409.5719-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH 1/2] ethdev: silence error message on\n\trte_eth_dev_owner_unset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The rte_eth_dev_owner_unset function always generates a log\nmessage because the unset value for owner id is 0.\n\nFixes: 5b7ba31148a8 (\"ethdev: add port ownership\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_ethdev/rte_ethdev.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 4c320250589a..f09bf8bc8b01 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -393,11 +393,8 @@ static int\n rte_eth_is_valid_owner_id(uint64_t owner_id)\n {\n \tif (owner_id == RTE_ETH_DEV_NO_OWNER ||\n-\t rte_eth_dev_shared_data->next_owner_id <= owner_id) {\n-\t\tRTE_ETHDEV_LOG(ERR, \"Invalid owner_id=%016\"PRIx64\"\\n\",\n-\t\t\towner_id);\n+\t rte_eth_dev_shared_data->next_owner_id <= owner_id)\n \t\treturn 0;\n-\t}\n \treturn 1;\n }\n \n@@ -444,8 +441,12 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const uint64_t old_owner_id,\n \t}\n \n \tif (!rte_eth_is_valid_owner_id(new_owner->id) &&\n-\t !rte_eth_is_valid_owner_id(old_owner_id))\n+\t !rte_eth_is_valid_owner_id(old_owner_id)) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t \"Invalid owner old_id=%016\"PRIx64\" new_id=%016\"PRIx64\"\\n\",\n+\t\t\t old_owner_id, new_owner->id);\n \t\treturn -EINVAL;\n+\t}\n \n \tport_owner = &rte_eth_devices[port_id].data->owner;\n \tif (port_owner->id != old_owner_id) {\n", "prefixes": [ "1/2" ] }