Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43749/?format=api
{ "id": 43749, "url": "http://patches.dpdk.org/api/patches/43749/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180816153106.7608-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180816153106.7608-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180816153106.7608-3-stephen@networkplumber.org", "date": "2018-08-16T15:31:06", "name": "[2/2] hexdump: align output of string", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0954a74cde901458d5864d8fc7dc3b657f94cb3f", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180816153106.7608-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 1001, "url": "http://patches.dpdk.org/api/series/1001/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1001", "date": "2018-08-16T15:31:04", "name": "eal: hexcump trivial changes", "version": 1, "mbox": "http://patches.dpdk.org/series/1001/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43749/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/43749/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5E6C64C99;\n\tThu, 16 Aug 2018 17:31:17 +0200 (CEST)", "from mail-pl0-f53.google.com (mail-pl0-f53.google.com\n\t[209.85.160.53]) by dpdk.org (Postfix) with ESMTP id 94BE94C88\n\tfor <dev@dpdk.org>; Thu, 16 Aug 2018 17:31:13 +0200 (CEST)", "by mail-pl0-f53.google.com with SMTP id j8-v6so2252990pll.12\n\tfor <dev@dpdk.org>; Thu, 16 Aug 2018 08:31:13 -0700 (PDT)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tp5-v6sm30002104pfn.57.2018.08.16.08.31.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 16 Aug 2018 08:31:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=HyKyCEA9ATAGcXoMz8nXarftmoz8HvVZtolopxyL8io=;\n\tb=FGk1vWDIKevZXf4YcDSrwo0d7n5ogwil9bqP+8xVXimXwqVOJiV4Vu05Ph6xzwTxtf\n\t9yxS0ZCn+PdPkbRBGIfN+DXOjCderZaJnAnPJQvVjW9Min9zN7y3K+P6cM0PintD19xe\n\tp8meHT09OHWZGsDf83op31T1gdd9LeL5UtWMkyt781p/6rY7Q6kD/C0Cmb3HD8hfrmpi\n\tQPZM9g+FD4iow5F29SuC8VRlLYMkfRhbT37pHkEkJ0SZ16WNW1EdIJSL+/Ng4EMI8yHr\n\tDDaqCj5ygrg8YfV3By+Lmn41Ny/8Fv7C1N4OFZy7oH6RY3HgOyPr0iFLvSfQ0VhXwXSG\n\toM+A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=HyKyCEA9ATAGcXoMz8nXarftmoz8HvVZtolopxyL8io=;\n\tb=K7aHrvB6IAQhyG3ac7QLU0kDgX6ncKIdEHAk3BwkJ6VtHYhtQfcsRtAYnVAL4AUeU4\n\t868tGz0v7l3mRfshPP7HDcpvXXIK5UTMLsjjGQ9zNyZXldKdDIDmHH9EXj5rx/gA6rYw\n\tZ6TWGGVCtfOmV03MrlFJNOCZznOIBBBF74GkFP6K/evRwQEDoz44DGR89FxgMIiHaxr/\n\t29TxetK2//b2dwJ4M+RYAglyFET5X7iYHQK6g6KhwsvDIK7i7YcDAOXPuPUl6TGLu7xy\n\t/93h0TiNA1ec7v5MJI/Cek+jhSA3jlzvf1XeeM3G2d77FTmU7P81kcyH1BGx1nbkQnR+\n\tUY1Q==", "X-Gm-Message-State": "AOUpUlGhezmifsw82F8TishtbS/Lq2wBOvE1oa6qqu8r0Lk6VKKLUg/6\n\tl0KMU7OT/BB32dUa7g3gxPkcUvdzgoPqzg==", "X-Google-Smtp-Source": "AA+uWPx0QPtp5BQZOOW+qTwHlvQPkZNqy4vsF69LBSEFhdhkpyS8VmLKEDK6K67hmd881t/iR1HqEg==", "X-Received": "by 2002:a17:902:561:: with SMTP id\n\t88-v6mr29191430plf.320.1534433472334; \n\tThu, 16 Aug 2018 08:31:12 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 16 Aug 2018 08:31:06 -0700", "Message-Id": "<20180816153106.7608-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20180816153106.7608-1-stephen@networkplumber.org>", "References": "<20180816153106.7608-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH 2/2] hexdump: align output of string", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This fixes the issue where if the length of the output is not\na multiple of 16 the formatting was off.\n\nBefore:\n00000000: 45 00 00 1C 12 34 2C E0 40 06 B8 2E C0 A8 01 12 | E....4,.@.......\n00000010: C0 A8 01 37 | | | | | | | | | | | | | ...7\n\nAfter:\n00000000: 45 00 00 1C 12 34 2C E0 40 06 B8 2E C0 A8 01 12 | E....4,.@.......\n00000010: C0 A8 01 37 | ...7\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/common/eal_common_hexdump.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_hexdump.c b/lib/librte_eal/common/eal_common_hexdump.c\nindex 980cf73ac337..19c2d86c693e 100644\n--- a/lib/librte_eal/common/eal_common_hexdump.c\n+++ b/lib/librte_eal/common/eal_common_hexdump.c\n@@ -22,9 +22,16 @@ void rte_hexdump(FILE *f, const char *title, const void *buf, unsigned int len)\n \twhile (ofs < len) {\n \t\t/* format the line in the buffer */\n \t\tout = snprintf(line, LINE_LEN, \"%08X:\", ofs);\n-\t\tfor (i = 0; i < 16 && ofs + i < len; i++)\n-\t\t\tout += snprintf(line + out, LINE_LEN - out,\n+\t\tfor (i = 0; i < 16; i++) {\n+\t\t\tif (ofs + i < len)\n+\t\t\t\tsnprintf(line + out, LINE_LEN - out,\n \t\t\t\t\t \" %02X\", (data[ofs + i] & 0xff));\n+\t\t\telse\n+\t\t\t\tstrcpy(line + out, \" \");\n+\t\t\tout += 3;\n+\t\t}\n+\n+\n \t\tfor (; i <= 16; i++)\n \t\t\tout += snprintf(line + out, LINE_LEN - out, \" | \");\n \n", "prefixes": [ "2/2" ] }