Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43738/?format=api
{ "id": 43738, "url": "http://patches.dpdk.org/api/patches/43738/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180816135032.28283-3-bluca@debian.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180816135032.28283-3-bluca@debian.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180816135032.28283-3-bluca@debian.org", "date": "2018-08-16T13:50:31", "name": "[2/3] net/vmxnet3: fix vmxnet3 dev_uninit() hot-unplug", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "93980d6a95680a47b9e18e86451675785fd12721", "submitter": { "id": 823, "url": "http://patches.dpdk.org/api/people/823/?format=api", "name": "Luca Boccassi", "email": "bluca@debian.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180816135032.28283-3-bluca@debian.org/mbox/", "series": [ { "id": 999, "url": "http://patches.dpdk.org/api/series/999/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=999", "date": "2018-08-16T13:50:29", "name": "Fix hot plug/unplug of virtual devices", "version": 1, "mbox": "http://patches.dpdk.org/series/999/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43738/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43738/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4D1174CBB;\n\tThu, 16 Aug 2018 15:50:55 +0200 (CEST)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n\t[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 457AA4C8D;\n\tThu, 16 Aug 2018 15:50:53 +0200 (CEST)", "by mail-wr1-f66.google.com with SMTP id w11-v6so1663163wrc.5;\n\tThu, 16 Aug 2018 06:50:53 -0700 (PDT)", "from localhost ([2001:1be0:110d:fcfe:41aa:5bfa:6cf3:7531])\n\tby smtp.gmail.com with ESMTPSA id\n\tt19-v6sm736489wmi.42.2018.08.16.06.50.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 16 Aug 2018 06:50:51 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=7Wr9677b5iwdExfPwcV+czGu85hikIoJgd8K24KjYBU=;\n\tb=S0ERiDQPWWezUAJmPrrkpCTfxYmIdzfGP19rW/jZcRae4en+6LOT8C+6JQcFOe7Qm2\n\tioyPB2hYmduLA+H9WKDZEKS95+1o+i0CoIPVc3L609eGLqYNpcg+NDpA4V9kQ0dIWvIZ\n\tmrt4m3RQO3cl7IRql700BvETDqZqjfRpI3g/5iSJDVjZ58klIGiq7Vwp54DO5h/RhxoF\n\t2CFlxp7j9kvI8QRsdI7uD/bsChjfyAKKPpFdsQFrKzyLSjsyzDqP9jqeXWiPXwEEIIUw\n\tydddrjR5lPaUSTLP83lQjvrsYrDadq9bUVP1yGM1pI65DEZcpmVRj9dak/Zw+/eCXiZx\n\tG1Ig==", "X-Gm-Message-State": "AOUpUlGM3VlcMiipwsGfbaUrtcanlFaSVYa8iVmr3EyyyGxOwm2P7ATO\n\tMr77PZOk6oqFAXFN/YvmkIHRNGRuOGI=", "X-Google-Smtp-Source": "AA+uWPyM0F2FYYwdVxK19m2WlGE2Uh1+gBYqmuO8xgxaRHAGOSGtXpKbaAZcGReKgpRlzTBR59qDsw==", "X-Received": "by 2002:adf:ee4e:: with SMTP id\n\tw14-v6mr19637957wro.63.1534427452431; \n\tThu, 16 Aug 2018 06:50:52 -0700 (PDT)", "From": "Luca Boccassi <bluca@debian.org>", "To": "dev@dpdk.org", "Cc": "maxime.coquelin@redhat.com, tiwei.bie@intel.com, yongwang@vmware.com,\n\t3chas3@gmail.com, bruce.richardson@intel.com, jianfeng.tan@intel.com, \n\tanatoly.burakov@intel.com, Luca Boccassi <bluca@debian.org>,\n\tstable@dpdk.org, Brian Russell <brussell@brocade.com>", "Date": "Thu, 16 Aug 2018 14:50:31 +0100", "Message-Id": "<20180816135032.28283-3-bluca@debian.org>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20180816135032.28283-1-bluca@debian.org>", "References": "<20180816135032.28283-1-bluca@debian.org>", "Subject": "[dpdk-dev] [PATCH 2/3] net/vmxnet3: fix vmxnet3 dev_uninit()\n\thot-unplug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The vmxnet3 driver can't call back into dev_close(), and possibly\ndev_stop(), in dev_uninit(). When dev_uninit() is called, anything\nthat those routines would want to clean up has already been released.\nFurther, for complete cleanup, it is necessary to release any of the\nqueue resources during dev_close().\nThis allows a vmxnet3 device to be hot-unplugged without leaking\nqueues.\n\nFixes: dfaff37fc46d (\"vmxnet3: import new vmxnet3 poll mode driver implementation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Brian Russell <brussell@brocade.com>\nSigned-off-by: Luca Boccassi <bluca@debian.org>\n---\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 36 ++++++++++++++++++++--------\n 1 file changed, 26 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 2613cd1358..b5d4be5e24 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -348,16 +348,11 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)\n static int\n eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev)\n {\n-\tstruct vmxnet3_hw *hw = eth_dev->data->dev_private;\n-\n \tPMD_INIT_FUNC_TRACE();\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n-\tif (hw->adapter_stopped == 0)\n-\t\tvmxnet3_dev_close(eth_dev);\n-\n \teth_dev->dev_ops = NULL;\n \teth_dev->rx_pkt_burst = NULL;\n \teth_dev->tx_pkt_burst = NULL;\n@@ -803,7 +798,7 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)\n \tPMD_INIT_FUNC_TRACE();\n \n \tif (hw->adapter_stopped == 1) {\n-\t\tPMD_INIT_LOG(DEBUG, \"Device already closed.\");\n+\t\tPMD_INIT_LOG(DEBUG, \"Device already stopped.\");\n \t\treturn;\n \t}\n \n@@ -827,7 +822,6 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)\n \t/* reset the device */\n \tVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_RESET_DEV);\n \tPMD_INIT_LOG(DEBUG, \"Device reset.\");\n-\thw->adapter_stopped = 0;\n \n \tvmxnet3_dev_clear_queues(dev);\n \n@@ -837,6 +831,30 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)\n \tlink.link_speed = ETH_SPEED_NUM_10G;\n \tlink.link_autoneg = ETH_LINK_FIXED;\n \trte_eth_linkstatus_set(dev, &link);\n+\n+\thw->adapter_stopped = 1;\n+}\n+\n+static void\n+vmxnet3_free_queues(struct rte_eth_dev *dev)\n+{\n+\tint i;\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tvoid *rxq = dev->data->rx_queues[i];\n+\n+\t\tvmxnet3_dev_rx_queue_release(rxq);\n+\t}\n+\tdev->data->nb_rx_queues = 0;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tvoid *txq = dev->data->tx_queues[i];\n+\n+\t\tvmxnet3_dev_tx_queue_release(txq);\n+\t}\n+\tdev->data->nb_tx_queues = 0;\n }\n \n /*\n@@ -845,12 +863,10 @@ vmxnet3_dev_stop(struct rte_eth_dev *dev)\n static void\n vmxnet3_dev_close(struct rte_eth_dev *dev)\n {\n-\tstruct vmxnet3_hw *hw = dev->data->dev_private;\n-\n \tPMD_INIT_FUNC_TRACE();\n \n \tvmxnet3_dev_stop(dev);\n-\thw->adapter_stopped = 1;\n+\tvmxnet3_free_queues(dev);\n }\n \n static void\n", "prefixes": [ "2/3" ] }