Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43737/?format=api
{ "id": 43737, "url": "http://patches.dpdk.org/api/patches/43737/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180816135032.28283-2-bluca@debian.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180816135032.28283-2-bluca@debian.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180816135032.28283-2-bluca@debian.org", "date": "2018-08-16T13:50:30", "name": "[1/3] net/virtio: register/unregister intr handler on start/stop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "577851199eb29036f215fc6d5e0b7031f6844450", "submitter": { "id": 823, "url": "http://patches.dpdk.org/api/people/823/?format=api", "name": "Luca Boccassi", "email": "bluca@debian.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180816135032.28283-2-bluca@debian.org/mbox/", "series": [ { "id": 999, "url": "http://patches.dpdk.org/api/series/999/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=999", "date": "2018-08-16T13:50:29", "name": "Fix hot plug/unplug of virtual devices", "version": 1, "mbox": "http://patches.dpdk.org/series/999/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43737/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43737/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B8CFE4C87;\n\tThu, 16 Aug 2018 15:50:52 +0200 (CEST)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n\t[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 4ADE849CF;\n\tThu, 16 Aug 2018 15:50:51 +0200 (CEST)", "by mail-wr1-f66.google.com with SMTP id a108-v6so1573452wrc.13;\n\tThu, 16 Aug 2018 06:50:51 -0700 (PDT)", "from localhost ([2001:1be0:110d:fcfe:41aa:5bfa:6cf3:7531])\n\tby smtp.gmail.com with ESMTPSA id\n\tn12-v6sm17727825wrm.62.2018.08.16.06.50.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 16 Aug 2018 06:50:49 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=jdlSLGN2bUj4gZzylPUKxXMDsg7i4UbGUSUDmqgIIW4=;\n\tb=YcznK6gOuCu3JpvbupalZ25aOh36B51UubZ7PCM7PGJrsD2bBtHSYwvt2pyof+s5kj\n\tmfCNca9Nb2gu504tURc+cupvBImnzbO3gqbdXIjviMB2IdY+wUyX62WUadXIgOti0+W2\n\tpGTiQDkKJUYXM9d8OaUpHpJ+e15XdUQbEtQcE5f9OHOPa7HnBkz3sjvSgLl4j+cs2MUX\n\tV9dO9azfJSU3lEO1Zs9f9qcj9R4RXhzfCccDoQ86Oj0VbnRuKSJ5l41lDWW4t3S9CTNS\n\tP6504nw19nAJDykZ+MBN2TE6zfW6U/VHhJ+i/9AtBytfLKmvrQIgfc69QMkkHouMB8D/\n\t+lWA==", "X-Gm-Message-State": "AOUpUlF+n0tJvOiR0H8bNxPnq8pc+QNeX9F4IJWWPluJoHNqjiaViBUE\n\tVbskHBazDnAlDCINd7xb/fQLssn4J7w=", "X-Google-Smtp-Source": "AA+uWPySk69tGSagw7BDY+VUWHKR/ueSH3UKV4z8cm+zAixhwiwAdneRXTHWqTbuCgR7D14h7dcKPw==", "X-Received": "by 2002:adf:f410:: with SMTP id\n\tg16-v6mr19119619wro.256.1534427450644; \n\tThu, 16 Aug 2018 06:50:50 -0700 (PDT)", "From": "Luca Boccassi <bluca@debian.org>", "To": "dev@dpdk.org", "Cc": "maxime.coquelin@redhat.com, tiwei.bie@intel.com, yongwang@vmware.com,\n\t3chas3@gmail.com, bruce.richardson@intel.com, jianfeng.tan@intel.com, \n\tanatoly.burakov@intel.com, Luca Boccassi <bluca@debian.org>,\n\tstable@dpdk.org, Brian Russell <brussell@brocade.com>", "Date": "Thu, 16 Aug 2018 14:50:30 +0100", "Message-Id": "<20180816135032.28283-2-bluca@debian.org>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20180816135032.28283-1-bluca@debian.org>", "References": "<20180816135032.28283-1-bluca@debian.org>", "Subject": "[dpdk-dev] [PATCH 1/3] net/virtio: register/unregister intr handler\n\ton start/stop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Register and unregister the virtio interrupt handler when the device is\nstarted and stopped. This allows a virtio device to be hotplugged or\nunplugged.\n\nFixes: c1f86306a026 (\"virtio: add new driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Brian Russell <brussell@brocade.com>\nSigned-off-by: Luca Boccassi <bluca@debian.org>\n---\n drivers/net/virtio/virtio_ethdev.c | 26 +++++++++++++++-----------\n 1 file changed, 15 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 614357da74..3195443a1b 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1679,11 +1679,6 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)\n \tif (ret < 0)\n \t\tgoto out;\n \n-\t/* Setup interrupt callback */\n-\tif (eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)\n-\t\trte_intr_callback_register(eth_dev->intr_handle,\n-\t\t\tvirtio_interrupt_handler, eth_dev);\n-\n \treturn 0;\n \n out:\n@@ -1709,11 +1704,6 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n \trte_free(eth_dev->data->mac_addrs);\n \teth_dev->data->mac_addrs = NULL;\n \n-\t/* reset interrupt callback */\n-\tif (eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)\n-\t\trte_intr_callback_unregister(eth_dev->intr_handle,\n-\t\t\t\t\t\tvirtio_interrupt_handler,\n-\t\t\t\t\t\teth_dev);\n \tif (eth_dev->device)\n \t\trte_pci_unmap_device(RTE_ETH_DEV_TO_PCI(eth_dev));\n \n@@ -1972,6 +1962,12 @@ virtio_dev_start(struct rte_eth_dev *dev)\n \t dev->data->dev_conf.intr_conf.rxq) {\n \t\tvirtio_intr_disable(dev);\n \n+\t\t/* Setup interrupt callback */\n+\t\tif (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)\n+\t\t\trte_intr_callback_register(dev->intr_handle,\n+\t\t\t\t\t\t virtio_interrupt_handler,\n+\t\t\t\t\t\t dev);\n+\n \t\tif (virtio_intr_enable(dev) < 0) {\n \t\t\tPMD_DRV_LOG(ERR, \"interrupt enable failed\");\n \t\t\treturn -EIO;\n@@ -2081,9 +2077,17 @@ virtio_dev_stop(struct rte_eth_dev *dev)\n \tPMD_INIT_LOG(DEBUG, \"stop\");\n \n \trte_spinlock_lock(&hw->state_lock);\n-\tif (intr_conf->lsc || intr_conf->rxq)\n+\tif (intr_conf->lsc || intr_conf->rxq) {\n \t\tvirtio_intr_disable(dev);\n \n+\t\t/* Reset interrupt callback */\n+\t\tif (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) {\n+\t\t\trte_intr_callback_unregister(dev->intr_handle,\n+\t\t\t\t\t\t virtio_interrupt_handler,\n+\t\t\t\t\t\t dev);\n+\t\t}\n+\t}\n+\n \thw->started = 0;\n \tmemset(&link, 0, sizeof(link));\n \trte_eth_linkstatus_set(dev, &link);\n", "prefixes": [ "1/3" ] }