Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 43698,
    "url": "http://patches.dpdk.org/api/patches/43698/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180814001926.19630-1-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180814001926.19630-1-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180814001926.19630-1-stephen@networkplumber.org",
    "date": "2018-08-14T00:19:26",
    "name": "ethdev: fix rte_eth_dev_owner_unset",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "0092a9ec7b2705b6b417b2c0995b9ec2b4b76812",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180814001926.19630-1-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 975,
            "url": "http://patches.dpdk.org/api/series/975/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=975",
            "date": "2018-08-14T00:19:26",
            "name": "ethdev: fix rte_eth_dev_owner_unset",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/975/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/43698/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/43698/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1BC6C397D;\n\tTue, 14 Aug 2018 02:19:33 +0200 (CEST)",
            "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 1CCE62B83\n\tfor <dev@dpdk.org>; Tue, 14 Aug 2018 02:19:30 +0200 (CEST)",
            "by mail-pf1-f194.google.com with SMTP id b11-v6so8419256pfo.3\n\tfor <dev@dpdk.org>; Mon, 13 Aug 2018 17:19:30 -0700 (PDT)",
            "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tm15-v6sm32471650pfk.149.2018.08.13.17.19.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 13 Aug 2018 17:19:28 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=DqSQhoLw/TUj/38Yoi4cVivK7O22XXxkatHqcF/EzEo=;\n\tb=k53DBGqgWA8bGo8XjbdaB6JtnGzIzLzo1sOWRnAeOKCQ3rLTlfjrW4CtPCyUpoJGb6\n\tGYlrNqPMTAJDmYry0n7hx15NBOUWRy4FDKPSZ0h+9YwYz/UvHdyv2i/r0Ui2wc3U0Pge\n\tGPupDnj3XzEPKDtiWsipyL+hSTUfMOE2UFeOi0nVAIGtjLjljjR2O/IWdyXrnjIj7QdR\n\tnGexCl0KoCQxCjJnLqIBQyy4RDQYatRHwcB/r5quUC4CSoxyDPG0LRey6JOoLf8upgPE\n\tZNtJvXT5wa1Q3L3RU7IPLMLAhZ2sBp21Qd6M8pU7nwj7BeVSWA0rNqPEevgdU7RSQ2KU\n\tZ78A==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=DqSQhoLw/TUj/38Yoi4cVivK7O22XXxkatHqcF/EzEo=;\n\tb=AEJvvXpLzNMJbesJ2eaTyMVYBoER7Vno1n1xaR7wv429F4o5JHnnte90e+DveNq/Cb\n\t6e6vo71lPCeLB5gyxG7tCxuAQtSo2qpYRXh+B7czUDOdt2C0UtaU0O8QRN5Zvv7U4kao\n\t1QsldPq4XTRAg8kMBIS7HkTZLZN6Pv/j6yr9LHv86ocKpGF8/HgHfj4H62cf5+tiUmjc\n\tpSPERg3kVwARhyv1S2kUgb8CYryL52rgWlvU713UpDMzt16rrjvsDHQz4l6jESVBDV1X\n\t52CVhYG4upZdqygE76QHCUVRRvh/MM8dtY6E5k6CECPVgPt+6T6Luoxqm1a56s0Bhsmu\n\tQTAA==",
        "X-Gm-Message-State": "AOUpUlHF7tcZBOwHMnkgC8pC7kADpMz8tB8Ds8p1EsHeXQEBHRmHLxCX\n\tUEV+zHi4qQXLcjVXcYfitQkvKctLIwpSFQ==",
        "X-Google-Smtp-Source": "AA+uWPx105NMu1D1w0LeZJdPc3kglpaghC6jgAqqP5g3N3NR5/7/Ukbm0NofF1fr0MiuAQklGQC0gw==",
        "X-Received": "by 2002:a63:9f0a:: with SMTP id\n\tg10-v6mr18904563pge.324.1534205969712; \n\tMon, 13 Aug 2018 17:19:29 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Mon, 13 Aug 2018 17:19:26 -0700",
        "Message-Id": "<20180814001926.19630-1-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.18.0",
        "Subject": "[dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The rte_eth_dev_owner_unset function is unusable because\nit always returns -EINVAL. This is because the magic (unowned)\nvalue is flagged as not valid.\n\nMove the validation of owner into set and unset as\nseparate calls.\n\nFixes: 5b7ba31148a8 (\"ethdev: add port ownership\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_ethdev/rte_ethdev.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 4c320250589a..9398550a1189 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -443,10 +443,6 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const uint64_t old_owner_id,\n \t\treturn -ENODEV;\n \t}\n \n-\tif (!rte_eth_is_valid_owner_id(new_owner->id) &&\n-\t    !rte_eth_is_valid_owner_id(old_owner_id))\n-\t\treturn -EINVAL;\n-\n \tport_owner = &rte_eth_devices[port_id].data->owner;\n \tif (port_owner->id != old_owner_id) {\n \t\tRTE_ETHDEV_LOG(ERR,\n@@ -475,6 +471,9 @@ rte_eth_dev_owner_set(const uint16_t port_id,\n {\n \tint ret;\n \n+\tif (!rte_eth_is_valid_owner_id(owner->id))\n+\t\treturn -EINVAL;\n+\n \trte_eth_dev_shared_data_prepare();\n \n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n@@ -492,6 +491,9 @@ rte_eth_dev_owner_unset(const uint16_t port_id, const uint64_t owner_id)\n \t\t\t{.id = RTE_ETH_DEV_NO_OWNER, .name = \"\"};\n \tint ret;\n \n+\tif (!rte_eth_is_valid_owner_id(owner_id))\n+\t\treturn -EINVAL;\n+\n \trte_eth_dev_shared_data_prepare();\n \n \trte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);\n",
    "prefixes": []
}