Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 43656,
    "url": "http://patches.dpdk.org/api/patches/43656/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180809175008.5787-2-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180809175008.5787-2-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180809175008.5787-2-stephen@networkplumber.org",
    "date": "2018-08-09T17:50:05",
    "name": "[1/4] netvsc: chimney buffer size error handling",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f6f4dc874808e514b589e1aaced2d2a95690aaf2",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180809175008.5787-2-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 954,
            "url": "http://patches.dpdk.org/api/series/954/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=954",
            "date": "2018-08-09T17:50:04",
            "name": "netvsc performance enhancements",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/954/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/43656/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/43656/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E42C337B4;\n\tThu,  9 Aug 2018 19:50:22 +0200 (CEST)",
            "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id B845D2BCD\n\tfor <dev@dpdk.org>; Thu,  9 Aug 2018 19:50:19 +0200 (CEST)",
            "by mail-pf1-f194.google.com with SMTP id u24-v6so3173697pfn.13\n\tfor <dev@dpdk.org>; Thu, 09 Aug 2018 10:50:19 -0700 (PDT)",
            "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tn22-v6sm14993873pfj.68.2018.08.09.10.50.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 09 Aug 2018 10:50:17 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=l61fyM8PLyqh8SU4d7kOPxifs82/3wDwcM7mGyqQ9Sk=;\n\tb=DgF5rsnef04YjqEi3ViSG35aj4Ua9V1I/yNswZ+0Mno+qaUwW7QfA25pG7CE/MsAB+\n\tAxGXc/S7pmoifpyGeADZa4rZPCOOVHrCanMKvv5uGbdvh/9WEZnRBIMEx0NP/P5ihlBX\n\tJUSYAwlvBvTvgtG50lB7xRwUyB1eWGre2x5iRWgS4P8oXqhbDxL2aDJG7aTFk5FLJqfa\n\tnBunBPhBZmxLoLVdeesmZtcyOGPpUlxygPgWMvxYdYdbwmj0YFdgsn7BVfmeyDlMN2In\n\t2/xJb1ETCYR7xAytf7ByVCQg+CzTjK9oo8iluuQ7H0pFUvUdXaYNGR/L3GvWtDs7eJcn\n\tg3gg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=l61fyM8PLyqh8SU4d7kOPxifs82/3wDwcM7mGyqQ9Sk=;\n\tb=o4E20iLuwtmWNPp7G9VrxSpJGS3VE5+uUpjHJctAHrXOZSuaxVmigEF1tkKCA85GCn\n\tiaVbalAlYWMRNTg5o6UXM5rRtMU+obpGX2/8Mn3Ri8ito16EcmpVitMFaRCTXq42CyHm\n\tX1d7CAdg1IUGaHuBY7vIzzjhYx2K0SdssOInSNSY/xwFXhwgPWNbiasnhA2JA3lVYuju\n\tcd8+QjPvXC7jRM+asT+oF0K1x7MmhGCW0F2yw2xJOd5nSeZ7PEJriqTY93Qx5jiCkTEn\n\tBqbHe5Ry0yC1gAXhbXapmpcdAcFvABmNwIAv9Ipb2JgJ7YgFIV9qO75o/ccgtmAs3b7T\n\t18fQ==",
        "X-Gm-Message-State": "AOUpUlHM5WezTn6MgJs0Y8FlE6FMIg0iilEiJLzm2MiPOP/5/Ey/umuu\n\tdIXY0kOfECZYM9iXTRwlye83YgO5xvM=",
        "X-Google-Smtp-Source": "AA+uWPzbPXk0EmwLwZDj6VGx6sz7Ud9KvlNtObXIFBrxLfj0Fi3DrMKTyLjBdXlPdvw3lj+cyJSSVw==",
        "X-Received": "by 2002:a62:9541:: with SMTP id\n\tp62-v6mr3359110pfd.152.1533837018658; \n\tThu, 09 Aug 2018 10:50:18 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>",
        "Date": "Thu,  9 Aug 2018 10:50:05 -0700",
        "Message-Id": "<20180809175008.5787-2-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.18.0",
        "In-Reply-To": "<20180809175008.5787-1-stephen@networkplumber.org>",
        "References": "<20180809175008.5787-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH 1/4] netvsc: chimney buffer size error handling",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fix the error handling in setting up transmit buffer.\nIf setting up chimney buffer fails, then it is not connected so\nno need to send disconnect.\n\nAllow for some unused area if full area is not used.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/net/netvsc/hn_nvs.c | 13 ++++---------\n 1 file changed, 4 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers/net/netvsc/hn_nvs.c\nindex 77d3b839fd45..a458bb720f82 100644\n--- a/drivers/net/netvsc/hn_nvs.c\n+++ b/drivers/net/netvsc/hn_nvs.c\n@@ -279,14 +279,13 @@ hn_nvs_conn_chim(struct hn_data *hv)\n \t\t\t       NVS_TYPE_CHIM_CONNRESP);\n \tif (error) {\n \t\tPMD_DRV_LOG(ERR, \"exec nvs chim conn failed\");\n-\t\tgoto cleanup;\n+\t\treturn error;\n \t}\n \n \tif (resp.status != NVS_STATUS_OK) {\n \t\tPMD_DRV_LOG(ERR, \"nvs chim conn failed: %x\",\n \t\t\t    resp.status);\n-\t\terror = -EIO;\n-\t\tgoto cleanup;\n+\t\treturn -EIO;\n \t}\n \n \tsectsz = resp.sectsz;\n@@ -295,7 +294,8 @@ hn_nvs_conn_chim(struct hn_data *hv)\n \t\tPMD_DRV_LOG(NOTICE,\n \t\t\t    \"invalid chimney sending buffer section size: %u\",\n \t\t\t    sectsz);\n-\t\treturn 0;\n+\t\terror = -EINVAL;\n+\t\tgoto cleanup;\n \t}\n \n \thv->chim_szmax = sectsz;\n@@ -304,11 +304,6 @@ hn_nvs_conn_chim(struct hn_data *hv)\n \tPMD_DRV_LOG(INFO, \"send buffer %lu section size:%u, count:%u\",\n \t\t    len, hv->chim_szmax, hv->chim_cnt);\n \n-\tif (len % hv->chim_szmax != 0) {\n-\t\tPMD_DRV_LOG(NOTICE,\n-\t\t\t    \"chimney sending sections are not properly aligned\");\n-\t}\n-\n \t/* Done! */\n \treturn 0;\n \n",
    "prefixes": [
        "1/4"
    ]
}