Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43631/?format=api
{ "id": 43631, "url": "http://patches.dpdk.org/api/patches/43631/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180808152323.9660-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180808152323.9660-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180808152323.9660-2-maxime.coquelin@redhat.com", "date": "2018-08-08T15:23:22", "name": "[RFC,1/2] vhost: add packed ring support to vring base requests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a2545892d75f80f1c95f7f0cd58be0987fb493f8", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180808152323.9660-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 937, "url": "http://patches.dpdk.org/api/series/937/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=937", "date": "2018-08-08T15:23:21", "name": "vhost: packed ring support completion", "version": 1, "mbox": "http://patches.dpdk.org/series/937/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43631/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43631/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CF9212C12;\n\tWed, 8 Aug 2018 17:23:34 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id BE8182BE2\n\tfor <dev@dpdk.org>; Wed, 8 Aug 2018 17:23:33 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 60C9140241C3;\n\tWed, 8 Aug 2018 15:23:33 +0000 (UTC)", "from localhost.localdomain (ovpn-112-49.ams2.redhat.com\n\t[10.36.112.49])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0F2F02166BA0;\n\tWed, 8 Aug 2018 15:23:31 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Wed, 8 Aug 2018 17:23:22 +0200", "Message-Id": "<20180808152323.9660-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180808152323.9660-1-maxime.coquelin@redhat.com>", "References": "<20180808152323.9660-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.7]); Wed, 08 Aug 2018 15:23:33 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.7]); \n\tWed, 08 Aug 2018 15:23:33 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [RFC 1/2] vhost: add packed ring support to vring base\n\trequests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For consistency with Vhost kernel backend, save the wrap\ncounter value into bit 31 of num's vring state field.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex a2d4c9ffc..31cfdf163 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -648,10 +648,15 @@ static int\n vhost_user_set_vring_base(struct virtio_net *dev,\n \t\t\t VhostUserMsg *msg)\n {\n-\tdev->virtqueue[msg->payload.state.index]->last_used_idx =\n-\t\t\tmsg->payload.state.num;\n-\tdev->virtqueue[msg->payload.state.index]->last_avail_idx =\n-\t\t\tmsg->payload.state.num;\n+\tstruct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index];\n+\tif (dev->features & (1ULL << VIRTIO_F_RING_PACKED)) {\n+\t\tvq->avail_wrap_counter = msg->payload.state.num >> 31;\n+\t\tvq->used_wrap_counter = vq->avail_wrap_counter;\n+\t\tmsg->payload.state.num &= ~(1 << 31);\n+\t}\n+\n+\tvq->last_used_idx = msg->payload.state.num;\n+\tvq->last_avail_idx = msg->payload.state.num;\n \n \treturn 0;\n }\n@@ -1083,6 +1088,9 @@ vhost_user_get_vring_base(struct virtio_net *dev,\n \t/* Here we are safe to get the last avail index */\n \tmsg->payload.state.num = vq->last_avail_idx;\n \n+\tif (dev->features & (1ULL << VIRTIO_F_RING_PACKED))\n+\t\tmsg->payload.state.num |= vq->avail_wrap_counter << 31;\n+\n \tRTE_LOG(INFO, VHOST_CONFIG,\n \t\t\"vring base idx:%d file:%d\\n\", msg->payload.state.index,\n \t\tmsg->payload.state.num);\n", "prefixes": [ "RFC", "1/2" ] }