get:
Show a patch.

patch:
Update a patch.

put:
Update a patch.

GET /api/patches/43580/?format=api
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 43580,
    "url": "http://patches.dpdk.org/api/patches/43580/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1533306787-12070-2-git-send-email-hari.kumarx.vemula@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1533306787-12070-2-git-send-email-hari.kumarx.vemula@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1533306787-12070-2-git-send-email-hari.kumarx.vemula@intel.com",
    "date": "2018-08-03T14:33:05",
    "name": "[v3,1/3] test: add unit tests for metrics library",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e92589782c1c1109f134827749a18387d4ef15f2",
    "submitter": {
        "id": 1052,
        "url": "http://patches.dpdk.org/api/people/1052/?format=api",
        "name": "Hari Kumar Vemula",
        "email": "hari.kumarx.vemula@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1533306787-12070-2-git-send-email-hari.kumarx.vemula@intel.com/mbox/",
    "series": [
        {
            "id": 899,
            "url": "http://patches.dpdk.org/api/series/899/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=899",
            "date": "2018-08-03T14:33:04",
            "name": "add unit test for metrics library",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/899/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/43580/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/43580/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9CC5E1B5A5;\n\tFri,  3 Aug 2018 16:33:21 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id B4FB21B5A1\n\tfor <dev@dpdk.org>; Fri,  3 Aug 2018 16:33:19 +0200 (CEST)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Aug 2018 07:33:18 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga006.fm.intel.com with ESMTP; 03 Aug 2018 07:33:17 -0700",
            "from wgcvswdev001.ir.intel.com (wgcvswdev001.ir.intel.com\n\t[10.102.246.100])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw73EXGMh008632; Fri, 3 Aug 2018 15:33:16 +0100",
            "from wgcvswdev001.ir.intel.com (localhost [127.0.0.1])\n\tby wgcvswdev001.ir.intel.com with ESMTP id w73EXDZj012187;\n\tFri, 3 Aug 2018 15:33:13 +0100",
            "(from jmparthx@localhost)\n\tby wgcvswdev001.ir.intel.com with ? id w73EXDWl012183;\n\tFri, 3 Aug 2018 15:33:13 +0100"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,438,1526367600\"; d=\"scan'208\";a=\"251492840\"",
        "From": "Hari Kumar Vemula <hari.kumarx.vemula@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "remy.horton@intel.com, reshma.pattan@intel.com,\n\tHari Kumar Vemula <hari.kumarx.vemula@intel.com>",
        "Date": "Fri,  3 Aug 2018 15:33:05 +0100",
        "Message-Id": "<1533306787-12070-2-git-send-email-hari.kumarx.vemula@intel.com>",
        "X-Mailer": "git-send-email 1.7.12.2",
        "In-Reply-To": "<1533306787-12070-1-git-send-email-hari.kumarx.vemula@intel.com>",
        "References": "<1532183219-23263-1-git-send-email-hari.kumarx.vemula@intel.com>\n\t<1533306787-12070-1-git-send-email-hari.kumarx.vemula@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 1/3] test: add unit tests for metrics library",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Unit testcases are added for metrics library.\n\nSigned-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>\nReviewed-by: Reshma Pattan <reshma.pattan@intel.com>\nReviewed-by: Remy Horton <remy.horton@intel.com>\nAcked-by: Remy Horton <remy.horton@intel.com>\n---\n test/test/Makefile       |   2 +\n test/test/test_metrics.c | 312 +++++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 314 insertions(+)\n create mode 100644 test/test/test_metrics.c",
    "diff": "diff --git a/test/test/Makefile b/test/test/Makefile\nindex e6967bab6..30bc53087 100644\n--- a/test/test/Makefile\n+++ b/test/test/Makefile\n@@ -183,6 +183,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_blockcipher.c\n SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev.c\n SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_asym.c\n \n+SRCS-$(CONFIG_RTE_LIBRTE_METRICS) += test_metrics.c\n+\n ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)\n SRCS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += test_compressdev.c\n endif\ndiff --git a/test/test/test_metrics.c b/test/test/test_metrics.c\nnew file mode 100644\nindex 000000000..12b96625f\n--- /dev/null\n+++ b/test/test/test_metrics.c\n@@ -0,0 +1,312 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Intel Corporation\n+ */\n+\n+#include <stdio.h>\n+#include <string.h>\n+\n+#include <rte_lcore.h>\n+#include <rte_malloc.h>\n+#include <rte_metrics.h>\n+\n+#include \"test.h\"\n+\n+#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))\n+#define\tREG_METRIC_COUNT\t6\n+#define\tMETRIC_LESSER_COUNT\t3\n+#define\tKEY\t1\n+#define\tVALUE\t1\n+\n+/* Initializes metric module. This function must be called\n+ * from a primary process before metrics are used\n+ */\n+static int\n+test_metrics_init(void)\n+{\n+\trte_metrics_init(rte_socket_id());\n+\treturn TEST_SUCCESS;\n+}\n+\n+ /* Test Case to check failures when memzone init is not done */\n+static int\n+test_metrics_without_init(void)\n+{\n+\tint err = 0;\n+\tconst uint64_t  value[REG_METRIC_COUNT] = {0};\n+\tconst char * const mnames[] = {\n+\t\t\"mean_bits_in\", \"mean_bits_out\",\n+\t\t\"peak_bits_in\", \"peak_bits_out\",\n+\t};\n+\n+\t/* Failure Test: Checking for memzone initialization */\n+\terr = rte_metrics_reg_name(\"peak_bits_in\");\n+\tTEST_ASSERT(err == -EIO, \"%s, %d\", __func__, __LINE__);\n+\n+\terr = rte_metrics_reg_names(&mnames[0], 1);\n+\tTEST_ASSERT(err == -EIO, \"%s, %d\", __func__, __LINE__);\n+\n+\terr = rte_metrics_update_value(RTE_METRICS_GLOBAL, KEY, VALUE);\n+\tTEST_ASSERT(err == -EIO, \"%s, %d\", __func__, __LINE__);\n+\n+\terr = rte_metrics_update_values(RTE_METRICS_GLOBAL, KEY, &value[0], 4);\n+\tTEST_ASSERT(err == -EIO, \"%s, %d\", __func__, __LINE__);\n+\n+\terr = rte_metrics_get_names(NULL, 0);\n+\tTEST_ASSERT(err == -EIO, \"%s, %d\", __func__, __LINE__);\n+\n+\terr = rte_metrics_get_values(RTE_METRICS_GLOBAL, NULL, 0);\n+\tTEST_ASSERT(err == -EIO, \"%s, %d\", __func__, __LINE__);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/* Test Case to validate registering a single metric */\n+static int\n+test_metrics_reg_name_with_validname(void)\n+{\n+\tint err = 0;\n+\n+\t/* Test to register the new metric name */\n+\terr = rte_metrics_reg_name(\"peak_bits_out\");\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Test to register the same metric name */\n+\terr = rte_metrics_reg_name(\"peak_bits_out\");\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Test case to validate registering a invalid metric */\n+\terr = rte_metrics_reg_name(NULL);\n+\tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/* Test case to validate registering a list of valid  metric names */\n+static int\n+test_metrics_reg_names(void)\n+{\n+\tint err = 0;\n+\tconst char * const mnames[] = {\n+\t\t\"mean_bits_in\", \"mean_bits_out\",\n+\t\t\"peak_bits_in\", \"peak_bits_out\",\n+\t\t};\n+\n+\t/* Success Test: valid array and count size */\n+\terr = rte_metrics_reg_names(&mnames[0], ARRAY_SIZE(mnames));\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/* Test case to validate update a metric */\n+static int\n+test_metrics_update_value(void)\n+{\n+\tint err = 0;\n+\n+\t/* Successful Test: Valid port_id, key and value */\n+\terr = rte_metrics_update_value(RTE_METRICS_GLOBAL, KEY, VALUE);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Successful Test: Valid port_id otherthan RTE_METRICS_GLOBAL, key\n+\t * and value\n+\t */\n+\terr = rte_metrics_update_value(9, KEY, VALUE);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Failed Test: Invalid port_id with lower value */\n+\terr = rte_metrics_update_value(-2, KEY, VALUE);\n+\tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Failed Test: Invalid port_id with higher value */\n+\terr = rte_metrics_update_value(39, KEY, VALUE);\n+\tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Failed Test: valid port id, value with invalid key */\n+\terr = rte_metrics_update_value(RTE_METRICS_GLOBAL, KEY+12, VALUE);\n+\tTEST_ASSERT(err < 0, \"%s, %d\", __func__, __LINE__);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/* Test case to validate update a list of  metrics  */\n+static int\n+test_metrics_update_values(void)\n+{\n+\tint err = 0;\n+\tconst uint64_t  value[REG_METRIC_COUNT] = {1, 2, 3, 4, 5, 6};\n+\n+\t/* Successful Test: update metrics with first set */\n+\terr = rte_metrics_update_values(RTE_METRICS_GLOBAL, 0,\n+\t\t\t&value[0], 1);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Successful Test: update metrics with second set */\n+\terr = rte_metrics_update_values(RTE_METRICS_GLOBAL, 1,\n+\t\t\t&value[1], 1);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Successful Test: update metrics with third set */\n+\terr = rte_metrics_update_values(RTE_METRICS_GLOBAL, 2,\n+\t\t\t&value[2], 4);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Failed Test: Invalid count size */\n+\terr = rte_metrics_update_values(RTE_METRICS_GLOBAL,\n+\t\t\t KEY, &value[0], 0);\n+\tTEST_ASSERT(err < 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Failed Test: Invalid port_id(lower value) and valid data */\n+\terr = rte_metrics_update_values(-2, KEY, &value[0], ARRAY_SIZE(value));\n+\tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Failed Test: Invalid port_id(higher value) and valid data */\n+\terr = rte_metrics_update_values(39, 1, &value[0], ARRAY_SIZE(value));\n+\tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Failed Test: Invalid array */\n+\terr = rte_metrics_update_values(RTE_METRICS_GLOBAL,\n+\t\t\t KEY, NULL, ARRAY_SIZE(value));\n+\tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/* Test to validate get metric name-key lookup table */\n+static int\n+test_metrics_get_names(void)\n+{\n+\tint err = 0;\n+\tstruct rte_metric_name metrics[METRIC_LESSER_COUNT];\n+\tstruct rte_metric_name success_metrics[REG_METRIC_COUNT];\n+\n+\t/* Successful Test: Invalid array list */\n+\terr = rte_metrics_get_names(NULL, 0);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Successful Test: Valid array list, Correct Count Stats same\n+\t * as memzone stats\n+\t */\n+\terr = rte_metrics_get_names(success_metrics, REG_METRIC_COUNT);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Successful Test: Valid array list, Increase Count Stats than\n+\t * memzone stats\n+\t */\n+\terr = rte_metrics_get_names(success_metrics, REG_METRIC_COUNT+5);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Successful Test, Not update results:\n+\t * Invalid array list, Lesser Count Stats than allocated stats\n+\t */\n+\terr = rte_metrics_get_names(metrics, METRIC_LESSER_COUNT);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/* Test to validate get list of metric values  */\n+static int\n+test_metrics_get_values(void)\n+{\n+\tint i = 0;\n+\tint err = 0;\n+\tstruct rte_metric_value getvalues[REG_METRIC_COUNT];\n+\n+\tsize_t m_size = sizeof(struct rte_metric_value);\n+\tfor (i = 0; i < REG_METRIC_COUNT; i++)\n+\t\tmemset(&getvalues[i], 0, m_size);\n+\n+\t/* Successful Test, Not update results: valid arguments\n+\t * count lessthan the memzone stats\n+\t */\n+\terr = rte_metrics_get_values(RTE_METRICS_GLOBAL, getvalues,\n+\t\t\t METRIC_LESSER_COUNT);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Successful Test, update results: valid arguments */\n+\terr = rte_metrics_get_values(RTE_METRICS_GLOBAL, getvalues,\n+\t\t\t REG_METRIC_COUNT);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Successful Test : valid arguments count greaterthan the\n+\t * memzone stats\n+\t */\n+\terr = rte_metrics_get_values(RTE_METRICS_GLOBAL, getvalues,\n+\t\t\tREG_METRIC_COUNT+2);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Failure Test: Invalid port_id(lower value) with correct values\n+\t * and  Capacity\n+\t */\n+\terr = rte_metrics_get_values(-2, getvalues, REG_METRIC_COUNT);\n+\tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Failure Test: Invalid port_id(higher value) with correct values\n+\t * and  Capacity\n+\t */\n+\terr = rte_metrics_get_values(33, getvalues, REG_METRIC_COUNT);\n+\tTEST_ASSERT(err == -EINVAL, \"%s, %d\", __func__, __LINE__);\n+\n+\t/* Successful Test: valid port_id with incorrect values and  valid\n+\t * capacity\n+\t */\n+\terr = rte_metrics_get_values(RTE_METRICS_GLOBAL, NULL,\n+\t\t\t REG_METRIC_COUNT);\n+\tTEST_ASSERT(err >= 0, \"%s, %d\", __func__, __LINE__);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+static struct unit_test_suite metrics_testsuite  = {\n+\t.suite_name = \"Metrics Unit Test Suite\",\n+\t.setup = NULL,\n+\t.teardown = NULL,\n+\t.unit_test_cases = {\n+\t\t/* Test Case 1: Test to check all metric APIs without\n+\t\t * metrics init\n+\t\t */\n+\t\tTEST_CASE(test_metrics_without_init),\n+\n+\t\t/* TEST CASE 2: Test to register valid metrics*/\n+\t\tTEST_CASE_ST(test_metrics_init, NULL,\n+\t\t\t\ttest_metrics_reg_name_with_validname),\n+\n+\t\t/* TEST CASE 3: Test to register list of metrics with valid\n+\t\t * names and valid count size, invalid names and invalid\n+\t\t * count size\n+\t\t */\n+\t\tTEST_CASE(test_metrics_reg_names),\n+\n+\t\t/* TEST CASE 4: Test to register a update value with valid port\n+\t\t * id and invalid port id\n+\t\t */\n+\t\tTEST_CASE(test_metrics_update_value),\n+\n+\t\t/* TEST CASE 5: Test to register update list of values with\n+\t\t * valid port id, key, value, count size and invalid port id,\n+\t\t * key, value, count size\n+\t\t */\n+\t\tTEST_CASE(test_metrics_update_values),\n+\n+\t\t/* TEST CASE 6: Test to get metric names-key with valid\n+\t\t * array list, count size and invalid array list, count size\n+\t\t */\n+\t\tTEST_CASE(test_metrics_get_names),\n+\n+\t\t/* TEST CASE 7: Test to get list of metric values with valid\n+\t\t * port id, array list, count size and invalid port id,\n+\t\t * arraylist, count size\n+\t\t */\n+\t\tTEST_CASE(test_metrics_get_values),\n+\t\tTEST_CASES_END()\n+\t}\n+};\n+\n+static int\n+test_metrics(void)\n+{\n+\treturn unit_test_suite_runner(&metrics_testsuite);\n+}\n+\n+REGISTER_TEST_COMMAND(metrics_autotest, test_metrics);\n",
    "prefixes": [
        "v3",
        "1/3"
    ]
}