Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43566/?format=api
{ "id": 43566, "url": "http://patches.dpdk.org/api/patches/43566/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180803132032.29038-6-adrien.mazarguil@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180803132032.29038-6-adrien.mazarguil@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180803132032.29038-6-adrien.mazarguil@6wind.com", "date": "2018-08-03T13:36:41", "name": "[v2,5/7] net/bonding: switch to flow API object conversion function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d7a0b5504f3e9d4edd9eb2d464f811213e98eb8b", "submitter": { "id": 165, "url": "http://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180803132032.29038-6-adrien.mazarguil@6wind.com/mbox/", "series": [ { "id": 897, "url": "http://patches.dpdk.org/api/series/897/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=897", "date": "2018-08-03T13:36:30", "name": "ethdev: add flow API object converter", "version": 2, "mbox": "http://patches.dpdk.org/series/897/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43566/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43566/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3CF541B59E;\n\tFri, 3 Aug 2018 15:37:01 +0200 (CEST)", "from mail-wr1-f65.google.com (mail-wr1-f65.google.com\n\t[209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 1CF211B595\n\tfor <dev@dpdk.org>; Fri, 3 Aug 2018 15:36:59 +0200 (CEST)", "by mail-wr1-f65.google.com with SMTP id f12-v6so5425254wrv.12\n\tfor <dev@dpdk.org>; Fri, 03 Aug 2018 06:36:59 -0700 (PDT)", "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\ti1-v6sm3603956wrq.69.2018.08.03.06.36.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 03 Aug 2018 06:36:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to;\n\tbh=rZTlv8/S5UVprjogu8YheU4Mt0j+9W4zrSgtK/ZgQJ4=;\n\tb=VdfTzKWqOvegdzjA8Plouc89c6WLqC8jzMyh/7aZyQND4EestRR7nPkKaAQ/5uhT85\n\t393tnox7baKhTOQbOpQVYk6z5vEhvWWPsF3m0ADu8prSvG3mMqQ2TvUXt4UONz3GOOYu\n\tmfFkU/Lp4VLU9AdWM4GBoKvKNiO3/fJ0oHr8PxfdScTKRPEYlublowKRXvFebO5qr8Rz\n\tAjnbHBnhXL9gbfd7QBPcDB1sjQQ0piZJkArUloIiOZ1c7YMf9Dy1vNPLXVmgcK5dNZSb\n\twSn0kM12s9vF2q9kmQpjRTXBnO0uvtL7CSLv7bOydAgGTjuK2pRbM0Bn4rvdpxzFrmBC\n\td0AA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to;\n\tbh=rZTlv8/S5UVprjogu8YheU4Mt0j+9W4zrSgtK/ZgQJ4=;\n\tb=FZO/dde0ewOW+oAvgAzWk+5LCrSPbL6mxScEHaMIZOkl3Gt/AyCejhby9smbSa4gn2\n\tqiBzVh9S/CdiRcnSRNtRsUlyyL7G3nMAwKAjZYE2Py/3bVOM2y0hOTcczYoiJ65wn2qT\n\t9ETGFjfi37b1Aqr4mS7476ulDoxhcdCO58pZDVGSdAZaZZFix+d9HUGM01Ju8x7IXCJs\n\tc+Gprbk/4CuCgfHrxCCURIYvQt5LGQLLznF6G/qDaIZ2RXM9Vvbj6BDH5dg1rUdeuniM\n\t8pdRvePot7ZAgaqMtfN9yc2hkjtRNsdOpy35KmOAjQ2/qzl83TLcNQXL9mX8GwKwfRBJ\n\tSVjQ==", "X-Gm-Message-State": "AOUpUlH7i1wnxLSp4O4xYGGo6Khfm9rTRkg35on3BPVi4oCnrXRAKlhD\n\taGVgVpi7peb2/BedJSFFL4Vzc+6DkRk36A==", "X-Google-Smtp-Source": "AAOMgpfiBt6hYcuiT6hhovL7bxuEdNkL0OLEV+6GqllNcvKulR/9zrOLm1HwvyDT5xW4tIDkQnGYHA==", "X-Received": "by 2002:adf:b202:: with SMTP id\n\tu2-v6mr2607273wra.19.1533303418845; \n\tFri, 03 Aug 2018 06:36:58 -0700 (PDT)", "Date": "Fri, 3 Aug 2018 15:36:41 +0200", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>,\n\tChas Williams <chas3@att.com>", "Message-ID": "<20180803132032.29038-6-adrien.mazarguil@6wind.com>", "References": "<cover.1507193185.git.adrien.mazarguil@6wind.com>\n\t<20180803132032.29038-1-adrien.mazarguil@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20180803132032.29038-1-adrien.mazarguil@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[dpdk-dev] [PATCH v2 5/7] net/bonding: switch to flow API object\n\tconversion function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch replaces rte_flow_copy() with rte_flow_conv().\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\nCc: Declan Doherty <declan.doherty@intel.com>\nCc: Chas Williams <chas3@att.com>\n--\nv2 changes:\n\n- Patch was not present in original series.\n---\n drivers/net/bonding/rte_eth_bond_api.c | 6 ++---\n drivers/net/bonding/rte_eth_bond_flow.c | 31 +++++++++++++++++++------\n drivers/net/bonding/rte_eth_bond_private.h | 5 +++-\n 3 files changed, 31 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c\nindex 49fa2d78d..045c907cf 100644\n--- a/drivers/net/bonding/rte_eth_bond_api.c\n+++ b/drivers/net/bonding/rte_eth_bond_api.c\n@@ -245,9 +245,9 @@ slave_rte_flow_prepare(uint16_t slave_id, struct bond_dev_private *internals)\n \t}\n \tTAILQ_FOREACH(flow, &internals->flow_list, next) {\n \t\tflow->flows[slave_id] = rte_flow_create(slave_port_id,\n-\t\t\t\t\t\t\t&flow->fd->attr,\n-\t\t\t\t\t\t\tflow->fd->items,\n-\t\t\t\t\t\t\tflow->fd->actions,\n+\t\t\t\t\t\t\tflow->rule.attr,\n+\t\t\t\t\t\t\tflow->rule.pattern,\n+\t\t\t\t\t\t\tflow->rule.actions,\n \t\t\t\t\t\t\t&ferror);\n \t\tif (flow->flows[slave_id] == NULL) {\n \t\t\tRTE_BOND_LOG(ERR, \"Cannot create flow for slave\"\ndiff --git a/drivers/net/bonding/rte_eth_bond_flow.c b/drivers/net/bonding/rte_eth_bond_flow.c\nindex 31e4bcaeb..f94d46ca4 100644\n--- a/drivers/net/bonding/rte_eth_bond_flow.c\n+++ b/drivers/net/bonding/rte_eth_bond_flow.c\n@@ -2,8 +2,11 @@\n * Copyright 2018 Mellanox Technologies, Ltd\n */\n \n+#include <stddef.h>\n+#include <string.h>\n #include <sys/queue.h>\n \n+#include <rte_errno.h>\n #include <rte_malloc.h>\n #include <rte_tailq.h>\n #include <rte_flow.h>\n@@ -16,19 +19,33 @@ bond_flow_alloc(int numa_node, const struct rte_flow_attr *attr,\n \t\t const struct rte_flow_action *actions)\n {\n \tstruct rte_flow *flow;\n-\tsize_t fdsz;\n+\tconst struct rte_flow_conv_rule rule = {\n+\t\t.attr_ro = attr,\n+\t\t.pattern_ro = items,\n+\t\t.actions_ro = actions,\n+\t};\n+\tstruct rte_flow_error error;\n+\tint ret;\n \n-\tfdsz = rte_flow_copy(NULL, 0, attr, items, actions);\n-\tflow = rte_zmalloc_socket(NULL, sizeof(struct rte_flow) + fdsz,\n+\tret = rte_flow_conv(RTE_FLOW_CONV_OP_RULE, NULL, 0, &rule, &error);\n+\tif (ret < 0) {\n+\t\tRTE_BOND_LOG(ERR, \"Unable to process flow rule (%s): %s\",\n+\t\t\t error.message ? error.message : \"unspecified\",\n+\t\t\t strerror(rte_errno));\n+\t\treturn NULL;\n+\t}\n+\tflow = rte_zmalloc_socket(NULL, offsetof(struct rte_flow, rule) + ret,\n \t\t\t\t RTE_CACHE_LINE_SIZE, numa_node);\n \tif (unlikely(flow == NULL)) {\n \t\tRTE_BOND_LOG(ERR, \"Could not allocate new flow\");\n \t\treturn NULL;\n \t}\n-\tflow->fd = (void *)((uintptr_t)flow + sizeof(*flow));\n-\tif (unlikely(rte_flow_copy(flow->fd, fdsz, attr, items, actions) !=\n-\t\t fdsz)) {\n-\t\tRTE_BOND_LOG(ERR, \"Failed to copy flow description\");\n+\tret = rte_flow_conv(RTE_FLOW_CONV_OP_RULE, &flow->rule, ret, &rule,\n+\t\t\t &error);\n+\tif (ret < 0) {\n+\t\tRTE_BOND_LOG(ERR, \"Failed to copy flow rule (%s): %s\",\n+\t\t\t error.message ? error.message : \"unspecified\",\n+\t\t\t strerror(rte_errno));\n \t\trte_free(flow);\n \t\treturn NULL;\n \t}\ndiff --git a/drivers/net/bonding/rte_eth_bond_private.h b/drivers/net/bonding/rte_eth_bond_private.h\nindex 43e0e448d..61202845e 100644\n--- a/drivers/net/bonding/rte_eth_bond_private.h\n+++ b/drivers/net/bonding/rte_eth_bond_private.h\n@@ -5,9 +5,11 @@\n #ifndef _RTE_ETH_BOND_PRIVATE_H_\n #define _RTE_ETH_BOND_PRIVATE_H_\n \n+#include <stdint.h>\n #include <sys/queue.h>\n \n #include <rte_ethdev_driver.h>\n+#include <rte_flow.h>\n #include <rte_spinlock.h>\n #include <rte_bitmap.h>\n #include <rte_flow_driver.h>\n@@ -93,7 +95,8 @@ struct rte_flow {\n \t/* Slaves flows */\n \tstruct rte_flow *flows[RTE_MAX_ETHPORTS];\n \t/* Flow description for synchronization */\n-\tstruct rte_flow_desc *fd;\n+\tstruct rte_flow_conv_rule rule;\n+\tuint8_t rule_data[];\n };\n \n typedef void (*burst_xmit_hash_t)(struct rte_mbuf **buf, uint16_t nb_pkts,\n", "prefixes": [ "v2", "5/7" ] }