Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43517/?format=api
{ "id": 43517, "url": "http://patches.dpdk.org/api/patches/43517/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1533198964-30218-1-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1533198964-30218-1-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1533198964-30218-1-git-send-email-harry.van.haaren@intel.com", "date": "2018-08-02T08:36:04", "name": "event: fix check in ring_init() in event ring code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5ee8e75ed4fafc7ed17cfdea9fcaadfcfa9f86fa", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1533198964-30218-1-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [ { "id": 870, "url": "http://patches.dpdk.org/api/series/870/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=870", "date": "2018-08-02T08:36:04", "name": "event: fix check in ring_init() in event ring code", "version": 1, "mbox": "http://patches.dpdk.org/series/870/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43517/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43517/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9860F1B454;\n\tThu, 2 Aug 2018 10:36:18 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 3EF761B449;\n\tThu, 2 Aug 2018 10:36:15 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Aug 2018 01:36:14 -0700", "from silpixa00399779.ir.intel.com ([10.237.223.187])\n\tby FMSMGA003.fm.intel.com with ESMTP; 02 Aug 2018 01:36:13 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,434,1526367600\"; d=\"scan'208\";a=\"69452514\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "Harry van Haaren <harry.van.haaren@intel.com>, bruce.richardson@intel.com,\n\tstable@dpdk.org, thomas@monjalon.net, jerin.jacob@caviumnetworks.com", "Date": "Thu, 2 Aug 2018 09:36:04 +0100", "Message-Id": "<1533198964-30218-1-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] event: fix check in ring_init() in event ring\n\tcode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit fixes a bug in a 32-bit environment where the\ngeneric ring_init() would fail, but given the interaction\nwith memzones the next iteration of the event_ring_autotest\nwould actually *pass* because the ring in question would\nexist already an be looked-up.\n\nThis commit rightly error checks the result of ring_init(),\nand calls rte_free() on the memory as required.\n\nFixes: dc39e2f359b5 (\"eventdev: add ring structure for events\")\nCc: bruce.richardson@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nCc: thomas@monjalon.net\nCc: jerin.jacob@caviumnetworks.com\n\nPlease consider this for RC3, as it fixes the unit tests\non 32-bit systems.\n---\n lib/librte_eventdev/rte_event_ring.c | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eventdev/rte_event_ring.c b/lib/librte_eventdev/rte_event_ring.c\nindex eb67751..5791928 100644\n--- a/lib/librte_eventdev/rte_event_ring.c\n+++ b/lib/librte_eventdev/rte_event_ring.c\n@@ -82,11 +82,14 @@ rte_event_ring_create(const char *name, unsigned int count, int socket_id,\n \tmz = rte_memzone_reserve(mz_name, ring_size, socket_id, mz_flags);\n \tif (mz != NULL) {\n \t\tr = mz->addr;\n-\t\t/*\n-\t\t * no need to check return value here, we already checked the\n-\t\t * arguments above\n-\t\t */\n-\t\trte_event_ring_init(r, name, requested_count, flags);\n+\t\t/* Check return value in case rte_ring_init() fails on size */\n+\t\tint err = rte_event_ring_init(r, name, requested_count, flags);\n+\t\tif (err) {\n+\t\t\tRTE_LOG(ERR, RING, \"Ring init failed\\n\");\n+\t\t\trte_free(te);\n+\t\t\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\t\t\treturn 0;\n+\t\t}\n \n \t\tte->data = (void *) r;\n \t\tr->r.memzone = mz;\n", "prefixes": [] }