Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 435,
    "url": "http://patches.dpdk.org/api/patches/435/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1411375081-27986-5-git-send-email-david.marchand@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1411375081-27986-5-git-send-email-david.marchand@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1411375081-27986-5-git-send-email-david.marchand@6wind.com",
    "date": "2014-09-22T08:37:58",
    "name": "[dpdk-dev,4/7] eal: fix checkpatch issues before moving code",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "717e412ce3f775679f01414e39713f5c40348c34",
    "submitter": {
        "id": 3,
        "url": "http://patches.dpdk.org/api/people/3/?format=api",
        "name": "David Marchand",
        "email": "david.marchand@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1411375081-27986-5-git-send-email-david.marchand@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/435/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/435/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8AEEDB3AB;\n\tMon, 22 Sep 2014 10:32:13 +0200 (CEST)",
            "from mail-wi0-f175.google.com (mail-wi0-f175.google.com\n\t[209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 02857B3B0\n\tfor <dev@dpdk.org>; Mon, 22 Sep 2014 10:32:10 +0200 (CEST)",
            "by mail-wi0-f175.google.com with SMTP id r20so2432249wiv.8\n\tfor <dev@dpdk.org>; Mon, 22 Sep 2014 01:38:13 -0700 (PDT)",
            "from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tjs2sm11522334wjc.9.2014.09.22.01.38.11 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 22 Sep 2014 01:38:12 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=jLjRIry/x2iiajWLuQ5VjEtEbGtLlQaXpAVor/XAeUM=;\n\tb=AC8hivujtHQpmA/oHcYkSZuXtq9ddAQtqr02Gy0GQZSiUCC/y1xKr+xf89AgvETuuk\n\tg7QQKx7ke8oRC/7EAKo6ZQVXplPq0YuFkDgZsn7CXaUt2hX7rZWqdGlps5zyCtDJSapx\n\t54FcletL8aTcX8+JXcD3o2llNjsyTJp3JJDNyNn1LZTYHPa/kAICE1eAFDY6xVJOwIhO\n\tTSX9fxzR86WUmeb0uE3RbBj6inURygN9F87BBpiJZDeYdMoTw2OwSua3aDS1fOa8vOuB\n\tMutUbBNMVM4M5LpWLU7v00SUOYn8UQsmAAH2Zyounv1StFsBqajpvpSUsaT4cPwB2Cj0\n\t+8JA==",
        "X-Gm-Message-State": "ALoCoQlwv9QH8YBjjPjj56YOMMb8dofqjftRaCca3RW2WDsdDyyea4AnxyhPG5LHFdvU8wg5ml6s",
        "X-Received": "by 10.180.91.133 with SMTP id ce5mr13576216wib.62.1411375093093; \n\tMon, 22 Sep 2014 01:38:13 -0700 (PDT)",
        "From": "David Marchand <david.marchand@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon, 22 Sep 2014 10:37:58 +0200",
        "Message-Id": "<1411375081-27986-5-git-send-email-david.marchand@6wind.com>",
        "X-Mailer": "git-send-email 1.7.10.4",
        "In-Reply-To": "<1411375081-27986-1-git-send-email-david.marchand@6wind.com>",
        "References": "<1411375081-27986-1-git-send-email-david.marchand@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 4/7] eal: fix checkpatch issues before moving code",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/bsdapp/eal/eal.c   |   21 +++++++------------\n lib/librte_eal/linuxapp/eal/eal.c |   42 +++++++++++++------------------------\n 2 files changed, 21 insertions(+), 42 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c\nindex 8599a35..81d1a65 100644\n--- a/lib/librte_eal/bsdapp/eal/eal.c\n+++ b/lib/librte_eal/bsdapp/eal/eal.c\n@@ -613,30 +613,23 @@ eal_parse_args(int argc, char **argv)\n \t\tcase 0:\n \t\t\tif (!strcmp(lgopts[option_index].name, OPT_NO_HUGE)) {\n \t\t\t\tinternal_config.no_hugetlbfs = 1;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_NO_PCI)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_NO_PCI)) {\n \t\t\t\tinternal_config.no_pci = 1;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_NO_HPET)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_NO_HPET)) {\n \t\t\t\tinternal_config.no_hpet = 1;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_VMWARE_TSC_MAP)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_VMWARE_TSC_MAP)) {\n \t\t\t\tinternal_config.vmware_tsc_map = 1;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_NO_SHCONF)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_NO_SHCONF)) {\n \t\t\t\tinternal_config.no_shconf = 1;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_PROC_TYPE)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_PROC_TYPE)) {\n \t\t\t\tinternal_config.process_type = eal_parse_proc_type(optarg);\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_VDEV)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_VDEV)) {\n \t\t\t\tif (rte_eal_devargs_add(RTE_DEVTYPE_VIRTUAL,\n \t\t\t\t\t\toptarg) < 0) {\n \t\t\t\t\teal_usage(prgname);\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_SYSLOG)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_SYSLOG)) {\n \t\t\t\tif (eal_parse_syslog(optarg) < 0) {\n \t\t\t\t\tRTE_LOG(ERR, EAL, \"invalid parameters for --\"\n \t\t\t\t\t\t\tOPT_SYSLOG \"\\n\");\ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 655c454..3393550 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -839,8 +839,7 @@ eal_parse_args(int argc, char **argv)\n \t\tcase 0:\n \t\t\tif (!strcmp(lgopts[option_index].name, OPT_NO_HUGE)) {\n \t\t\t\tinternal_config.no_hugetlbfs = 1;\n-\t\t\t}\n-\t\t\tif (!strcmp(lgopts[option_index].name, OPT_XEN_DOM0)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_XEN_DOM0)) {\n \t\t#ifdef RTE_LIBRTE_XEN_DOM0\n \t\t\t\tinternal_config.xen_dom0_support = 1;\n \t\t#else\n@@ -849,44 +848,34 @@ eal_parse_args(int argc, char **argv)\n \t\t\t\t\t\" RTE_LIBRTE_XEN_DOM0=y\\n\");\n \t\t\t\treturn -1;\n \t\t#endif\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_NO_PCI)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_NO_PCI)) {\n \t\t\t\tinternal_config.no_pci = 1;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_NO_HPET)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_NO_HPET)) {\n \t\t\t\tinternal_config.no_hpet = 1;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_VMWARE_TSC_MAP)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_VMWARE_TSC_MAP)) {\n \t\t\t\tinternal_config.vmware_tsc_map = 1;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_NO_SHCONF)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_NO_SHCONF)) {\n \t\t\t\tinternal_config.no_shconf = 1;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_HUGE_DIR)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_HUGE_DIR)) {\n \t\t\t\tinternal_config.hugepage_dir = optarg;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_PROC_TYPE)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_PROC_TYPE)) {\n \t\t\t\tinternal_config.process_type = eal_parse_proc_type(optarg);\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_FILE_PREFIX)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_FILE_PREFIX)) {\n \t\t\t\tinternal_config.hugefile_prefix = optarg;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_SOCKET_MEM)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_SOCKET_MEM)) {\n \t\t\t\tif (eal_parse_socket_mem(optarg) < 0) {\n \t\t\t\t\tRTE_LOG(ERR, EAL, \"invalid parameters for --\"\n \t\t\t\t\t\t\tOPT_SOCKET_MEM \"\\n\");\n \t\t\t\t\teal_usage(prgname);\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_VDEV)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_VDEV)) {\n \t\t\t\tif (rte_eal_devargs_add(RTE_DEVTYPE_VIRTUAL,\n \t\t\t\t\t\toptarg) < 0) {\n \t\t\t\t\teal_usage(prgname);\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_SYSLOG)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_SYSLOG)) {\n \t\t\t\tif (eal_parse_syslog(optarg) < 0) {\n \t\t\t\t\tRTE_LOG(ERR, EAL, \"invalid parameters for --\"\n \t\t\t\t\t\t\tOPT_SYSLOG \"\\n\");\n@@ -905,24 +894,21 @@ eal_parse_args(int argc, char **argv)\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n \t\t\t\tinternal_config.log_level = log;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_BASE_VIRTADDR)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_BASE_VIRTADDR)) {\n \t\t\t\tif (eal_parse_base_virtaddr(optarg) < 0) {\n \t\t\t\t\tRTE_LOG(ERR, EAL, \"invalid parameter for --\"\n \t\t\t\t\t\t\tOPT_BASE_VIRTADDR \"\\n\");\n \t\t\t\t\teal_usage(prgname);\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_VFIO_INTR)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_VFIO_INTR)) {\n \t\t\t\tif (eal_parse_vfio_intr(optarg) < 0) {\n \t\t\t\t\tRTE_LOG(ERR, EAL, \"invalid parameters for --\"\n \t\t\t\t\t\t\tOPT_VFIO_INTR \"\\n\");\n \t\t\t\t\teal_usage(prgname);\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_CREATE_UIO_DEV)) {\n+\t\t\t} else if (!strcmp(lgopts[option_index].name, OPT_CREATE_UIO_DEV)) {\n \t\t\t\tinternal_config.create_uio_dev = 1;\n \t\t\t} else {\n \t\t\t\tRTE_LOG(ERR, EAL, \"Option %s is not supported \"\n",
    "prefixes": [
        "dpdk-dev",
        "4/7"
    ]
}