Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43451/?format=api
{ "id": 43451, "url": "http://patches.dpdk.org/api/patches/43451/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1532972059-191978-1-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1532972059-191978-1-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1532972059-191978-1-git-send-email-harry.van.haaren@intel.com", "date": "2018-07-30T17:34:19", "name": "[v2] net/i40e: fix avx2 driver check for rx rearm", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7bbd72a42b702515415e8a03049c8e45919487c0", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1532972059-191978-1-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [ { "id": 822, "url": "http://patches.dpdk.org/api/series/822/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=822", "date": "2018-07-30T17:34:19", "name": "[v2] net/i40e: fix avx2 driver check for rx rearm", "version": 2, "mbox": "http://patches.dpdk.org/series/822/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43451/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43451/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EC8125F0F;\n\tMon, 30 Jul 2018 19:34:36 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 3DE0C5B2C;\n\tMon, 30 Jul 2018 19:34:34 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 Jul 2018 10:34:33 -0700", "from silpixa00399779.ir.intel.com ([10.237.223.187])\n\tby FMSMGA003.fm.intel.com with ESMTP; 30 Jul 2018 10:34:31 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,422,1526367600\"; d=\"scan'208\";a=\"68686276\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "Harry van Haaren <harry.van.haaren@intel.com>, bruce.richardson@intel.com,\n\tstable@dpdk.org, thomas@monjalon.net, david.coyle@intel.com,\n\tbeilei.xing@intel.com, qi.z.zhang@intel.com", "Date": "Mon, 30 Jul 2018 18:34:19 +0100", "Message-Id": "<1532972059-191978-1-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1532971818-191870-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1532971818-191870-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: fix avx2 driver check for rx rearm", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit fixes an infinite loop bug that could occur\nif the i40e AVX2 driver is used, and high traffic rates\ncause the mempool from which the rxq pulls mbufs to become\nempty.\n\nThe result would be an infinite loop of checking if we\nshould perform an rx rearm, calling the function and an\nerror return due the the mempool being emtpy.\n\nThe fix is to align the code in the AVX2 driver with the\nSSE driver, where an if() is used instead of a while(),\nallowing the thread to return from i40e rx function even\nif the mempool is empty.\n\nFixes: dafadd73762e (\"net/i40e: add AVX2 Rx function\")\nCc: bruce.richardson@intel.com\nCc: stable@dpdk.org\n\nReported-by: David Coyle <david.coyle@intel.com>\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nv2:\n- Fix typo, sorry for email flood :)\n\nCc: thomas@monjalon.net\n@Thomas, please consider this fix for inclusion in 18.08-rc3\nassuming it gets verified as a good fix and Acked.\n\nReporter please verify:\nCc: david.coyle@intel.com\n\ni40e maintainers, please Review/Ack:\nCc: beilei.xing@intel.com\nCc: qi.z.zhang@intel.com\n---\n drivers/net/i40e/i40e_rxtx_vec_avx2.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx2.c b/drivers/net/i40e/i40e_rxtx_vec_avx2.c\nindex dbcb61f..23179b3 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_avx2.c\n+++ b/drivers/net/i40e/i40e_rxtx_vec_avx2.c\n@@ -188,7 +188,7 @@ _recv_raw_pkts_vec_avx2(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \t/* See if we need to rearm the RX queue - gives the prefetch a bit\n \t * of time to act\n \t */\n-\twhile (rxq->rxrearm_nb > RTE_I40E_RXQ_REARM_THRESH)\n+\tif (rxq->rxrearm_nb > RTE_I40E_RXQ_REARM_THRESH)\n \t\ti40e_rxq_rearm(rxq);\n \n \t/* Before we start moving massive data around, check to see if\n", "prefixes": [ "v2" ] }