Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 43382,
    "url": "http://patches.dpdk.org/api/patches/43382/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180725182019.31518-4-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180725182019.31518-4-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180725182019.31518-4-stephen@networkplumber.org",
    "date": "2018-07-25T18:20:18",
    "name": "[3/4] eal: don't crash if alarm set fails",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e8b0966a7ee9057307808818e2e4586e3007bbfa",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180725182019.31518-4-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 778,
            "url": "http://patches.dpdk.org/api/series/778/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=778",
            "date": "2018-07-25T18:20:15",
            "name": "small cleanups",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/778/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/43382/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/43382/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4CA883798;\n\tWed, 25 Jul 2018 20:20:31 +0200 (CEST)",
            "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 085A63257\n\tfor <dev@dpdk.org>; Wed, 25 Jul 2018 20:20:26 +0200 (CEST)",
            "by mail-pg1-f196.google.com with SMTP id r1-v6so5832633pgp.11\n\tfor <dev@dpdk.org>; Wed, 25 Jul 2018 11:20:25 -0700 (PDT)",
            "from localhost.localdomain ([167.220.62.92])\n\tby smtp.gmail.com with ESMTPSA id\n\tl85-v6sm25973854pfk.34.2018.07.25.11.20.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 25 Jul 2018 11:20:23 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=vXByrRyb+hZHrXapovd4DDhWc40AdT9uNuOBrXKQ48w=;\n\tb=jkysMPwUoaD0Rgg2qezADtSJKtWNT8u3Fq1guq7EBZMzQgZGhIMYQ0RHeGmvw9hGlo\n\tsLO4Ju1ZL6/QygrT0lV8C5eLdcHAlQHORfgu2lQWjer6BXRVnNS6aiov/wNGrYE2+kdZ\n\tip9rj01yyFRV5R5+1PE+RuLlTJ0z2RsJu6dDcJX68LGNIAiUH3Mz2UlBhlii2DPW8NzL\n\tJb3RJwQShrJbZMS6Hcpfj4z8m0yERPt3WHfd75Pu5XyGhtVE5xl/eIexvXNpyPBGz/yP\n\tJ+Jt8U3joy0uXTNwPbw7a3c8kTyUmYtEUShc6hHGj6VzWPZdAYk2F3C2A63wMf4o2zkq\n\tUjpA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=vXByrRyb+hZHrXapovd4DDhWc40AdT9uNuOBrXKQ48w=;\n\tb=Jocucqvk0PeVAyQ7MHqJvSzvlUhnINvYmB/MT7wa7x8Khr97w15m1FCgcU7E+fiDAU\n\tJ3GJNOrSwSeY0nKIrz5HhwHwKHH9VGwVjVnarVIxOFXr/cnFnIvrJz/xJpd/FSinjkzs\n\t/plLKzl+XhgDpPPMu54iEdLwWgAyY8EQmh/kuLkR2TRvLu0W18NDcBjsaXBb4LiT2QWz\n\tdJ58qV6GjzckoT4Y03479//bKE5R3jjyly9AiESlXhF5UCw572fN/iHb0SRVmS6vNXrw\n\tsa5B5fkRNXOKjdpnKOtyYWfxwXdZO/dROe7jwz2rUwqinKsKFdu3gOyr5YtstQ7VhG7Q\n\tB0kQ==",
        "X-Gm-Message-State": "AOUpUlGJgqATwHq0YyKLwNMZKWsRPzR5xXyWWla5w6tdAhxOrH6dXMcL\n\t1JGiiG4HptjqqBpzfPZeGjGtCziUr2g=",
        "X-Google-Smtp-Source": "AAOMgpdP+r67Ga4+JdAdAkDMu4VO13L6q4KNQW1VG1a1a49rQoi3DdfdcrEnUTNW4fUHxojxlFlS7A==",
        "X-Received": "by 2002:a63:4306:: with SMTP id\n\tq6-v6mr20769846pga.181.1532542824921; \n\tWed, 25 Jul 2018 11:20:24 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>",
        "Date": "Wed, 25 Jul 2018 11:20:18 -0700",
        "Message-Id": "<20180725182019.31518-4-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20180725182019.31518-1-stephen@networkplumber.org>",
        "References": "<20180725182019.31518-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "There is no need to call rte_exit and crash the application here;\nbetter to let the application handle the error itself.\n\nRemove the gratuitous profanity which would be visible if\nthe rte_exit was still there.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n lib/librte_eal/common/eal_common_proc.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex 9fcb9121908d..07b7579c565a 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -841,14 +841,12 @@ mp_request_async(const char *dst, struct rte_mp_msg *req,\n \n \tparam->user_reply.nb_sent++;\n \n-\tif (rte_eal_alarm_set(ts->tv_sec * 1000000 + ts->tv_nsec / 1000,\n-\t\t\t      async_reply_handle, pending_req) < 0) {\n+\tret = rte_eal_alarm_set(ts->tv_sec * 1000000 + ts->tv_nsec / 1000,\n+\t\t\t\tasync_reply_handle, pending_req);\n+\tif (ret < 0)\n \t\tRTE_LOG(ERR, EAL, \"Fail to set alarm for request %s:%s\\n\",\n \t\t\tdst, req->name);\n-\t\trte_panic(\"Fix the above shit to properly free all memory\\n\");\n-\t}\n-\n-\treturn 0;\n+\treturn ret;\n fail:\n \tfree(pending_req);\n \tfree(reply_msg);\n",
    "prefixes": [
        "3/4"
    ]
}