Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 43372,
    "url": "http://patches.dpdk.org/api/patches/43372/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180725171007.94198-3-jasvinder.singh@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180725171007.94198-3-jasvinder.singh@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180725171007.94198-3-jasvinder.singh@intel.com",
    "date": "2018-07-25T17:10:03",
    "name": "[2/6] net/softnic: add CLI command for tmgr shaper profile",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "e3b808310892487676dbd9af25ecb463ef56042d",
    "submitter": {
        "id": 285,
        "url": "http://patches.dpdk.org/api/people/285/?format=api",
        "name": "Jasvinder Singh",
        "email": "jasvinder.singh@intel.com"
    },
    "delegate": {
        "id": 10018,
        "url": "http://patches.dpdk.org/api/users/10018/?format=api",
        "username": "cristian_dumitrescu",
        "first_name": "Cristian",
        "last_name": "Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180725171007.94198-3-jasvinder.singh@intel.com/mbox/",
    "series": [
        {
            "id": 775,
            "url": "http://patches.dpdk.org/api/series/775/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=775",
            "date": "2018-07-25T17:10:01",
            "name": "net/softnic: expose tmgr through firmware",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/775/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/43372/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/43372/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D6E15378B;\n\tWed, 25 Jul 2018 19:10:16 +0200 (CEST)",
            "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 02CE91C01\n\tfor <dev@dpdk.org>; Wed, 25 Jul 2018 19:10:12 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jul 2018 10:10:12 -0700",
            "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.222.149])\n\tby orsmga003.jf.intel.com with ESMTP; 25 Jul 2018 10:10:10 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,401,1526367600\"; d=\"scan'208\";a=\"69856123\"",
        "From": "Jasvinder Singh <jasvinder.singh@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "cristian.dumitrescu@intel.com",
        "Date": "Wed, 25 Jul 2018 18:10:03 +0100",
        "Message-Id": "<20180725171007.94198-3-jasvinder.singh@intel.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20180725171007.94198-1-jasvinder.singh@intel.com>",
        "References": "<20180725171007.94198-1-jasvinder.singh@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 2/6] net/softnic: add CLI command for tmgr shaper\n\tprofile",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n\nAdd support to create Traffic Manager (TMGR) shaper profile\nthrough firmware CLI script.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n drivers/net/softnic/parser.c              |  18 ++++++\n drivers/net/softnic/parser.h              |   2 +\n drivers/net/softnic/rte_eth_softnic_cli.c | 100 +++++++++++++++++++++++++++++-\n 3 files changed, 118 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/softnic/parser.c b/drivers/net/softnic/parser.c\nindex 7087b87..a8688a2 100644\n--- a/drivers/net/softnic/parser.c\n+++ b/drivers/net/softnic/parser.c\n@@ -93,6 +93,24 @@ softnic_parser_read_arg_bool(const char *p)\n }\n \n int\n+softnic_parser_read_int32(int32_t *value, const char *p)\n+{\n+\tchar *next;\n+\tint32_t val;\n+\n+\tp = skip_white_spaces(p);\n+\tif (!isdigit(*p))\n+\t\treturn -EINVAL;\n+\n+\tval = strtol(p, &next, 10);\n+\tif (p == next)\n+\t\treturn -EINVAL;\n+\n+\t*value = val;\n+\treturn 0;\n+}\n+\n+int\n softnic_parser_read_uint64(uint64_t *value, const char *p)\n {\n \tchar *next;\ndiff --git a/drivers/net/softnic/parser.h b/drivers/net/softnic/parser.h\nindex 5ab4763..1ee3f82 100644\n--- a/drivers/net/softnic/parser.h\n+++ b/drivers/net/softnic/parser.h\n@@ -33,6 +33,8 @@ skip_digits(const char *src)\n \n int softnic_parser_read_arg_bool(const char *p);\n \n+int softnic_parser_read_int32(int32_t *value, const char *p);\n+\n int softnic_parser_read_uint64(uint64_t *value, const char *p);\n int softnic_parser_read_uint32(uint32_t *value, const char *p);\n int softnic_parser_read_uint16(uint16_t *value, const char *p);\ndiff --git a/drivers/net/softnic/rte_eth_softnic_cli.c b/drivers/net/softnic/rte_eth_softnic_cli.c\nindex 4a63b94..0a9ec01 100644\n--- a/drivers/net/softnic/rte_eth_softnic_cli.c\n+++ b/drivers/net/softnic/rte_eth_softnic_cli.c\n@@ -185,6 +185,93 @@ cmd_swq(struct pmd_internals *softnic,\n }\n \n /**\n+ * tmgr shaper profile\n+ *  id <profile_id>\n+ *  rate <tb_rate> size <tb_size>\n+ *  adj <packet_length_adjust>\n+ */\n+static void\n+cmd_tmgr_shaper_profile(struct pmd_internals *softnic,\n+\tchar **tokens,\n+\tuint32_t n_tokens,\n+\tchar *out,\n+\tsize_t out_size)\n+{\n+\tstruct rte_tm_shaper_params sp;\n+\tstruct rte_tm_error error;\n+\tuint32_t shaper_profile_id;\n+\tuint16_t port_id;\n+\tint status;\n+\n+\tmemset(&sp, 0, sizeof(struct rte_tm_shaper_params));\n+\n+\tif (n_tokens != 11) {\n+\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);\n+\t\treturn;\n+\t}\n+\n+\tif (strcmp(tokens[1], \"shaper\") != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"shaper\");\n+\t\treturn;\n+\t}\n+\n+\tif (strcmp(tokens[2], \"profile\") != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"profile\");\n+\t\treturn;\n+\t}\n+\n+\tif (strcmp(tokens[3], \"id\") != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"id\");\n+\t\treturn;\n+\t}\n+\n+\tif (softnic_parser_read_uint32(&shaper_profile_id, tokens[4]) != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"profile_id\");\n+\t\treturn;\n+\t}\n+\n+\tif (strcmp(tokens[5], \"rate\") != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"rate\");\n+\t\treturn;\n+\t}\n+\n+\tif (softnic_parser_read_uint64(&sp.peak.rate, tokens[6]) != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"tb_rate\");\n+\t\treturn;\n+\t}\n+\n+\tif (strcmp(tokens[7], \"size\") != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"size\");\n+\t\treturn;\n+\t}\n+\n+\tif (softnic_parser_read_uint64(&sp.peak.size, tokens[8]) != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"tb_size\");\n+\t\treturn;\n+\t}\n+\n+\tif (strcmp(tokens[9], \"adj\") != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"adj\");\n+\t\treturn;\n+\t}\n+\n+\tif (softnic_parser_read_int32(&sp.pkt_length_adjust, tokens[10]) != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"packet_length_adjust\");\n+\t\treturn;\n+\t}\n+\n+\tstatus = rte_eth_dev_get_port_by_name(softnic->params.name, &port_id);\n+\tif (status)\n+\t\treturn;\n+\n+\tstatus = rte_tm_shaper_profile_add(port_id, shaper_profile_id, &sp, &error);\n+\tif (status != 0) {\n+\t\tsnprintf(out, out_size, MSG_CMD_FAIL, tokens[0]);\n+\t\treturn;\n+\t}\n+}\n+\n+/**\n  * tmgr <tmgr_name>\n  */\n static void\n@@ -3983,8 +4070,17 @@ softnic_cli_process(char *in, char *out, size_t out_size, void *arg)\n \t}\n \n \tif (strcmp(tokens[0], \"tmgr\") == 0) {\n-\t\tcmd_tmgr(softnic, tokens, n_tokens, out, out_size);\n-\t\treturn;\n+\t\tif (n_tokens == 2) {\n+\t\t\tcmd_tmgr(softnic, tokens, n_tokens, out, out_size);\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tif (n_tokens >= 3 &&\n+\t\t\t(strcmp(tokens[1], \"shaper\") == 0) &&\n+\t\t\t(strcmp(tokens[2], \"profile\") == 0)) {\n+\t\t\tcmd_tmgr_shaper_profile(softnic, tokens, n_tokens, out, out_size);\n+\t\t\treturn;\n+\t\t}\n \t}\n \n \tif (strcmp(tokens[0], \"tap\") == 0) {\n",
    "prefixes": [
        "2/6"
    ]
}