Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/4336/?format=api
{ "id": 4336, "url": "http://patches.dpdk.org/api/patches/4336/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1429185127-33452-1-git-send-email-razamir22@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1429185127-33452-1-git-send-email-razamir22@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1429185127-33452-1-git-send-email-razamir22@gmail.com", "date": "2015-04-16T11:52:07", "name": "[dpdk-dev,v7] Restore support for virtio on FreeBSD", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "95fd72e9751094d19fc7b94b976ffd68cd3e01a8", "submitter": { "id": 184, "url": "http://patches.dpdk.org/api/people/184/?format=api", "name": "Raz Amir", "email": "razamir22@gmail.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1429185127-33452-1-git-send-email-razamir22@gmail.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/4336/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/4336/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5F3DEB6AB;\n\tThu, 16 Apr 2015 13:52:24 +0200 (CEST)", "from localhost.my.domain (84.95.210.61.forward.012.net.il\n\t[84.95.210.61]) by dpdk.org (Postfix) with ESMTP id 3BD38ADA2\n\tfor <dev@dpdk.org>; Thu, 16 Apr 2015 13:52:22 +0200 (CEST)", "from localhost.my.domain (localhost [127.0.0.1])\n\tby localhost.my.domain (8.14.9/8.14.9) with ESMTP id t3GBqIiZ033491\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Thu, 16 Apr 2015 14:52:18 +0300 (IDT)\n\t(envelope-from root@localhost.my.domain)", "(from root@localhost)\n\tby localhost.my.domain (8.14.9/8.14.9/Submit) id t3GBqGAx033490;\n\tThu, 16 Apr 2015 14:52:16 +0300 (IDT) (envelope-from root)" ], "From": "Raz Amir <razamir22@gmail.com>", "To": "dev@dpdk.org", "Date": "Thu, 16 Apr 2015 14:52:07 +0300", "Message-Id": "<1429185127-33452-1-git-send-email-razamir22@gmail.com>", "X-Mailer": "git-send-email 2.1.2", "In-Reply-To": "<1428450303-97954-1-git-send-email-razamir22@gmail.com>", "References": "<1428450303-97954-1-git-send-email-razamir22@gmail.com>", "Cc": "Raz Amir <razamir22@gmail.com>", "Subject": "[dpdk-dev] [PATCH v7] Restore support for virtio on FreeBSD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixes: 8a312224bcde (\"eal/bsd: fix fd leak\")\n\nClosing /dev/io fd causes SIGBUS in inb/outb instructions\nas the process loses the IOPL privileges once the fd is closed:\n(gdb) bt\n0 0x0000000000492f2c in outb (port=49170, data=0 '\\000')\nat /usr/include/machine/cpufunc.h:244\n1 0x0000000000492f7a in outb_p (data=0 '\\000', port=49170)\nat /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.h:211\n2 0x000000000049328d in vtpci_set_status (hw=0x80331f380, status=0 '\\000')\nat /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.c:130\n3 0x00000000004931fe in vtpci_reset (hw=0x80331f380)\nat /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_pci.c:108\n4 0x00000000004a175e in eth_virtio_dev_init (eth_dev=0x831b80 <rte_eth_devices>)\nat /dpdk/dpdk-2.0.0/lib/librte_pmd_virtio/virtio_ethdev.c:1150\n5 0x0000000000462c09 in rte_eth_dev_init (pci_drv=0x79d1a0 <rte_virtio_pmd>,\npci_dev=0x802417560) at /dpdk/dpdk-2.0.0/lib/librte_ether/rte_ethdev.c:326\n6 0x000000000046f03f in rte_eal_pci_probe_one_driver (dr=0x79d1a0 <rte_virtio_pmd>,\ndev=0x802417560) at /dpdk/dpdk-2.0.0/lib/librte_eal/bsdapp/eal/eal_pci.c:487\n7 0x0000000000475b06 in pci_probe_all_drivers (dev=0x802417560)\nat /dpdk/dpdk-2.0.0/lib/librte_eal/common/eal_common_pci.c:116\n8 0x0000000000475bb9 in rte_eal_pci_probe ()\nat /dpdk/dpdk-2.0.0/lib/librte_eal/common/eal_common_pci.c:246\n9 0x000000000046cd63 in rte_eal_init (argc=5, argv=0x7fffffffeaf0)\nat /dpdk/dpdk-2.0.0/lib/librte_eal/bsdapp/eal/eal.c:554\n10 0x0000000000404544 in main ()\n\nSigned-off-by: Raz Amir <razamir22@gmail.com>\n---\n lib/librte_eal/bsdapp/eal/eal.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c\nindex 871d5f4..43e8a47 100644\n--- a/lib/librte_eal/bsdapp/eal/eal.c\n+++ b/lib/librte_eal/bsdapp/eal/eal.c\n@@ -421,12 +421,12 @@ int rte_eal_has_hugepages(void)\n int\n rte_eal_iopl_init(void)\n {\n-\tint fd;\n+\tstatic int fd;\n \n \tfd = open(\"/dev/io\", O_RDWR);\n \tif (fd < 0)\n \t\treturn -1;\n-\tclose(fd);\n+\t/* keep fd open for iopl */\n \treturn 0;\n }\n \n", "prefixes": [ "dpdk-dev", "v7" ] }