Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/433/?format=api
{ "id": 433, "url": "http://patches.dpdk.org/api/patches/433/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1411375081-27986-3-git-send-email-david.marchand@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1411375081-27986-3-git-send-email-david.marchand@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1411375081-27986-3-git-send-email-david.marchand@6wind.com", "date": "2014-09-22T08:37:56", "name": "[dpdk-dev,2/7] eal: factorise unsupported option handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d57183ea8ed948a17920af025125a6b86383ecb7", "submitter": { "id": 3, "url": "http://patches.dpdk.org/api/people/3/?format=api", "name": "David Marchand", "email": "david.marchand@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1411375081-27986-3-git-send-email-david.marchand@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/433/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/433/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 172ADB3AC;\n\tMon, 22 Sep 2014 10:32:09 +0200 (CEST)", "from mail-wi0-f170.google.com (mail-wi0-f170.google.com\n\t[209.85.212.170]) by dpdk.org (Postfix) with ESMTP id EEFD5AFCA\n\tfor <dev@dpdk.org>; Mon, 22 Sep 2014 10:32:06 +0200 (CEST)", "by mail-wi0-f170.google.com with SMTP id fb4so2371436wid.3\n\tfor <dev@dpdk.org>; Mon, 22 Sep 2014 01:38:10 -0700 (PDT)", "from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tjs2sm11522334wjc.9.2014.09.22.01.38.08 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 22 Sep 2014 01:38:09 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=6VgVTaT3Xv45kXWrLAUBCuBXPHlPOWnKB+5H++pTG1U=;\n\tb=Kp98aUu0kIRg3tOpHJQuyiGjj5FQ/y9MDladtQJTKwy1VFbPoZiH22k+s08HkXNCFa\n\tSFDOvxArZwfsMwi3crNpPgBgHETW12EBpeV+xdBhqT9+csoLgDim85mVBlsbByuSHNWJ\n\tlw9EF/EP2raQysnyrsIlGl5thCvNjpZzlYMkBHnYuCR9QUgvEQn6fuevqSgfFMLK7ttJ\n\toRGZiOXc95BvJIDhc6ia/s7eIzAxVPUJ/CeYlSgL0a8qnjk7NuKq7yr+dZzHKuts1SN4\n\tSP8N8VXEUtw0UVJNrABC8qDNZc8LfPWjH5EN036ZI+vbaTm0Gb8WCxhWrcV96KqXz6gk\n\tWeZQ==", "X-Gm-Message-State": "ALoCoQnUfud1oyVKfVFpMEBMg5GHibJzqfi65R6mYRJJlXNXuHBmu2htCWxdxZDSPBbfnK41nm6l", "X-Received": "by 10.180.72.211 with SMTP id f19mr7564457wiv.39.1411375090022; \n\tMon, 22 Sep 2014 01:38:10 -0700 (PDT)", "From": "David Marchand <david.marchand@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 22 Sep 2014 10:37:56 +0200", "Message-Id": "<1411375081-27986-3-git-send-email-david.marchand@6wind.com>", "X-Mailer": "git-send-email 1.7.10.4", "In-Reply-To": "<1411375081-27986-1-git-send-email-david.marchand@6wind.com>", "References": "<1411375081-27986-1-git-send-email-david.marchand@6wind.com>", "Subject": "[dpdk-dev] [PATCH 2/7] eal: factorise unsupported option handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/bsdapp/eal/eal.c | 21 ++++++---------------\n lib/librte_eal/linuxapp/eal/eal.c | 6 ++++++\n 2 files changed, 12 insertions(+), 15 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c\nindex ffdc441..7e9f3aa 100644\n--- a/lib/librte_eal/bsdapp/eal/eal.c\n+++ b/lib/librte_eal/bsdapp/eal/eal.c\n@@ -626,24 +626,9 @@ eal_parse_args(int argc, char **argv)\n \t\t\telse if (!strcmp(lgopts[option_index].name, OPT_NO_SHCONF)) {\n \t\t\t\tinternal_config.no_shconf = 1;\n \t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_HUGE_DIR)) {\n-\t\t\t\tRTE_LOG(ERR, EAL, \"Option \"OPT_HUGE_DIR\" is not supported on\"\n-\t\t\t\t\t\t\"FreeBSD\\n\");\n-\t\t\t\treturn -1;\n-\t\t\t}\n \t\t\telse if (!strcmp(lgopts[option_index].name, OPT_PROC_TYPE)) {\n \t\t\t\tinternal_config.process_type = eal_parse_proc_type(optarg);\n \t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_FILE_PREFIX)) {\n-\t\t\t\tRTE_LOG(ERR, EAL, \"Option \"OPT_FILE_PREFIX\" is not supported on\"\n-\t\t\t\t\t\t\"FreeBSD\\n\");\n-\t\t\t\treturn -1;\n-\t\t\t}\n-\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_SOCKET_MEM)) {\n-\t\t\t\tRTE_LOG(ERR, EAL, \"Option \"OPT_SOCKET_MEM\" is not supported on\"\n-\t\t\t\t\t\t\"FreeBSD\\n\");\n-\t\t\t\treturn -1;\n-\t\t\t}\n \t\t\telse if (!strcmp(lgopts[option_index].name, OPT_PCI_BLACKLIST)) {\n \t\t\t\tif (rte_eal_devargs_add(RTE_DEVTYPE_BLACKLISTED_PCI,\n \t\t\t\t\t\toptarg) < 0) {\n@@ -684,6 +669,12 @@ eal_parse_args(int argc, char **argv)\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n \t\t\t\tinternal_config.log_level = log;\n+\t\t\t} else {\n+\t\t\t\tRTE_LOG(ERR, EAL, \"Option %s is not supported \"\n+\t\t\t\t\t\"on FreeBSD\\n\",\n+\t\t\t\t\tlgopts[option_index].name);\n+\t\t\t\teal_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n \t\t\tbreak;\n \ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 633e3b8..bf63744 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -938,6 +938,12 @@ eal_parse_args(int argc, char **argv)\n \t\t\t}\n \t\t\telse if (!strcmp(lgopts[option_index].name, OPT_CREATE_UIO_DEV)) {\n \t\t\t\tinternal_config.create_uio_dev = 1;\n+\t\t\t} else {\n+\t\t\t\tRTE_LOG(ERR, EAL, \"Option %s is not supported \"\n+\t\t\t\t\t\"on Linux\\n\",\n+\t\t\t\t\tlgopts[option_index].name);\n+\t\t\t\teal_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n \t\t\tbreak;\n \n", "prefixes": [ "dpdk-dev", "2/7" ] }