Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43213/?format=api
{ "id": 43213, "url": "http://patches.dpdk.org/api/patches/43213/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180719083959.41480-3-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180719083959.41480-3-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180719083959.41480-3-pablo.de.lara.guarch@intel.com", "date": "2018-07-19T08:39:56", "name": "[v2,2/5] examples/l2fwd-crypto: skip device not supporting operation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "77528c349e11f0107b3e911aa28a1923b042a91c", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180719083959.41480-3-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 677, "url": "http://patches.dpdk.org/api/series/677/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=677", "date": "2018-07-19T08:39:54", "name": "L2fwd-crypto fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/677/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43213/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43213/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1D2485F16;\n\tThu, 19 Jul 2018 18:47:07 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id E878F5B14;\n\tThu, 19 Jul 2018 18:46:59 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Jul 2018 09:46:57 -0700", "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby fmsmga006.fm.intel.com with ESMTP; 19 Jul 2018 09:46:11 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,375,1526367600\"; d=\"scan'208\";a=\"247109923\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com,\n\tfiona.trahe@intel.com", "Cc": "dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 19 Jul 2018 09:39:56 +0100", "Message-Id": "<20180719083959.41480-3-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.14.4", "In-Reply-To": "<20180719083959.41480-1-pablo.de.lara.guarch@intel.com>", "References": "<20180717103815.26841-1-pablo.de.lara.guarch@intel.com>\n\t<20180719083959.41480-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/5] examples/l2fwd-crypto: skip device not\n\tsupporting operation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When a crypto device does not support an algorithm, it is skipped\nand not used. However, when it does support it, but not the rest\nof the parameters (IV, key, AAD sizes...), application stops.\nInstead, the device should be skipped and the search of a suitable\ndevice should continue.\n\nFixes: a061e50a0d97 (\"examples/l2fwd-crypto: fix ambiguous input key size\")\nCc: stable@dpdk.org\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n examples/l2fwd-crypto/main.c | 26 +++++++++++++-------------\n 1 file changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\nindex dc97a9b40..e334b9bd0 100644\n--- a/examples/l2fwd-crypto/main.c\n+++ b/examples/l2fwd-crypto/main.c\n@@ -2070,7 +2070,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\toptions->aead_iv_param,\n \t\t\t\t\toptions->aead_iv_random_size,\n \t\t\t\t\t&options->aead_iv.length) < 0)\n-\t\t\t\treturn -1;\n+\t\t\t\tcontinue;\n \n \t\t\t/*\n \t\t\t * Check if length of provided AEAD key is supported\n@@ -2084,7 +2084,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\t\tcap->sym.aead.key_size.increment)\n \t\t\t\t\t\t\t!= 0) {\n \t\t\t\t\tprintf(\"Unsupported aead key length\\n\");\n-\t\t\t\t\treturn -1;\n+\t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t/*\n \t\t\t * Check if length of the aead key to be randomly generated\n@@ -2097,7 +2097,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\t\tcap->sym.aead.key_size.increment)\n \t\t\t\t\t\t\t!= 0) {\n \t\t\t\t\tprintf(\"Unsupported aead key length\\n\");\n-\t\t\t\t\treturn -1;\n+\t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t\toptions->aead_xform.aead.key.length =\n \t\t\t\t\t\t\toptions->aead_key_random_size;\n@@ -2122,7 +2122,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\t\tcap->sym.aead.aad_size.increment)\n \t\t\t\t\t\t\t!= 0) {\n \t\t\t\t\tprintf(\"Unsupported AAD length\\n\");\n-\t\t\t\t\treturn -1;\n+\t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t/*\n \t\t\t * Check if length of AAD to be randomly generated\n@@ -2135,7 +2135,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\t\tcap->sym.aead.aad_size.increment)\n \t\t\t\t\t\t\t!= 0) {\n \t\t\t\t\tprintf(\"Unsupported AAD length\\n\");\n-\t\t\t\t\treturn -1;\n+\t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t\toptions->aad.length = options->aad_random_size;\n \t\t\t/* No size provided, use minimum size. */\n@@ -2153,7 +2153,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\t\tcap->sym.aead.digest_size.increment)\n \t\t\t\t\t\t\t!= 0) {\n \t\t\t\t\tprintf(\"Unsupported digest length\\n\");\n-\t\t\t\t\treturn -1;\n+\t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t\toptions->aead_xform.aead.digest_length =\n \t\t\t\t\t\t\toptions->digest_size;\n@@ -2179,7 +2179,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\toptions->cipher_iv_param,\n \t\t\t\t\toptions->cipher_iv_random_size,\n \t\t\t\t\t&options->cipher_iv.length) < 0)\n-\t\t\t\treturn -1;\n+\t\t\t\tcontinue;\n \n \t\t\t/*\n \t\t\t * Check if length of provided cipher key is supported\n@@ -2193,7 +2193,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\t\tcap->sym.cipher.key_size.increment)\n \t\t\t\t\t\t\t!= 0) {\n \t\t\t\t\tprintf(\"Unsupported cipher key length\\n\");\n-\t\t\t\t\treturn -1;\n+\t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t/*\n \t\t\t * Check if length of the cipher key to be randomly generated\n@@ -2206,7 +2206,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\t\tcap->sym.cipher.key_size.increment)\n \t\t\t\t\t\t\t!= 0) {\n \t\t\t\t\tprintf(\"Unsupported cipher key length\\n\");\n-\t\t\t\t\treturn -1;\n+\t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t\toptions->cipher_xform.cipher.key.length =\n \t\t\t\t\t\t\toptions->ckey_random_size;\n@@ -2236,7 +2236,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\toptions->auth_iv_param,\n \t\t\t\t\toptions->auth_iv_random_size,\n \t\t\t\t\t&options->auth_iv.length) < 0)\n-\t\t\t\treturn -1;\n+\t\t\t\tcontinue;\n \t\t\t/*\n \t\t\t * Check if length of provided auth key is supported\n \t\t\t * by the algorithm chosen.\n@@ -2249,7 +2249,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\t\tcap->sym.auth.key_size.increment)\n \t\t\t\t\t\t\t!= 0) {\n \t\t\t\t\tprintf(\"Unsupported auth key length\\n\");\n-\t\t\t\t\treturn -1;\n+\t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t/*\n \t\t\t * Check if length of the auth key to be randomly generated\n@@ -2262,7 +2262,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\t\tcap->sym.auth.key_size.increment)\n \t\t\t\t\t\t\t!= 0) {\n \t\t\t\t\tprintf(\"Unsupported auth key length\\n\");\n-\t\t\t\t\treturn -1;\n+\t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t\toptions->auth_xform.auth.key.length =\n \t\t\t\t\t\t\toptions->akey_random_size;\n@@ -2284,7 +2284,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\t\t\t\tcap->sym.auth.digest_size.increment)\n \t\t\t\t\t\t\t!= 0) {\n \t\t\t\t\tprintf(\"Unsupported digest length\\n\");\n-\t\t\t\t\treturn -1;\n+\t\t\t\t\tcontinue;\n \t\t\t\t}\n \t\t\t\toptions->auth_xform.auth.digest_length =\n \t\t\t\t\t\t\toptions->digest_size;\n", "prefixes": [ "v2", "2/5" ] }