Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43210/?format=api
http://patches.dpdk.org/api/patches/43210/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180719083959.41480-2-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180719083959.41480-2-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180719083959.41480-2-pablo.de.lara.guarch@intel.com", "date": "2018-07-19T08:39:55", "name": "[v2,1/5] examples/l2fwd-crypto: check return value on IV size check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6bcc23d7bce3023e909d785cd0eb2171e133ba2c", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180719083959.41480-2-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 677, "url": "http://patches.dpdk.org/api/series/677/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=677", "date": "2018-07-19T08:39:54", "name": "L2fwd-crypto fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/677/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43210/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/43210/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A6C7F5B16;\n\tThu, 19 Jul 2018 18:47:00 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id A72A85B12;\n\tThu, 19 Jul 2018 18:46:58 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Jul 2018 09:46:57 -0700", "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby fmsmga006.fm.intel.com with ESMTP; 19 Jul 2018 09:46:09 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,375,1526367600\"; d=\"scan'208\";a=\"247109921\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com,\n\tfiona.trahe@intel.com", "Cc": "dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 19 Jul 2018 09:39:55 +0100", "Message-Id": "<20180719083959.41480-2-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.14.4", "In-Reply-To": "<20180719083959.41480-1-pablo.de.lara.guarch@intel.com>", "References": "<20180717103815.26841-1-pablo.de.lara.guarch@intel.com>\n\t<20180719083959.41480-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/5] examples/l2fwd-crypto: check return value\n\ton IV size check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "IV size parameter is checked through a function,\nbut its return value was not checked.\n\nFixes: 0fbd75a99fc9 (\"cryptodev: move IV parameters to session\")\nFixes: acf8616901b5 (\"cryptodev: add auth IV\")\nFixes: 2661f4fbe93d (\"examples/l2fwd-crypto: add AEAD parameters\")\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nCc: stable@dpdk.org\n---\n examples/l2fwd-crypto/main.c | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\nindex 9ac06a697..dc97a9b40 100644\n--- a/examples/l2fwd-crypto/main.c\n+++ b/examples/l2fwd-crypto/main.c\n@@ -2066,10 +2066,11 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \n \t\t\toptions->block_size = cap->sym.aead.block_size;\n \n-\t\t\tcheck_iv_param(&cap->sym.aead.iv_size,\n+\t\t\tif (check_iv_param(&cap->sym.aead.iv_size,\n \t\t\t\t\toptions->aead_iv_param,\n \t\t\t\t\toptions->aead_iv_random_size,\n-\t\t\t\t\t&options->aead_iv.length);\n+\t\t\t\t\t&options->aead_iv.length) < 0)\n+\t\t\t\treturn -1;\n \n \t\t\t/*\n \t\t\t * Check if length of provided AEAD key is supported\n@@ -2174,10 +2175,11 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \n \t\t\toptions->block_size = cap->sym.cipher.block_size;\n \n-\t\t\tcheck_iv_param(&cap->sym.cipher.iv_size,\n+\t\t\tif (check_iv_param(&cap->sym.cipher.iv_size,\n \t\t\t\t\toptions->cipher_iv_param,\n \t\t\t\t\toptions->cipher_iv_random_size,\n-\t\t\t\t\t&options->cipher_iv.length);\n+\t\t\t\t\t&options->cipher_iv.length) < 0)\n+\t\t\t\treturn -1;\n \n \t\t\t/*\n \t\t\t * Check if length of provided cipher key is supported\n@@ -2230,10 +2232,11 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,\n \t\t\tif (cap == NULL)\n \t\t\t\tcontinue;\n \n-\t\t\tcheck_iv_param(&cap->sym.auth.iv_size,\n+\t\t\tif (check_iv_param(&cap->sym.auth.iv_size,\n \t\t\t\t\toptions->auth_iv_param,\n \t\t\t\t\toptions->auth_iv_random_size,\n-\t\t\t\t\t&options->auth_iv.length);\n+\t\t\t\t\t&options->auth_iv.length) < 0)\n+\t\t\t\treturn -1;\n \t\t\t/*\n \t\t\t * Check if length of provided auth key is supported\n \t\t\t * by the algorithm chosen.\n", "prefixes": [ "v2", "1/5" ] }{ "id": 43210, "url": "