List comments

GET /api/patches/432/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 898,
        "web_url": "http://patches.dpdk.org/comment/898/",
        "msgid": "<20140922122211.GB25406@hmsreliant.think-freely.org>",
        "date": "2014-09-22T12:22:11",
        "subject": "Re: [dpdk-dev] [PATCH 1/7] eal: remove unused --use-device option",
        "submitter": {
            "id": 32,
            "url": "http://patches.dpdk.org/api/people/32/",
            "name": "Neil Horman",
            "email": "nhorman@tuxdriver.com"
        },
        "content": "On Mon, Sep 22, 2014 at 10:37:55AM +0200, David Marchand wrote:\n> Following commit cac6d08c8bde2fdb57806c49038187cdb54219a8 and\n> 4bf3fe634a4d9dfce90c4167f3a47d0e2ddf1e64, this option is not available anymore.\n> \n> Signed-off-by: David Marchand <david.marchand@6wind.com>\n> ---\n>  lib/librte_eal/bsdapp/eal/eal.c   |    7 -------\n>  lib/librte_eal/linuxapp/eal/eal.c |    7 -------\n>  2 files changed, 14 deletions(-)\n> \n> diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c\n> index 2f84742..ffdc441 100644\n> --- a/lib/librte_eal/bsdapp/eal/eal.c\n> +++ b/lib/librte_eal/bsdapp/eal/eal.c\n> @@ -89,7 +89,6 @@\n>  #define OPT_NO_HUGE     \"no-huge\"\n>  #define OPT_FILE_PREFIX \"file-prefix\"\n>  #define OPT_SOCKET_MEM  \"socket-mem\"\n> -#define OPT_USE_DEVICE \"use-device\"\n>  #define OPT_PCI_WHITELIST \"pci-whitelist\"\n>  #define OPT_PCI_BLACKLIST \"pci-blacklist\"\n>  #define OPT_VDEV        \"vdev\"\n> @@ -645,12 +644,6 @@ eal_parse_args(int argc, char **argv)\n>  \t\t\t\t\t\t\"FreeBSD\\n\");\n>  \t\t\t\treturn -1;\n>  \t\t\t}\n> -\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_USE_DEVICE)) {\n> -\t\t\t\tprintf(\"The --use-device option is deprecated, please use\\n\"\n> -\t\t\t\t\t\"--whitelist or --vdev instead.\\n\");\n> -\t\t\t\teal_usage(prgname);\n> -\t\t\t\treturn -1;\n> -\t\t\t}\n>  \t\t\telse if (!strcmp(lgopts[option_index].name, OPT_PCI_BLACKLIST)) {\n>  \t\t\t\tif (rte_eal_devargs_add(RTE_DEVTYPE_BLACKLISTED_PCI,\n>  \t\t\t\t\t\toptarg) < 0) {\n> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\n> index 38cace6..633e3b8 100644\n> --- a/lib/librte_eal/linuxapp/eal/eal.c\n> +++ b/lib/librte_eal/linuxapp/eal/eal.c\n> @@ -92,7 +92,6 @@\n>  #define OPT_NO_HUGE     \"no-huge\"\n>  #define OPT_FILE_PREFIX \"file-prefix\"\n>  #define OPT_SOCKET_MEM  \"socket-mem\"\n> -#define OPT_USE_DEVICE  \"use-device\"\n>  #define OPT_PCI_WHITELIST \"pci-whitelist\"\n>  #define OPT_PCI_BLACKLIST \"pci-blacklist\"\n>  #define OPT_VDEV        \"vdev\"\n> @@ -880,12 +879,6 @@ eal_parse_args(int argc, char **argv)\n>  \t\t\t\t\treturn -1;\n>  \t\t\t\t}\n>  \t\t\t}\n> -\t\t\telse if (!strcmp(lgopts[option_index].name, OPT_USE_DEVICE)) {\n> -\t\t\t\tprintf(\"The --use-device option is deprecated, please use\\n\"\n> -\t\t\t\t\t\"--whitelist or --vdev instead.\\n\");\n> -\t\t\t\teal_usage(prgname);\n> -\t\t\t\treturn -1;\n> -\t\t\t}\n>  \t\t\telse if (!strcmp(lgopts[option_index].name, OPT_PCI_BLACKLIST)) {\n>  \t\t\t\tif (rte_eal_devargs_add(RTE_DEVTYPE_BLACKLISTED_PCI,\n>  \t\t\t\t\t\toptarg) < 0) {\n> -- \n> 1.7.10.4\n> \n> \n\njust a note here - This usage is great reflection of deprecation policy, we\ndeprecated this back in the 1.6 time frame, left it around for the 1.7 release,\nand remove it for the 1.8 release.  I'd love to add some deprecation\nfunctionality to the rte_compat stuff in my patch series on the list so that we\ncan better announe the deprecation of features/flags/API's in a more general\nfashion.\n\nNeil",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<1411375081-27986-1-git-send-email-david.marchand@6wind.com>\n\t<1411375081-27986-2-git-send-email-david.marchand@6wind.com>",
            "X-Mailman-Version": "2.1.15",
            "From": "Neil Horman <nhorman@tuxdriver.com>",
            "User-Agent": "Mutt/1.5.23 (2014-03-12)",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Type": "text/plain; charset=us-ascii",
            "X-BeenThere": "dev@dpdk.org",
            "X-Original-To": "patchwork@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 57388B3AB;\n\tMon, 22 Sep 2014 14:16:19 +0200 (CEST)",
                "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id 7FE1EB39F\n\tfor <dev@dpdk.org>; Mon, 22 Sep 2014 14:16:17 +0200 (CEST)",
                "from [2001:470:8:a08:18c5:c64e:4bf:67a] (helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1XW2dA-0002v7-Tk; Mon, 22 Sep 2014 08:22:18 -0400"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 1/7] eal: remove unused --use-device option",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Message-ID": "<20140922122211.GB25406@hmsreliant.think-freely.org>",
            "Precedence": "list",
            "Date": "Mon, 22 Sep 2014 08:22:11 -0400",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "Errors-To": "dev-bounces@dpdk.org",
            "X-Spam-Score": "-2.9 (--)",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-Spam-Status": "No",
            "Cc": "dev@dpdk.org",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Delivered-To": "patchwork@dpdk.org",
            "In-Reply-To": "<1411375081-27986-2-git-send-email-david.marchand@6wind.com>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "To": "David Marchand <david.marchand@6wind.com>",
            "Content-Disposition": "inline"
        }
    },
    {
        "id": 901,
        "web_url": "http://patches.dpdk.org/comment/901/",
        "msgid": "<CALwxeUuVkKseDRrEUaqxprgY-v47DyimpGnMTgs10yVUzpLfqA@mail.gmail.com>",
        "date": "2014-09-22T13:49:38",
        "subject": "Re: [dpdk-dev] [PATCH 1/7] eal: remove unused --use-device option",
        "submitter": {
            "id": 3,
            "url": "http://patches.dpdk.org/api/people/3/",
            "name": "David Marchand",
            "email": "david.marchand@6wind.com"
        },
        "content": "On Mon, Sep 22, 2014 at 2:22 PM, Neil Horman <nhorman@tuxdriver.com> wrote:\n\n>\n> just a note here - This usage is great reflection of deprecation policy, we\n> deprecated this back in the 1.6 time frame, left it around for the 1.7\n> release,\n> and remove it for the 1.8 release.  I'd love to add some deprecation\n> functionality to the rte_compat stuff in my patch series on the list so\n> that we\n> can better announe the deprecation of features/flags/API's in a more\n> general\n> fashion.\n>\n\nMy note here as well.\n--use-device was broken anyway, since the option had disappeared from\ngetopt() call.\nSo I suppose the deprecation mechanism was not that necessary since no one\ncomplained.",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "MIME-Version": "1.0",
            "X-Mailman-Version": "2.1.15",
            "From": "David Marchand <david.marchand@6wind.com>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-BeenThere": "dev@dpdk.org",
            "Content-Type": "text/plain; charset=UTF-8",
            "References": "<1411375081-27986-1-git-send-email-david.marchand@6wind.com>\n\t<1411375081-27986-2-git-send-email-david.marchand@6wind.com>\n\t<20140922122211.GB25406@hmsreliant.think-freely.org>",
            "X-Original-To": "patchwork@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:mime-version:in-reply-to:references:date\n\t:message-id:subject:from:to:cc:content-type;\n\tbh=jSR+gEiO/apIMYqFx+rVMdo+sHaaY3zlWhEnbUddCkc=;\n\tb=MrnxwhvMlVmBQJ7vawfVnlQmbKcm5kxZT+uM+aXxvLILP7TS4ZxT+0mDl5QN1SU66x\n\tSAD8rfsLr5aPMTB6y/elAdY8wtS6Les5spT2F/6wbhq7xPGWRIe3x57VkD/y7lWMpIIJ\n\t2ryZtovWGXalOnyvyHn6D29/Hiseji06kyrz97xSCCFPwYjlG+a2Pvi3qFi9JX2lbC9s\n\t+0FI1UQgzEZitfhPg61fEW+tGOAOG2XWtlhmEELVymYygnOLsaC+qA7qV3fRHi6Gf0D9\n\tVoxziBcP1llN8GW12YABUR6089e3i5KvWI9xZEffXWyfEHV4ZrdnWjV8dOAjcSR1XXLO\n\t2RRw==",
            "Received": [
                "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 435902E81;\n\tMon, 22 Sep 2014 15:43:36 +0200 (CEST)",
                "from mail-oi0-f49.google.com (mail-oi0-f49.google.com\n\t[209.85.218.49]) by dpdk.org (Postfix) with ESMTP id 07CC61F5\n\tfor <dev@dpdk.org>; Mon, 22 Sep 2014 15:43:34 +0200 (CEST)",
                "by mail-oi0-f49.google.com with SMTP id x69so3720601oia.22\n\tfor <dev@dpdk.org>; Mon, 22 Sep 2014 06:49:38 -0700 (PDT)",
                "by 10.202.57.139 with HTTP; Mon, 22 Sep 2014 06:49:38 -0700 (PDT)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 1/7] eal: remove unused --use-device option",
            "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15",
            "X-Received": "by 10.60.60.131 with SMTP id h3mr19498803oer.17.1411393778373;\n\tMon, 22 Sep 2014 06:49:38 -0700 (PDT)",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Message-ID": "<CALwxeUuVkKseDRrEUaqxprgY-v47DyimpGnMTgs10yVUzpLfqA@mail.gmail.com>",
            "Precedence": "list",
            "X-Gm-Message-State": "ALoCoQmraYqPjHSLJy2IOG1uxGh16EelvdeX/d0aTzSkb0G9irkxcmJQzrhmXqh3QQ7Cy1QmmkOo",
            "Date": "Mon, 22 Sep 2014 15:49:38 +0200",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Delivered-To": "patchwork@dpdk.org",
            "In-Reply-To": "<20140922122211.GB25406@hmsreliant.think-freely.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "To": "Neil Horman <nhorman@tuxdriver.com>"
        }
    }
]