Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43089/?format=api
{ "id": 43089, "url": "http://patches.dpdk.org/api/patches/43089/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1531648575-7568-2-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1531648575-7568-2-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1531648575-7568-2-git-send-email-arybchenko@solarflare.com", "date": "2018-07-15T09:56:13", "name": "[1/3] net/sfc: move Rx checksum offload check to device level", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5436e07fa49d807c42692e7769f02fd55ea73996", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1531648575-7568-2-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 584, "url": "http://patches.dpdk.org/api/series/584/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=584", "date": "2018-07-15T09:56:12", "name": "net/sfc: improve Rx checksumming support", "version": 1, "mbox": "http://patches.dpdk.org/series/584/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43089/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/43089/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 74B7A3257;\n\tSun, 15 Jul 2018 11:56:34 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 209462BE2;\n\tSun, 15 Jul 2018 11:56:30 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id BD1174C0059; Sun, 15 Jul 2018 09:56:24 +0000 (UTC)", "from sfocexch01r.SolarFlarecom.com (10.20.40.34) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Sun, 15 Jul 2018 02:56:22 -0700", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tsfocexch01r.SolarFlarecom.com (10.20.40.34) with Microsoft SMTP\n\tServer (TLS) id 15.0.1044.25; Sun, 15 Jul 2018 02:56:20 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Sun, 15 Jul 2018 02:56:20 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw6F9uJP2015783; Sun, 15 Jul 2018 10:56:19 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t182D81657BF; Sun, 15 Jul 2018 10:56:19 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "<stable@dpdk.org>", "Date": "Sun, 15 Jul 2018 10:56:13 +0100", "Message-ID": "<1531648575-7568-2-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1531648575-7568-1-git-send-email-arybchenko@solarflare.com>", "References": "<1531648575-7568-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MDID": "1531648585-Xu71xX_QnUwm", "Subject": "[dpdk-dev] [PATCH 1/3] net/sfc: move Rx checksum offload check to\n\tdevice level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rx checksum offloads are on device level and should be checked and\nenforced on device level.\n\nAvoid logging of Rx checksum offloads enforced for each Rx queue.\n\nFixes: ff6a1197c3b1 (\"net/sfc: convert to new Rx offload API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_rx.c | 26 +++++++++++++++-----------\n 1 file changed, 15 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex 158c8e94b..6ff922770 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -817,10 +817,8 @@ sfc_rx_get_queue_offload_caps(struct sfc_adapter *sa)\n static int\n sfc_rx_qcheck_conf(struct sfc_adapter *sa, unsigned int rxq_max_fill_level,\n \t\t const struct rte_eth_rxconf *rx_conf,\n-\t\t uint64_t offloads)\n+\t\t __rte_unused uint64_t offloads)\n {\n-\tuint64_t offloads_supported = sfc_rx_get_dev_offload_caps(sa) |\n-\t\t\t\t sfc_rx_get_queue_offload_caps(sa);\n \tint rc = 0;\n \n \tif (rx_conf->rx_thresh.pthresh != 0 ||\n@@ -842,14 +840,6 @@ sfc_rx_qcheck_conf(struct sfc_adapter *sa, unsigned int rxq_max_fill_level,\n \t\trc = EINVAL;\n \t}\n \n-\tif ((offloads & DEV_RX_OFFLOAD_CHECKSUM) !=\n-\t DEV_RX_OFFLOAD_CHECKSUM)\n-\t\tsfc_warn(sa, \"Rx checksum offloads cannot be disabled - always on (IPv4/TCP/UDP)\");\n-\n-\tif ((offloads_supported & DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM) &&\n-\t (~offloads & DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM))\n-\t\tsfc_warn(sa, \"Rx outer IPv4 checksum offload cannot be disabled - always on\");\n-\n \treturn rc;\n }\n \n@@ -1424,6 +1414,8 @@ sfc_rx_qinit_info(struct sfc_adapter *sa, unsigned int sw_index)\n static int\n sfc_rx_check_mode(struct sfc_adapter *sa, struct rte_eth_rxmode *rxmode)\n {\n+\tuint64_t offloads_supported = sfc_rx_get_dev_offload_caps(sa) |\n+\t\t\t\t sfc_rx_get_queue_offload_caps(sa);\n \tstruct sfc_rss *rss = &sa->rss;\n \tint rc = 0;\n \n@@ -1451,6 +1443,18 @@ sfc_rx_check_mode(struct sfc_adapter *sa, struct rte_eth_rxmode *rxmode)\n \t\trxmode->offloads |= DEV_RX_OFFLOAD_CRC_STRIP;\n \t}\n \n+\tif ((rxmode->offloads & DEV_RX_OFFLOAD_CHECKSUM) !=\n+\t DEV_RX_OFFLOAD_CHECKSUM) {\n+\t\tsfc_warn(sa, \"Rx checksum offloads cannot be disabled - always on (IPv4/TCP/UDP)\");\n+\t\trxmode->offloads |= DEV_RX_OFFLOAD_CHECKSUM;\n+\t}\n+\n+\tif ((offloads_supported & DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM) &&\n+\t (~rxmode->offloads & DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM)) {\n+\t\tsfc_warn(sa, \"Rx outer IPv4 checksum offload cannot be disabled - always on\");\n+\t\trxmode->offloads |= DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM;\n+\t}\n+\n \treturn rc;\n }\n \n", "prefixes": [ "1/3" ] }