Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43087/?format=api
{ "id": 43087, "url": "http://patches.dpdk.org/api/patches/43087/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1531648575-7568-4-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1531648575-7568-4-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1531648575-7568-4-git-send-email-arybchenko@solarflare.com", "date": "2018-07-15T09:56:15", "name": "[3/3] net/sfc: prepare to support Rx datapath without checksum", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "be98f8a09e527ea5c2b99334a1394487c0b3e1d5", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1531648575-7568-4-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 584, "url": "http://patches.dpdk.org/api/series/584/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=584", "date": "2018-07-15T09:56:12", "name": "net/sfc: improve Rx checksumming support", "version": 1, "mbox": "http://patches.dpdk.org/series/584/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/43087/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/43087/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 364AA2C15;\n\tSun, 15 Jul 2018 11:56:30 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id D44652BF5\n\tfor <dev@dpdk.org>; Sun, 15 Jul 2018 11:56:27 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\tDAD5E4C0059 for <dev@dpdk.org>; Sun, 15 Jul 2018 09:56:26 +0000 (UTC)", "from sfocexch01r.SolarFlarecom.com (10.20.40.34) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Sun, 15 Jul 2018 02:56:24 -0700", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tsfocexch01r.SolarFlarecom.com (10.20.40.34) with Microsoft SMTP\n\tServer (TLS) id 15.0.1044.25; Sun, 15 Jul 2018 02:56:20 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Sun, 15 Jul 2018 02:56:20 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw6F9uJRj015789 for <dev@dpdk.org>; Sun, 15 Jul 2018 10:56:19 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t36E401657BE\n\tfor <dev@dpdk.org>; Sun, 15 Jul 2018 10:56:19 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Sun, 15 Jul 2018 10:56:15 +0100", "Message-ID": "<1531648575-7568-4-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1531648575-7568-1-git-send-email-arybchenko@solarflare.com>", "References": "<1531648575-7568-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MDID": "1531648587-h6B7NnL37NTu", "Subject": "[dpdk-dev] [PATCH 3/3] net/sfc: prepare to support Rx datapath\n\twithout checksum", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_dp_rx.h | 1 +\n drivers/net/sfc/sfc_ef10_essb_rx.c | 3 ++-\n drivers/net/sfc/sfc_ef10_rx.c | 3 ++-\n drivers/net/sfc/sfc_rx.c | 19 ++++++++++++++-----\n 4 files changed, 19 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_dp_rx.h b/drivers/net/sfc/sfc_dp_rx.h\nindex 83faad160..ce96e83f6 100644\n--- a/drivers/net/sfc/sfc_dp_rx.h\n+++ b/drivers/net/sfc/sfc_dp_rx.h\n@@ -195,6 +195,7 @@ struct sfc_dp_rx {\n #define SFC_DP_RX_FEAT_TUNNELS\t\t\t0x4\n #define SFC_DP_RX_FEAT_FLOW_FLAG\t\t0x8\n #define SFC_DP_RX_FEAT_FLOW_MARK\t\t0x10\n+#define SFC_DP_RX_FEAT_CHECKSUM\t\t\t0x20\n \tsfc_dp_rx_get_dev_info_t\t\t*get_dev_info;\n \tsfc_dp_rx_pool_ops_supported_t\t\t*pool_ops_supported;\n \tsfc_dp_rx_qsize_up_rings_t\t\t*qsize_up_rings;\ndiff --git a/drivers/net/sfc/sfc_ef10_essb_rx.c b/drivers/net/sfc/sfc_ef10_essb_rx.c\nindex 3e0c7fd94..81c8f7fbd 100644\n--- a/drivers/net/sfc/sfc_ef10_essb_rx.c\n+++ b/drivers/net/sfc/sfc_ef10_essb_rx.c\n@@ -705,7 +705,8 @@ struct sfc_dp_rx sfc_ef10_essb_rx = {\n \t\t\t\t SFC_DP_HW_FW_CAP_RX_ES_SUPER_BUFFER,\n \t},\n \t.features\t\t= SFC_DP_RX_FEAT_FLOW_FLAG |\n-\t\t\t\t SFC_DP_RX_FEAT_FLOW_MARK,\n+\t\t\t\t SFC_DP_RX_FEAT_FLOW_MARK |\n+\t\t\t\t SFC_DP_RX_FEAT_CHECKSUM,\n \t.get_dev_info\t\t= sfc_ef10_essb_rx_get_dev_info,\n \t.pool_ops_supported\t= sfc_ef10_essb_rx_pool_ops_supported,\n \t.qsize_up_rings\t\t= sfc_ef10_essb_rx_qsize_up_rings,\ndiff --git a/drivers/net/sfc/sfc_ef10_rx.c b/drivers/net/sfc/sfc_ef10_rx.c\nindex 42b35b9b2..6a5052b93 100644\n--- a/drivers/net/sfc/sfc_ef10_rx.c\n+++ b/drivers/net/sfc/sfc_ef10_rx.c\n@@ -658,7 +658,8 @@ struct sfc_dp_rx sfc_ef10_rx = {\n \t\t.hw_fw_caps\t= SFC_DP_HW_FW_CAP_EF10,\n \t},\n \t.features\t\t= SFC_DP_RX_FEAT_MULTI_PROCESS |\n-\t\t\t\t SFC_DP_RX_FEAT_TUNNELS,\n+\t\t\t\t SFC_DP_RX_FEAT_TUNNELS |\n+\t\t\t\t SFC_DP_RX_FEAT_CHECKSUM,\n \t.get_dev_info\t\t= sfc_ef10_rx_get_dev_info,\n \t.qsize_up_rings\t\t= sfc_ef10_rx_qsize_up_rings,\n \t.qcreate\t\t= sfc_ef10_rx_qcreate,\ndiff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex 6ff922770..d8503e201 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -517,7 +517,8 @@ struct sfc_dp_rx sfc_efx_rx = {\n \t\t.type\t\t= SFC_DP_RX,\n \t\t.hw_fw_caps\t= 0,\n \t},\n-\t.features\t\t= SFC_DP_RX_FEAT_SCATTER,\n+\t.features\t\t= SFC_DP_RX_FEAT_SCATTER |\n+\t\t\t\t SFC_DP_RX_FEAT_CHECKSUM,\n \t.qsize_up_rings\t\t= sfc_efx_rx_qsize_up_rings,\n \t.qcreate\t\t= sfc_efx_rx_qcreate,\n \t.qdestroy\t\t= sfc_efx_rx_qdestroy,\n@@ -792,9 +793,12 @@ sfc_rx_get_dev_offload_caps(struct sfc_adapter *sa)\n \n \tcaps |= DEV_RX_OFFLOAD_JUMBO_FRAME;\n \tcaps |= DEV_RX_OFFLOAD_CRC_STRIP;\n-\tcaps |= DEV_RX_OFFLOAD_IPV4_CKSUM;\n-\tcaps |= DEV_RX_OFFLOAD_UDP_CKSUM;\n-\tcaps |= DEV_RX_OFFLOAD_TCP_CKSUM;\n+\n+\tif (sa->dp_rx->features & SFC_DP_RX_FEAT_CHECKSUM) {\n+\t\tcaps |= DEV_RX_OFFLOAD_IPV4_CKSUM;\n+\t\tcaps |= DEV_RX_OFFLOAD_UDP_CKSUM;\n+\t\tcaps |= DEV_RX_OFFLOAD_TCP_CKSUM;\n+\t}\n \n \tif (encp->enc_tunnel_encapsulations_supported &&\n \t (sa->dp_rx->features & SFC_DP_RX_FEAT_TUNNELS))\n@@ -1443,8 +1447,13 @@ sfc_rx_check_mode(struct sfc_adapter *sa, struct rte_eth_rxmode *rxmode)\n \t\trxmode->offloads |= DEV_RX_OFFLOAD_CRC_STRIP;\n \t}\n \n+\t/*\n+\t * Requested offloads are validated against supported by ethdev,\n+\t * so unsupported offloads cannot be added as the result of\n+\t * below check.\n+\t */\n \tif ((rxmode->offloads & DEV_RX_OFFLOAD_CHECKSUM) !=\n-\t DEV_RX_OFFLOAD_CHECKSUM) {\n+\t (offloads_supported & DEV_RX_OFFLOAD_CHECKSUM)) {\n \t\tsfc_warn(sa, \"Rx checksum offloads cannot be disabled - always on (IPv4/TCP/UDP)\");\n \t\trxmode->offloads |= DEV_RX_OFFLOAD_CHECKSUM;\n \t}\n", "prefixes": [ "3/3" ] }