Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42988/?format=api
{ "id": 42988, "url": "http://patches.dpdk.org/api/patches/42988/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1531411499-13156-7-git-send-email-fiona.trahe@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1531411499-13156-7-git-send-email-fiona.trahe@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1531411499-13156-7-git-send-email-fiona.trahe@intel.com", "date": "2018-07-12T16:04:49", "name": "[v6,06/16] compress/qat: check that correct firmware is in use", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8ea35debf98e36343a74e5ba7b52582ba6f01247", "submitter": { "id": 423, "url": "http://patches.dpdk.org/api/people/423/?format=api", "name": "Fiona Trahe", "email": "fiona.trahe@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1531411499-13156-7-git-send-email-fiona.trahe@intel.com/mbox/", "series": [ { "id": 520, "url": "http://patches.dpdk.org/api/series/520/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=520", "date": "2018-07-11T11:56:53", "name": "compress/qat: add compression PMD", "version": 5, "mbox": "http://patches.dpdk.org/series/520/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42988/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42988/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D7EEF1B4FD;\n\tThu, 12 Jul 2018 18:05:34 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 166E91B4F0\n\tfor <dev@dpdk.org>; Thu, 12 Jul 2018 18:05:32 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Jul 2018 09:05:31 -0700", "from sivswdev01.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.45])\n\tby fmsmga006.fm.intel.com with ESMTP; 12 Jul 2018 09:05:17 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,343,1526367600\"; d=\"scan'208\";a=\"245184186\"", "From": "Fiona Trahe <fiona.trahe@intel.com>", "To": "dev@dpdk.org", "Cc": "pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com,\n\ttomaszx.jozwiak@intel.com", "Date": "Thu, 12 Jul 2018 17:04:49 +0100", "Message-Id": "<1531411499-13156-7-git-send-email-fiona.trahe@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1531310229-17448-1-git-send-email-fiona.trahe@intel.com>", "References": "<1531310229-17448-1-git-send-email-fiona.trahe@intel.com>", "Subject": "[dpdk-dev] [PATCH v6 06/16] compress/qat: check that correct\n\tfirmware is in use", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Check bit in response message to verify that correct firmware\nis in use for compression. If not return an error.\n\nSigned-off-by: Fiona Trahe <fiona.trahe@intel.com>\nSigned-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>\n---\n drivers/compress/qat/qat_comp.c | 16 +++++++++++++++-\n drivers/compress/qat/qat_comp.h | 2 ++\n 2 files changed, 17 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c\nindex a32d6ef..e8019eb 100644\n--- a/drivers/compress/qat/qat_comp.c\n+++ b/drivers/compress/qat/qat_comp.c\n@@ -2,7 +2,6 @@\n * Copyright(c) 2018 Intel Corporation\n */\n \n-\n #include <rte_mempool.h>\n #include <rte_mbuf.h>\n #include <rte_hexdump.h>\n@@ -79,6 +78,8 @@ qat_comp_process_response(void **op, uint8_t *resp)\n \t\t\t(struct icp_qat_fw_comp_resp *)resp;\n \tstruct rte_comp_op *rx_op = (struct rte_comp_op *)(uintptr_t)\n \t\t\t(resp_msg->opaque_data);\n+\tstruct qat_comp_xform *qat_xform = (struct qat_comp_xform *)\n+\t\t\t\t(rx_op->private_xform);\n \n #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n \tQAT_DP_LOG(DEBUG, \"Direction: %s\",\n@@ -88,6 +89,19 @@ qat_comp_process_response(void **op, uint8_t *resp)\n \t\t\tsizeof(struct icp_qat_fw_comp_resp));\n #endif\n \n+\tif (likely(qat_xform->qat_comp_request_type\n+\t\t\t!= QAT_COMP_REQUEST_DECOMPRESS)) {\n+\t\tif (unlikely(ICP_QAT_FW_COMN_HDR_CNV_FLAG_GET(\n+\t\t\t\tresp_msg->comn_resp.hdr_flags)\n+\t\t\t\t\t== ICP_QAT_FW_COMP_NO_CNV)) {\n+\t\t\trx_op->status = RTE_COMP_OP_STATUS_ERROR;\n+\t\t\trx_op->debug_status = ERR_CODE_QAT_COMP_WRONG_FW;\n+\t\t\t*op = (void *)rx_op;\n+\t\t\tQAT_DP_LOG(ERR, \"QAT has wrong firmware\");\n+\t\t\treturn 0;\n+\t\t}\n+\t}\n+\n \tif ((ICP_QAT_FW_COMN_RESP_CMP_STAT_GET(resp_msg->comn_resp.comn_status)\n \t\t| ICP_QAT_FW_COMN_RESP_XLAT_STAT_GET(\n \t\t\t\tresp_msg->comn_resp.comn_status)) !=\ndiff --git a/drivers/compress/qat/qat_comp.h b/drivers/compress/qat/qat_comp.h\nindex 46105b4..937f3c8 100644\n--- a/drivers/compress/qat/qat_comp.h\n+++ b/drivers/compress/qat/qat_comp.h\n@@ -15,6 +15,8 @@\n #include \"icp_qat_fw_comp.h\"\n #include \"icp_qat_fw_la.h\"\n \n+#define ERR_CODE_QAT_COMP_WRONG_FW -99\n+\n enum qat_comp_request_type {\n \tQAT_COMP_REQUEST_FIXED_COMP_STATELESS,\n \tQAT_COMP_REQUEST_DYNAMIC_COMP_STATELESS,\n", "prefixes": [ "v6", "06/16" ] }