Patch Comment List
List patch comments
GET /api/patches/429/comments/?format=api
[ { "id": 1727, "web_url": "http://patches.dpdk.org/comment/1727/", "msgid": "<7641617.oBnDKljgVa@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/7641617.oBnDKljgVa@xps13", "date": "2014-10-17T20:59:09", "subject": "Re: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and\n\trelevant macros", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-09-19 09:14, Helin Zhang:\n> To reuse code, 'i40e_config_hena()' and 'i40e_parse_hena()' and\n> their relevant macros need to be extern, and then can be used for\n> both PF and VF parts.\n> \n> Signed-off-by: Helin Zhang <helin.zhang@intel.com>\n> Reviewed-by: Cunming Liang <cunming.liang@intel.com>\n> Reviewed-by: Jijiang Liu <jijiang.liu@intel.com>\n[...]\n> +#define I40E_RSS_OFFLOAD_ALL ( \\\n> +\tETH_RSS_NONF_IPV4_UDP | \\\n> +\tETH_RSS_NONF_IPV4_TCP | \\\n> +\tETH_RSS_NONF_IPV4_SCTP | \\\n> +\tETH_RSS_NONF_IPV4_OTHER | \\\n> +\tETH_RSS_FRAG_IPV4 | \\\n> +\tETH_RSS_NONF_IPV6_UDP | \\\n> +\tETH_RSS_NONF_IPV6_TCP | \\\n> +\tETH_RSS_NONF_IPV6_SCTP | \\\n> +\tETH_RSS_NONF_IPV6_OTHER | \\\n> +\tETH_RSS_FRAG_IPV6 | \\\n> +\tETH_RSS_L2_PAYLOAD)\n> +\n> +/* All bits of RSS hash enable */\n> +#define I40E_RSS_HENA_ALL ( \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_UDP) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_TCP) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_SCTP) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_OTHER) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_FRAG_IPV4) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_UDP) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_TCP) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_SCTP) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_OTHER) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_FRAG_IPV6) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_FCOE_OX) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_FCOE_RX) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_FCOE_OTHER) | \\\n> +\t(1ULL << I40E_FILTER_PCTYPE_L2_PAYLOAD))\n\nYou've added the constants in the .h file but you forgot to remove them from\nthe .c file.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 21C687E79;\n\tFri, 17 Oct 2014 22:51:30 +0200 (CEST)", "from mail-wi0-f181.google.com (mail-wi0-f181.google.com\n\t[209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 1A17D7E74\n\tfor <dev@dpdk.org>; Fri, 17 Oct 2014 22:51:27 +0200 (CEST)", "by mail-wi0-f181.google.com with SMTP id hi2so2222983wib.14\n\tfor <dev@dpdk.org>; Fri, 17 Oct 2014 13:59:26 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tau4sm2980211wjc.15.2014.10.17.13.59.25 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 17 Oct 2014 13:59:25 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=ibkRChMDst2kPU24QJSwS+tRsr+CmYNLt+MQ+adEI+Q=;\n\tb=YrmYadXDJF5f7fJrxQsVeRNs8URlSWbhPE4rZIgef4XIErvmqtEfv0LfAqHfhdFjLQ\n\tnf7y+QUA+Siqj5x1sC+UTANAhERMYRhKQMxzXQ4awLlu80mKYVbcLGNFqsl+IvQTPSF1\n\tGzte6afZ/x0Iyxa74NdSe0EPgKjYKSbmYbr5dFEmh57UDOVsz98t8H8Y5MAm/xZSWhWO\n\tS+nQLcNg5YBFlyOM/QQQMHjNWM6nQGq+HLIjsL8pS1eRTQjZR+Q3MnweHvNwa0hj5s9d\n\tuUqGI8McX4wsz9Jt8b+MqMtls1nv7NzWBz4KQFrHp2XDTArCX8ugHPYlOOPRAQj60LlX\n\tdZ5g==", "X-Gm-Message-State": "ALoCoQmnJJOWIbEfguQYW1Fu5mj4dHGSXFq2V9bv8rAxZ2+EDCyNCdxDc4Jg+CYdQzveUqpETpu0", "X-Received": "by 10.180.20.43 with SMTP id k11mr1714519wie.28.1413579566492;\n\tFri, 17 Oct 2014 13:59:26 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Helin Zhang <helin.zhang@intel.com>", "Date": "Fri, 17 Oct 2014 22:59:09 +0200", "Message-ID": "<7641617.oBnDKljgVa@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )", "In-Reply-To": "<1411089280-23595-3-git-send-email-helin.zhang@intel.com>", "References": "<1411089280-23595-1-git-send-email-helin.zhang@intel.com>\n\t<1411089280-23595-3-git-send-email-helin.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and\n\trelevant macros", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1732, "web_url": "http://patches.dpdk.org/comment/1732/", "msgid": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7A5897@SHSMSX104.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/F35DEAC7BCE34641BA9FAC6BCA4A12E70A7A5897@SHSMSX104.ccr.corp.intel.com", "date": "2014-10-20T01:11:37", "subject": "Re: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and\n\trelevant macros", "submitter": { "id": 14, "url": "http://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "content": "Hi Thomas\n\n> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Saturday, October 18, 2014 4:59 AM\n> To: Zhang, Helin\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and relevant\n> macros\n> \n> 2014-09-19 09:14, Helin Zhang:\n> > To reuse code, 'i40e_config_hena()' and 'i40e_parse_hena()' and their\n> > relevant macros need to be extern, and then can be used for both PF\n> > and VF parts.\n> >\n> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>\n> > Reviewed-by: Cunming Liang <cunming.liang@intel.com>\n> > Reviewed-by: Jijiang Liu <jijiang.liu@intel.com>\n> [...]\n> > +#define I40E_RSS_OFFLOAD_ALL ( \\\n> > +\tETH_RSS_NONF_IPV4_UDP | \\\n> > +\tETH_RSS_NONF_IPV4_TCP | \\\n> > +\tETH_RSS_NONF_IPV4_SCTP | \\\n> > +\tETH_RSS_NONF_IPV4_OTHER | \\\n> > +\tETH_RSS_FRAG_IPV4 | \\\n> > +\tETH_RSS_NONF_IPV6_UDP | \\\n> > +\tETH_RSS_NONF_IPV6_TCP | \\\n> > +\tETH_RSS_NONF_IPV6_SCTP | \\\n> > +\tETH_RSS_NONF_IPV6_OTHER | \\\n> > +\tETH_RSS_FRAG_IPV6 | \\\n> > +\tETH_RSS_L2_PAYLOAD)\n> > +\n> > +/* All bits of RSS hash enable */\n> > +#define I40E_RSS_HENA_ALL ( \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_UDP) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_TCP) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_SCTP) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_OTHER) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_FRAG_IPV4) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_UDP) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_TCP) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_SCTP) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_OTHER) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_FRAG_IPV6) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_FCOE_OX) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_FCOE_RX) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_FCOE_OTHER) | \\\n> > +\t(1ULL << I40E_FILTER_PCTYPE_L2_PAYLOAD))\n> \n> You've added the constants in the .h file but you forgot to remove them from\n> the .c file.\nOhh, yes, you are right! Thank you for the good catch! And sorry for the inconvenience!\n\n\n> \n> --\n> Thomas\n\nRegards,\nHelin", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7562968FB;\n\tMon, 20 Oct 2014 03:06:09 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 127BE685D\n\tfor <dev@dpdk.org>; Mon, 20 Oct 2014 03:06:07 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 19 Oct 2014 18:14:16 -0700", "from pgsmsx103.gar.corp.intel.com ([10.221.44.82])\n\tby fmsmga002.fm.intel.com with ESMTP; 19 Oct 2014 18:14:15 -0700", "from shsmsx103.ccr.corp.intel.com (10.239.4.69) by\n\tPGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Mon, 20 Oct 2014 09:11:39 +0800", "from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by\n\tSHSMSX103.ccr.corp.intel.com ([169.254.4.207]) with mapi id\n\t14.03.0195.001; Mon, 20 Oct 2014 09:11:38 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,749,1406617200\"; d=\"scan'208\";a=\"616960087\"", "From": "\"Zhang, Helin\" <helin.zhang@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and\n\trelevant macros", "Thread-Index": "AQHP6k1VkAk1tgzES0udHF6E86kj4Zw4LysA", "Date": "Mon, 20 Oct 2014 01:11:37 +0000", "Message-ID": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7A5897@SHSMSX104.ccr.corp.intel.com>", "References": "<1411089280-23595-1-git-send-email-helin.zhang@intel.com>\n\t<1411089280-23595-3-git-send-email-helin.zhang@intel.com>\n\t<7641617.oBnDKljgVa@xps13>", "In-Reply-To": "<7641617.oBnDKljgVa@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and\n\trelevant macros", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]