Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42896/?format=api
{ "id": 42896, "url": "http://patches.dpdk.org/api/patches/42896/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/2b839e17ebd871c2832b68608988fb00f760892c.1531345404.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<2b839e17ebd871c2832b68608988fb00f760892c.1531345404.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/2b839e17ebd871c2832b68608988fb00f760892c.1531345404.git.gaetan.rivet@6wind.com", "date": "2018-07-11T21:44:53", "name": "[v11,03/25] kvargs: remove error logs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e37dfae8b78894130bb6b93e61b788f220c6414e", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/2b839e17ebd871c2832b68608988fb00f760892c.1531345404.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 533, "url": "http://patches.dpdk.org/api/series/533/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=533", "date": "2018-07-11T21:44:50", "name": "Device querying", "version": 11, "mbox": "http://patches.dpdk.org/series/533/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42896/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42896/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E58301B532;\n\tWed, 11 Jul 2018 23:45:44 +0200 (CEST)", "from mail-wr1-f67.google.com (mail-wr1-f67.google.com\n\t[209.85.221.67]) by dpdk.org (Postfix) with ESMTP id B42FB1B50D\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 23:45:41 +0200 (CEST)", "by mail-wr1-f67.google.com with SMTP id c13-v6so19557879wrt.1\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 14:45:41 -0700 (PDT)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\th5-v6sm10550936wrr.19.2018.07.11.14.45.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 11 Jul 2018 14:45:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=0PfDbteb90dJZdNR95tgR1W4/MwSAauYE1N7bIOuOqQ=;\n\tb=z4Iq7irNhZeqpBVR4u5y/aa1+ucRCAfMPUoAvyf1hKz5E1CzeENZ/Q10hRPh4QnKIP\n\tRJY8j21j6eZzuMwXE8olAWPB5bf0AFQKPYbdV5Nkc+bXM7JT2Wvxinksks3iwBHen8CK\n\tQEwtNhCx1/VnPqnuAbudyMquXIyJsr64u3va3T5nZ3mH1iF1ExrGJ2fuBEwPVnkccI8N\n\tGa+iMoP/U/Ignfm5ACFvjASakr6TmlwKuHJzDcvK+yStK1YC+uv87CQ3YBG8ymWri/6w\n\tULL/anKbiMMgsygumG2qfxEBcHPUwPIYoO7vLfRryCcqWiGBtm64wGQYVMYbx+GhZJzc\n\tyymg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=0PfDbteb90dJZdNR95tgR1W4/MwSAauYE1N7bIOuOqQ=;\n\tb=fyKNBy1yUj0yGTH3Lf9t/aV9G0xQ/AC1XU6fs/kITFYFfdKXtzK5Nh0wdGwxJbGJOX\n\tcDPVmtq/XIy1B5Ubwtrxeb+HHBdaujrb4Kuokqxp9RO9wSSEAJGV/08OAY7d2KVEmR6r\n\tTPEaj/YBPv9eJ4v1Wn/zN6HK3uiOU/kSvAXMVi1/AaKIfYXwehTuLFGdjv7QFa9jz5FP\n\tWIp0JV8E7wgiqFEqNBorO2xIy2DqKhx6y9DM7vDfTrIgPHaHGSARqUZtRvnPsrDc7xsM\n\tWKw2k8ye7NwNj66WV1VAEnimbOp3h13krv25RIf+Y4SYJn5FU39PUhxWl6w2jioX8pC3\n\trJPA==", "X-Gm-Message-State": "AOUpUlFYFJjW1E8Tx9E2mbWnmUJ3+aGMmL5NW8TQOCtH3liF3zQ+qrmR\n\tELqkg1riDanb7y6ypWnm2twqvLvs", "X-Google-Smtp-Source": "AAOMgpfCwNUeKveug50iGBlw7ZFcJF5XgrJpvlxQch7ZDw4CJfaYkmK111NihmunbUswXrM97uSIwg==", "X-Received": "by 2002:adf:8e10:: with SMTP id\n\tn16-v6mr229983wrb.100.1531345541060; \n\tWed, 11 Jul 2018 14:45:41 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Wed, 11 Jul 2018 23:44:53 +0200", "Message-Id": "<2b839e17ebd871c2832b68608988fb00f760892c.1531345404.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1531345404.git.gaetan.rivet@6wind.com>", "References": "<cover.1531345404.git.gaetan.rivet@6wind.com>", "Subject": "[dpdk-dev] [PATCH v11 03/25] kvargs: remove error logs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Error logs in kvargs parsing should be better handled in components\ncalling the library.\n\nThis library must be as lean as possible.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\nAcked-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/librte_kvargs/rte_kvargs.c | 22 +++++-----------------\n 1 file changed, 5 insertions(+), 17 deletions(-)", "diff": "diff --git a/lib/librte_kvargs/rte_kvargs.c b/lib/librte_kvargs/rte_kvargs.c\nindex d92a5f9dc..747f14964 100644\n--- a/lib/librte_kvargs/rte_kvargs.c\n+++ b/lib/librte_kvargs/rte_kvargs.c\n@@ -6,7 +6,6 @@\n #include <string.h>\n #include <stdlib.h>\n \n-#include <rte_log.h>\n #include <rte_string_fns.h>\n \n #include \"rte_kvargs.h\"\n@@ -28,29 +27,22 @@ rte_kvargs_tokenize(struct rte_kvargs *kvlist, const char *params)\n \t * to pass to rte_strsplit\n \t */\n \tkvlist->str = strdup(params);\n-\tif (kvlist->str == NULL) {\n-\t\tRTE_LOG(ERR, PMD, \"Cannot parse arguments: not enough memory\\n\");\n+\tif (kvlist->str == NULL)\n \t\treturn -1;\n-\t}\n \n \t/* browse each key/value pair and add it in kvlist */\n \tstr = kvlist->str;\n \twhile ((str = strtok_r(str, RTE_KVARGS_PAIRS_DELIM, &ctx1)) != NULL) {\n \n \t\ti = kvlist->count;\n-\t\tif (i >= RTE_KVARGS_MAX) {\n-\t\t\tRTE_LOG(ERR, PMD, \"Cannot parse arguments: list full\\n\");\n+\t\tif (i >= RTE_KVARGS_MAX)\n \t\t\treturn -1;\n-\t\t}\n \n \t\tkvlist->pairs[i].key = strtok_r(str, RTE_KVARGS_KV_DELIM, &ctx2);\n \t\tkvlist->pairs[i].value = strtok_r(NULL, RTE_KVARGS_KV_DELIM, &ctx2);\n-\t\tif (kvlist->pairs[i].key == NULL || kvlist->pairs[i].value == NULL) {\n-\t\t\tRTE_LOG(ERR, PMD,\n-\t\t\t\t\"Cannot parse arguments: wrong key or value\\n\"\n-\t\t\t\t\"params=<%s>\\n\", params);\n+\t\tif (kvlist->pairs[i].key == NULL ||\n+\t\t kvlist->pairs[i].value == NULL)\n \t\t\treturn -1;\n-\t\t}\n \n \t\tkvlist->count++;\n \t\tstr = NULL;\n@@ -89,12 +81,8 @@ check_for_valid_keys(struct rte_kvargs *kvlist,\n \tfor (i = 0; i < kvlist->count; i++) {\n \t\tpair = &kvlist->pairs[i];\n \t\tret = is_valid_key(valid, pair->key);\n-\t\tif (!ret) {\n-\t\t\tRTE_LOG(ERR, PMD,\n-\t\t\t\t\"Error parsing device, invalid key <%s>\\n\",\n-\t\t\t\tpair->key);\n+\t\tif (!ret)\n \t\t\treturn -1;\n-\t\t}\n \t}\n \treturn 0;\n }\n", "prefixes": [ "v11", "03/25" ] }