Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42880/?format=api
{ "id": 42880, "url": "http://patches.dpdk.org/api/patches/42880/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1531318450-3942-3-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1531318450-3942-3-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1531318450-3942-3-git-send-email-arybchenko@solarflare.com", "date": "2018-07-11T14:14:09", "name": "[2/3] ethdev: deprecate attach and detach functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "adb44f72d1d76a0601d503011d0e4a4a5683af1b", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1531318450-3942-3-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 525, "url": "http://patches.dpdk.org/api/series/525/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=525", "date": "2018-07-11T14:14:10", "name": "deprecate attach and detach functions", "version": 1, "mbox": "http://patches.dpdk.org/series/525/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42880/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42880/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BDFAE1B5D3;\n\tWed, 11 Jul 2018 16:14:35 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 3F37E1B5AA\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 16:14:29 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 29B4A60005D; Wed, 11 Jul 2018 14:14:28 +0000 (UTC)", "from sfocexch01r.SolarFlarecom.com (10.20.40.34) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Wed, 11 Jul 2018 07:14:25 -0700", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tsfocexch01r.SolarFlarecom.com (10.20.40.34) with Microsoft SMTP\n\tServer (TLS) id 15.0.1044.25; Wed, 11 Jul 2018 07:14:24 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Wed, 11 Jul 2018 07:14:23 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw6BEEMww021498; Wed, 11 Jul 2018 15:14:22 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t6A9E916546C; Wed, 11 Jul 2018 15:14:22 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Thomas Monjalon <thomas@monjalon.net>", "Date": "Wed, 11 Jul 2018 15:14:09 +0100", "Message-ID": "<1531318450-3942-3-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1531318450-3942-1-git-send-email-arybchenko@solarflare.com>", "References": "<1531318450-3942-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MDID": "1531318468-ZjFUWdZYoeYX", "Subject": "[dpdk-dev] [PATCH 2/3] ethdev: deprecate attach and detach functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "These functions are buggy from the very beginning and should not be used.\nGeneric EAL hotplug mechanisms should be used instead.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n app/test-pmd/Makefile | 1 +\n app/test-pmd/meson.build | 1 +\n doc/guides/rel_notes/deprecation.rst | 7 +++++++\n lib/librte_ethdev/rte_ethdev.h | 2 ++\n 4 files changed, 11 insertions(+)", "diff": "diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile\nindex a5a827bbd..ae9897510 100644\n--- a/app/test-pmd/Makefile\n+++ b/app/test-pmd/Makefile\n@@ -13,6 +13,7 @@ APP = testpmd\n CFLAGS += -DALLOW_EXPERIMENTAL_API\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n+CFLAGS += -Wno-deprecated-declarations\n \n #\n # all source are stored in SRCS-y\ndiff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build\nindex 4c9fbbfda..861e157ea 100644\n--- a/app/test-pmd/meson.build\n+++ b/app/test-pmd/meson.build\n@@ -4,6 +4,7 @@\n # override default name to drop the hyphen\n name = 'testpmd'\n allow_experimental_apis = true\n+cflags += '-Wno-deprecated-declarations'\n sources = files('cmdline.c',\n \t'cmdline_flow.c',\n \t'cmdline_mtr.c',\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 8df41cb6a..fc3bf1a0b 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -72,6 +72,13 @@ Deprecation Notices\n Target release for removal of the legacy API will be defined once most\n PMDs have switched to rte_flow.\n \n+* ethdev: In v18.11 ``rte_eth_dev_attach()`` and ``rte_eth_dev_detach()``\n+ will be removed.\n+ Hotplug functions ``rte_eal_hotplug_add()`` and ``rte_eal_hotplug_remove()``\n+ should be used instread.\n+ Function ``rte_eth_dev_get_port_by_name()`` may be used to find\n+ identifier of the added port.\n+\n * pdump: As we changed to use generic IPC, some changes in APIs and structure\n are expected in subsequent release.\n \ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex f5f593b31..46c569a7f 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -1433,6 +1433,7 @@ uint16_t __rte_experimental rte_eth_dev_count_total(void);\n * @return\n * 0 on success and port_id is filled, negative on error\n */\n+__rte_deprecated\n int rte_eth_dev_attach(const char *devargs, uint16_t *port_id);\n \n /**\n@@ -1448,6 +1449,7 @@ int rte_eth_dev_attach(const char *devargs, uint16_t *port_id);\n * @return\n * 0 on success and devname is filled, negative on error\n */\n+__rte_deprecated\n int rte_eth_dev_detach(uint16_t port_id, char *devname);\n \n /**\n", "prefixes": [ "2/3" ] }