Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42808/?format=api
{ "id": 42808, "url": "http://patches.dpdk.org/api/patches/42808/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/338ecaa26ab6ca75a554fa22d9d620e3feb29314.1531293415.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<338ecaa26ab6ca75a554fa22d9d620e3feb29314.1531293415.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/338ecaa26ab6ca75a554fa22d9d620e3feb29314.1531293415.git.nelio.laranjeiro@6wind.com", "date": "2018-07-11T07:22:48", "name": "[v3,15/21] net/mlx5: remove useless arguments in hrxq API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f7640ab48891d5d52112aec70d2e1c9635ed149e", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/338ecaa26ab6ca75a554fa22d9d620e3feb29314.1531293415.git.nelio.laranjeiro@6wind.com/mbox/", "series": [ { "id": 512, "url": "http://patches.dpdk.org/api/series/512/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=512", "date": "2018-07-11T07:22:33", "name": "net/mlx5: flow rework", "version": 3, "mbox": "http://patches.dpdk.org/series/512/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42808/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/42808/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1B4C81B558;\n\tWed, 11 Jul 2018 09:24:00 +0200 (CEST)", "from mail-wr1-f65.google.com (mail-wr1-f65.google.com\n\t[209.85.221.65]) by dpdk.org (Postfix) with ESMTP id F082F1B447\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 09:23:30 +0200 (CEST)", "by mail-wr1-f65.google.com with SMTP id q10-v6so17002359wrd.4\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 00:23:30 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tt10-v6sm31314212wre.95.2018.07.11.00.23.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 11 Jul 2018 00:23:30 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=kJn5IYGw8svVfxeAoEPIjP9eACpfPLMlZjJgn8CcUcI=;\n\tb=XgmpX4nW9xDU3ibHCqpLjeyNBmplqUnqrH7Y0jswEBAJLvD2OHXyXjvQIHw6rgdYzU\n\t4ZDf6yJlXDFnQOQds6tkzAc4ZWiabDYkUcYAD4CyrdZ4OmZcDjfDumyh/hSfoIuaVzVv\n\t/kHvRPin3PZXQh7zYl0KC02viuwl4w+FAX+Gal94dtnSKlBEHAF1tLCFRvRJpT5Gj506\n\t39GfFzZSrgpstF7+GjTB3iZK2gtqn2cUzfsNOyOO2EJKpn8T45PBkrSmLxDgcGIhoMI3\n\tBmWAJxfI/LsB1wJY4x3PHrGzOQwf9PfyHqd54IBlT256CuPXBSRpl4oxLoduxuw3I7kg\n\t02WQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=kJn5IYGw8svVfxeAoEPIjP9eACpfPLMlZjJgn8CcUcI=;\n\tb=LkRH1+ED5/OoA/GRL49dSfxgW26SM5eJLZySr8gyW/EDwIrq9j18eWmbkvVctMQB07\n\tCzZ9cPQATr3nQEkkrvwuQwcxw1fTohUw4Ux4E0VFEZLSr+qmqSHjM8UlkAq/bLVseB5I\n\tBQRw6JV7xWIbU0cn0rRfaZ0ynC1zgzuOlKROMoLO/YArUaL+fCEIruUk13aBcY9cKrGD\n\t7vKstRWnfPxttg0wixY8uT1K57VZBMPuzRyuNeKi+3iE475GLSkI7gQ3246PUrZ2J0cb\n\tOvb1W5A0OAL95JVWDYJOvELT9rNy8s5RPTqwLMFElGpS5fSgJSz6fTJG231Y6R56Sesn\n\ts/Pg==", "X-Gm-Message-State": "APt69E1IFywrt5UVEXjIcsReZuXNvA50C7KV2FCsJ0i4kqXjGfbRHX8i\n\tary8Qt+wjdq5NxzVPRe9ZtLe5B0m5Q==", "X-Google-Smtp-Source": "AAOMgpdxHwMBWQT0Nj57FDQqpANXcvlaVYLzd4DimlcqvYt+gPASX/ymwYOQ/WR42KwRt6vW4C/ChA==", "X-Received": "by 2002:adf:8ab0:: with SMTP id\n\ty45-v6mr18820518wry.98.1531293810555; \n\tWed, 11 Jul 2018 00:23:30 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org,\n\tYongseok Koh <yskoh@mellanox.com>", "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Date": "Wed, 11 Jul 2018 09:22:48 +0200", "Message-Id": "<338ecaa26ab6ca75a554fa22d9d620e3feb29314.1531293415.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1531293415.git.nelio.laranjeiro@6wind.com>", "References": "<cover.1530111623.git.nelio.laranjeiro@6wind.com>\n\t<cover.1531293415.git.nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH v3 15/21] net/mlx5: remove useless arguments in\n\thrxq API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "RSS level is necessary to had a bit in the hash_fields which is already\nprovided in this API, for the tunnel, it is necessary to request such\nqueue to compute the checksum on the inner most, this last one should\nalways be activated.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nAcked-by: Yongseok Koh <yskoh@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 4 ++--\n drivers/net/mlx5/mlx5_rxq.c | 39 +++++++++---------------------------\n drivers/net/mlx5/mlx5_rxtx.h | 8 ++------\n 3 files changed, 13 insertions(+), 38 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex f098e727a..f2acac1f5 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -1871,13 +1871,13 @@ mlx5_flow_apply(struct rte_eth_dev *dev, struct rte_flow *flow,\n \t\t\t\t\t MLX5_RSS_HASH_KEY_LEN,\n \t\t\t\t\t verbs->hash_fields,\n \t\t\t\t\t (*flow->queue),\n-\t\t\t\t\t flow->rss.queue_num, 0, 0);\n+\t\t\t\t\t flow->rss.queue_num);\n \t\t\tif (!hrxq)\n \t\t\t\thrxq = mlx5_hrxq_new(dev, flow->key,\n \t\t\t\t\t\t MLX5_RSS_HASH_KEY_LEN,\n \t\t\t\t\t\t verbs->hash_fields,\n \t\t\t\t\t\t (*flow->queue),\n-\t\t\t\t\t\t flow->rss.queue_num, 0, 0);\n+\t\t\t\t\t\t flow->rss.queue_num);\n \t\t\tif (!hrxq) {\n \t\t\t\trte_flow_error_set\n \t\t\t\t\t(error, rte_errno,\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex d50b82c69..071740b6d 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -1740,10 +1740,6 @@ mlx5_ind_table_ibv_verify(struct rte_eth_dev *dev)\n * first queue index will be taken for the indirection table.\n * @param queues_n\n * Number of queues.\n- * @param tunnel\n- * Tunnel type, implies tunnel offloading like inner checksum if available.\n- * @param rss_level\n- * RSS hash on tunnel level.\n *\n * @return\n * The Verbs object initialised, NULL otherwise and rte_errno is set.\n@@ -1752,17 +1748,13 @@ struct mlx5_hrxq *\n mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t const uint8_t *rss_key, uint32_t rss_key_len,\n \t uint64_t hash_fields,\n-\t const uint16_t *queues, uint32_t queues_n,\n-\t uint32_t tunnel, uint32_t rss_level)\n+\t const uint16_t *queues, uint32_t queues_n)\n {\n \tstruct priv *priv = dev->data->dev_private;\n \tstruct mlx5_hrxq *hrxq;\n \tstruct mlx5_ind_table_ibv *ind_tbl;\n \tstruct ibv_qp *qp;\n \tint err;\n-#ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT\n-\tstruct mlx5dv_qp_init_attr qp_init_attr = {0};\n-#endif\n \n \tqueues_n = hash_fields ? queues_n : 1;\n \tind_tbl = mlx5_ind_table_ibv_get(dev, queues, queues_n);\n@@ -1777,11 +1769,6 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t\trss_key = rss_hash_default_key;\n \t}\n #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT\n-\tif (tunnel) {\n-\t\tqp_init_attr.comp_mask =\n-\t\t\t\tMLX5DV_QP_INIT_ATTR_MASK_QP_CREATE_FLAGS;\n-\t\tqp_init_attr.create_flags = MLX5DV_QP_CREATE_TUNNEL_OFFLOADS;\n-\t}\n \tqp = mlx5_glue->dv_create_qp\n \t\t(priv->ctx,\n \t\t &(struct ibv_qp_init_attr_ex){\n@@ -1797,14 +1784,17 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t\t\t\t.rx_hash_key = rss_key ?\n \t\t\t\t\t (void *)(uintptr_t)rss_key :\n \t\t\t\t\t rss_hash_default_key,\n-\t\t\t\t.rx_hash_fields_mask = hash_fields |\n-\t\t\t\t\t(tunnel && rss_level > 1 ?\n-\t\t\t\t\t(uint32_t)IBV_RX_HASH_INNER : 0),\n+\t\t\t\t.rx_hash_fields_mask = hash_fields,\n \t\t\t},\n \t\t\t.rwq_ind_tbl = ind_tbl->ind_table,\n \t\t\t.pd = priv->pd,\n \t\t },\n-\t\t &qp_init_attr);\n+\t\t &(struct mlx5dv_qp_init_attr){\n+\t\t\t.comp_mask = (hash_fields & IBV_RX_HASH_INNER) ?\n+\t\t\t\t MLX5DV_QP_INIT_ATTR_MASK_QP_CREATE_FLAGS :\n+\t\t\t\t 0,\n+\t\t\t.create_flags = MLX5DV_QP_CREATE_TUNNEL_OFFLOADS,\n+\t\t });\n #else\n \tqp = mlx5_glue->create_qp_ex\n \t\t(priv->ctx,\n@@ -1838,8 +1828,6 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n \thrxq->qp = qp;\n \thrxq->rss_key_len = rss_key_len;\n \thrxq->hash_fields = hash_fields;\n-\thrxq->tunnel = tunnel;\n-\thrxq->rss_level = rss_level;\n \tmemcpy(hrxq->rss_key, rss_key, rss_key_len);\n \trte_atomic32_inc(&hrxq->refcnt);\n \tLIST_INSERT_HEAD(&priv->hrxqs, hrxq, next);\n@@ -1865,10 +1853,6 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n * first queue index will be taken for the indirection table.\n * @param queues_n\n * Number of queues.\n- * @param tunnel\n- * Tunnel type, implies tunnel offloading like inner checksum if available.\n- * @param rss_level\n- * RSS hash on tunnel level\n *\n * @return\n * An hash Rx queue on success.\n@@ -1877,8 +1861,7 @@ struct mlx5_hrxq *\n mlx5_hrxq_get(struct rte_eth_dev *dev,\n \t const uint8_t *rss_key, uint32_t rss_key_len,\n \t uint64_t hash_fields,\n-\t const uint16_t *queues, uint32_t queues_n,\n-\t uint32_t tunnel, uint32_t rss_level)\n+\t const uint16_t *queues, uint32_t queues_n)\n {\n \tstruct priv *priv = dev->data->dev_private;\n \tstruct mlx5_hrxq *hrxq;\n@@ -1893,10 +1876,6 @@ mlx5_hrxq_get(struct rte_eth_dev *dev,\n \t\t\tcontinue;\n \t\tif (hrxq->hash_fields != hash_fields)\n \t\t\tcontinue;\n-\t\tif (hrxq->tunnel != tunnel)\n-\t\t\tcontinue;\n-\t\tif (hrxq->rss_level != rss_level)\n-\t\t\tcontinue;\n \t\tind_tbl = mlx5_ind_table_ibv_get(dev, queues, queues_n);\n \t\tif (!ind_tbl)\n \t\t\tcontinue;\ndiff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h\nindex 59e374d8d..808118e50 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.h\n+++ b/drivers/net/mlx5/mlx5_rxtx.h\n@@ -157,8 +157,6 @@ struct mlx5_hrxq {\n \tstruct mlx5_ind_table_ibv *ind_table; /* Indirection table. */\n \tstruct ibv_qp *qp; /* Verbs queue pair. */\n \tuint64_t hash_fields; /* Verbs Hash fields. */\n-\tuint32_t tunnel; /* Tunnel type. */\n-\tuint32_t rss_level; /* RSS on tunnel level. */\n \tuint32_t rss_key_len; /* Hash key length in bytes. */\n \tuint8_t rss_key[]; /* Hash key. */\n };\n@@ -271,13 +269,11 @@ void mlx5_ind_table_ibv_drop_release(struct rte_eth_dev *dev);\n struct mlx5_hrxq *mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t\t\t\tconst uint8_t *rss_key, uint32_t rss_key_len,\n \t\t\t\tuint64_t hash_fields,\n-\t\t\t\tconst uint16_t *queues, uint32_t queues_n,\n-\t\t\t\tuint32_t tunnel, uint32_t rss_level);\n+\t\t\t\tconst uint16_t *queues, uint32_t queues_n);\n struct mlx5_hrxq *mlx5_hrxq_get(struct rte_eth_dev *dev,\n \t\t\t\tconst uint8_t *rss_key, uint32_t rss_key_len,\n \t\t\t\tuint64_t hash_fields,\n-\t\t\t\tconst uint16_t *queues, uint32_t queues_n,\n-\t\t\t\tuint32_t tunnel, uint32_t rss_level);\n+\t\t\t\tconst uint16_t *queues, uint32_t queues_n);\n int mlx5_hrxq_release(struct rte_eth_dev *dev, struct mlx5_hrxq *hxrq);\n int mlx5_hrxq_ibv_verify(struct rte_eth_dev *dev);\n struct mlx5_hrxq *mlx5_hrxq_drop_new(struct rte_eth_dev *dev);\n", "prefixes": [ "v3", "15/21" ] }