Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42806/?format=api
{ "id": 42806, "url": "http://patches.dpdk.org/api/patches/42806/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/f22a21fd3462ade31780cc3f449e83d254f72c58.1531293415.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<f22a21fd3462ade31780cc3f449e83d254f72c58.1531293415.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f22a21fd3462ade31780cc3f449e83d254f72c58.1531293415.git.nelio.laranjeiro@6wind.com", "date": "2018-07-11T07:22:46", "name": "[v3,13/21] net/mlx5: use a macro for the RSS key size", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f77207e62f4eb3c455e1281fa09fc866d2cddd3d", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/f22a21fd3462ade31780cc3f449e83d254f72c58.1531293415.git.nelio.laranjeiro@6wind.com/mbox/", "series": [ { "id": 512, "url": "http://patches.dpdk.org/api/series/512/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=512", "date": "2018-07-11T07:22:33", "name": "net/mlx5: flow rework", "version": 3, "mbox": "http://patches.dpdk.org/series/512/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42806/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/42806/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8A6021B54D;\n\tWed, 11 Jul 2018 09:23:55 +0200 (CEST)", "from mail-wr1-f68.google.com (mail-wr1-f68.google.com\n\t[209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 2BF571B4DA\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 09:23:30 +0200 (CEST)", "by mail-wr1-f68.google.com with SMTP id b15-v6so17030118wrv.10\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 00:23:30 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tt10-v6sm31314212wre.95.2018.07.11.00.23.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 11 Jul 2018 00:23:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=1c+WvFPh9dH6B8Z9Bv2qmfPMGLQA9MBNN50sBbthx0w=;\n\tb=yM/DBQWzH8cWwiJr3OQYHvF7CjEgOax8NMo/lfkbMWRyzeHxt3H4SPQrymqbcr3OL+\n\ts2dZ/vz+gnc67ZVI6aBe7hZicdwjz8Ni4rmJbmcwM7qk16N/12jiI1skWFyFpARWQHVC\n\tAQomoQK5MV2x4U/nxP8C3TffNtgxz+c9Sxuj/SGtmngrgB3fcCPiaOAMuAaTEpA0OIxl\n\tnq9oYiKrGSKly9TugGTwt+B60fb7c13MrpB9/gqQbfE/8+Lb1Hf1LlWG9jiL5Az/c4o2\n\tkWrGMlv1nmilgG9ZujjK8W1Djl4yYFiEKCawvJlJoDp1p3a+0iA+da1IyVWrdWV1554S\n\t7gpA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=1c+WvFPh9dH6B8Z9Bv2qmfPMGLQA9MBNN50sBbthx0w=;\n\tb=jUcXG4PqbObIGiUbkxnHNOL+u35zskyVDW1N8YN8aV4fE2yAnNFdwVmgB4zaha0JOp\n\tfAA4eE5qIygt8I51wLN+1A6CYO7Wl7ggyVKr+3Gxu45AGzK+7FwuHf/hx4FCDfEhIESL\n\tcrPpsnhD49L4QaIKZwIiJ9GnmuSq+8hHiYxFtWNwXEcshvtpIPB/77frnerb08vX6N8W\n\teFU6ppcxAgs/vv3z6+7BKBgYaVPd86Nq15Mxw3vDwvl96kOloGqPL0W3GbmW+JftiEEH\n\t/zFmi6YbdcSpa8QU7X8kIGPsvk2w0onyrsEaDqfZtugP+MyjKRF2ctKaZ+6wAFiwyZAH\n\t6o5Q==", "X-Gm-Message-State": "AOUpUlGsFU2+OZ/6UgO1DgJzI9Gy89UQkBwj9VZrYqw9gILHRHDAvZIp\n\t0Av9PrK/i3pN0tucIDOR7pK6aVtTsA==", "X-Google-Smtp-Source": "AAOMgpcBdV6bw9SasmZcn4pdaOyQ5XqEmFepK9RQ74rMmVIwEtmCmI1VWdtuz6/Cj6Afbzser+4dhA==", "X-Received": "by 2002:adf:f8c7:: with SMTP id\n\tf7-v6mr11833185wrq.237.1531293808653; \n\tWed, 11 Jul 2018 00:23:28 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org,\n\tYongseok Koh <yskoh@mellanox.com>", "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Date": "Wed, 11 Jul 2018 09:22:46 +0200", "Message-Id": "<f22a21fd3462ade31780cc3f449e83d254f72c58.1531293415.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1531293415.git.nelio.laranjeiro@6wind.com>", "References": "<cover.1530111623.git.nelio.laranjeiro@6wind.com>\n\t<cover.1531293415.git.nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH v3 13/21] net/mlx5: use a macro for the RSS key\n\tsize", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "ConnectX 4-5 support only 40 bytes of RSS key, using a compiled size\nhash key is not necessary.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_ethdev.c | 14 +++++++-------\n drivers/net/mlx5/mlx5_flow.c | 4 ++--\n drivers/net/mlx5/mlx5_prm.h | 3 +++\n drivers/net/mlx5/mlx5_rss.c | 7 ++++---\n drivers/net/mlx5/mlx5_rxq.c | 12 +++++++-----\n drivers/net/mlx5/mlx5_rxtx.h | 1 -\n 6 files changed, 23 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 05f66f7b6..6e44d5ff0 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -377,15 +377,15 @@ mlx5_dev_configure(struct rte_eth_dev *dev)\n \n \tif (use_app_rss_key &&\n \t (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len !=\n-\t rss_hash_default_key_len)) {\n-\t\tDRV_LOG(ERR, \"port %u RSS key len must be %zu Bytes long\",\n-\t\t\tdev->data->port_id, rss_hash_default_key_len);\n+\t MLX5_RSS_HASH_KEY_LEN)) {\n+\t\tDRV_LOG(ERR, \"port %u RSS key len must be %s Bytes long\",\n+\t\t\tdev->data->port_id, RTE_STR(MLX5_RSS_HASH_KEY_LEN));\n \t\trte_errno = EINVAL;\n \t\treturn -rte_errno;\n \t}\n \tpriv->rss_conf.rss_key =\n \t\trte_realloc(priv->rss_conf.rss_key,\n-\t\t\t rss_hash_default_key_len, 0);\n+\t\t\t MLX5_RSS_HASH_KEY_LEN, 0);\n \tif (!priv->rss_conf.rss_key) {\n \t\tDRV_LOG(ERR, \"port %u cannot allocate RSS hash key memory (%u)\",\n \t\t\tdev->data->port_id, rxqs_n);\n@@ -396,8 +396,8 @@ mlx5_dev_configure(struct rte_eth_dev *dev)\n \t use_app_rss_key ?\n \t dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key :\n \t rss_hash_default_key,\n-\t rss_hash_default_key_len);\n-\tpriv->rss_conf.rss_key_len = rss_hash_default_key_len;\n+\t MLX5_RSS_HASH_KEY_LEN);\n+\tpriv->rss_conf.rss_key_len = MLX5_RSS_HASH_KEY_LEN;\n \tpriv->rss_conf.rss_hf = dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf;\n \tpriv->rxqs = (void *)dev->data->rx_queues;\n \tpriv->txqs = (void *)dev->data->tx_queues;\n@@ -515,7 +515,7 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)\n \t\tinfo->if_index = if_nametoindex(ifname);\n \tinfo->reta_size = priv->reta_idx_n ?\n \t\tpriv->reta_idx_n : config->ind_table_max_size;\n-\tinfo->hash_key_size = rss_hash_default_key_len;\n+\tinfo->hash_key_size = MLX5_RSS_HASH_KEY_LEN;\n \tinfo->speed_capa = priv->link_speed_capa;\n \tinfo->flow_type_rss_offloads = ~MLX5_RSS_HF_MASK;\n \tmlx5_set_default_params(dev, info);\ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 1280db486..77483bd1f 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -1493,11 +1493,11 @@ mlx5_flow_apply(struct rte_eth_dev *dev, struct rte_flow *flow,\n \t\tstruct mlx5_hrxq *hrxq;\n \n \t\thrxq = mlx5_hrxq_get(dev, rss_hash_default_key,\n-\t\t\t\t rss_hash_default_key_len, 0,\n+\t\t\t\t MLX5_RSS_HASH_KEY_LEN, 0,\n \t\t\t\t &flow->queue, 1, 0, 0);\n \t\tif (!hrxq)\n \t\t\thrxq = mlx5_hrxq_new(dev, rss_hash_default_key,\n-\t\t\t\t\t rss_hash_default_key_len, 0,\n+\t\t\t\t\t MLX5_RSS_HASH_KEY_LEN, 0,\n \t\t\t\t\t &flow->queue, 1, 0, 0);\n \t\tif (!hrxq)\n \t\t\treturn rte_flow_error_set(error, rte_errno,\ndiff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h\nindex f9fae1e50..0870d32fd 100644\n--- a/drivers/net/mlx5/mlx5_prm.h\n+++ b/drivers/net/mlx5/mlx5_prm.h\n@@ -21,6 +21,9 @@\n #include <rte_vect.h>\n #include \"mlx5_autoconf.h\"\n \n+/* RSS hash key size. */\n+#define MLX5_RSS_HASH_KEY_LEN 40\n+\n /* Get CQE owner bit. */\n #define MLX5_CQE_OWNER(op_own) ((op_own) & MLX5_CQE_OWNER_MASK)\n \ndiff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c\nindex d69b4c09e..b95778a8c 100644\n--- a/drivers/net/mlx5/mlx5_rss.c\n+++ b/drivers/net/mlx5/mlx5_rss.c\n@@ -50,10 +50,11 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev,\n \t\treturn -rte_errno;\n \t}\n \tif (rss_conf->rss_key && rss_conf->rss_key_len) {\n-\t\tif (rss_conf->rss_key_len != rss_hash_default_key_len) {\n+\t\tif (rss_conf->rss_key_len != MLX5_RSS_HASH_KEY_LEN) {\n \t\t\tDRV_LOG(ERR,\n-\t\t\t\t\"port %u RSS key len must be %zu Bytes long\",\n-\t\t\t\tdev->data->port_id, rss_hash_default_key_len);\n+\t\t\t\t\"port %u RSS key len must be %s Bytes long\",\n+\t\t\t\tdev->data->port_id,\n+\t\t\t\tRTE_STR(MLX5_RSS_HASH_KEY_LEN));\n \t\t\trte_errno = EINVAL;\n \t\t\treturn -rte_errno;\n \t\t}\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex d960daa43..d50b82c69 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -52,7 +52,9 @@ uint8_t rss_hash_default_key[] = {\n };\n \n /* Length of the default RSS hash key. */\n-const size_t rss_hash_default_key_len = sizeof(rss_hash_default_key);\n+static_assert(MLX5_RSS_HASH_KEY_LEN ==\n+\t (unsigned int)sizeof(rss_hash_default_key),\n+\t \"wrong RSS default key size.\");\n \n /**\n * Check whether Multi-Packet RQ can be enabled for the device.\n@@ -1771,7 +1773,7 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t\treturn NULL;\n \t}\n \tif (!rss_key_len) {\n-\t\trss_key_len = rss_hash_default_key_len;\n+\t\trss_key_len = MLX5_RSS_HASH_KEY_LEN;\n \t\trss_key = rss_hash_default_key;\n \t}\n #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT\n@@ -1791,7 +1793,7 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t\t\t.rx_hash_conf = (struct ibv_rx_hash_conf){\n \t\t\t\t.rx_hash_function = IBV_RX_HASH_FUNC_TOEPLITZ,\n \t\t\t\t.rx_hash_key_len = rss_key_len ? rss_key_len :\n-\t\t\t\t\t\t rss_hash_default_key_len,\n+\t\t\t\t\t\t MLX5_RSS_HASH_KEY_LEN,\n \t\t\t\t.rx_hash_key = rss_key ?\n \t\t\t\t\t (void *)(uintptr_t)rss_key :\n \t\t\t\t\t rss_hash_default_key,\n@@ -1815,7 +1817,7 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t\t\t.rx_hash_conf = (struct ibv_rx_hash_conf){\n \t\t\t\t.rx_hash_function = IBV_RX_HASH_FUNC_TOEPLITZ,\n \t\t\t\t.rx_hash_key_len = rss_key_len ? rss_key_len :\n-\t\t\t\t\t\t rss_hash_default_key_len,\n+\t\t\t\t\t\t MLX5_RSS_HASH_KEY_LEN,\n \t\t\t\t.rx_hash_key = rss_key ?\n \t\t\t\t\t (void *)(uintptr_t)rss_key :\n \t\t\t\t\t rss_hash_default_key,\n@@ -2138,7 +2140,7 @@ mlx5_hrxq_drop_new(struct rte_eth_dev *dev)\n \t\t\t.rx_hash_conf = (struct ibv_rx_hash_conf){\n \t\t\t\t.rx_hash_function =\n \t\t\t\t\tIBV_RX_HASH_FUNC_TOEPLITZ,\n-\t\t\t\t.rx_hash_key_len = rss_hash_default_key_len,\n+\t\t\t\t.rx_hash_key_len = MLX5_RSS_HASH_KEY_LEN,\n \t\t\t\t.rx_hash_key = rss_hash_default_key,\n \t\t\t\t.rx_hash_fields_mask = 0,\n \t\t\t\t},\ndiff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h\nindex 99b769d8a..59e374d8d 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.h\n+++ b/drivers/net/mlx5/mlx5_rxtx.h\n@@ -225,7 +225,6 @@ struct mlx5_txq_ctrl {\n /* mlx5_rxq.c */\n \n extern uint8_t rss_hash_default_key[];\n-extern const size_t rss_hash_default_key_len;\n \n int mlx5_check_mprq_support(struct rte_eth_dev *dev);\n int mlx5_rxq_mprq_enabled(struct mlx5_rxq_data *rxq);\n", "prefixes": [ "v3", "13/21" ] }