Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42798/?format=api
http://patches.dpdk.org/api/patches/42798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/d3d01c2289c25c3e6faa224ec59eff801a2076b8.1531293415.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d3d01c2289c25c3e6faa224ec59eff801a2076b8.1531293415.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d3d01c2289c25c3e6faa224ec59eff801a2076b8.1531293415.git.nelio.laranjeiro@6wind.com", "date": "2018-07-11T07:22:38", "name": "[v3,05/21] net/mlx5: add flow queue action", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f24a70ff4c5c24e94081edfe1112490b39595194", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/d3d01c2289c25c3e6faa224ec59eff801a2076b8.1531293415.git.nelio.laranjeiro@6wind.com/mbox/", "series": [ { "id": 512, "url": "http://patches.dpdk.org/api/series/512/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=512", "date": "2018-07-11T07:22:33", "name": "net/mlx5: flow rework", "version": 3, "mbox": "http://patches.dpdk.org/series/512/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42798/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/42798/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D57E31B4DB;\n\tWed, 11 Jul 2018 09:23:32 +0200 (CEST)", "from mail-wr1-f65.google.com (mail-wr1-f65.google.com\n\t[209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 84B5F1B4B8\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 09:23:22 +0200 (CEST)", "by mail-wr1-f65.google.com with SMTP id p1-v6so16999129wrs.9\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 00:23:22 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tt10-v6sm31314212wre.95.2018.07.11.00.23.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 11 Jul 2018 00:23:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ZEIFVBxPBpaxjyp1iYHHlFX3tzI/If+jotUy4ZQt4/4=;\n\tb=jCnEUaCfDLlsNYoM3t5RoiZ1owKxcamzQdgjZtrSGik++1FxsXdaMRfGeUGeD6OGNg\n\tGhWOuJ+dGCqL/3tP31BMzbMjlOjSMNt0iEBLImPLdWyKbTMtquJXRXyVGVtg6O/LFU91\n\tR4e8MBMygkO5nqnVbs8Rwi2xNVwN/1seW01mKMCUzylLoEf6dBHImNxPULvtU2tm8f/o\n\tRwVHwPCSKZVvipgDFIqhtYdujnODLl5hLMghYcXMjNG/1GCOeExf9OPlia7/v+AwwReR\n\t/dgcwkAEBMUxiXU+8CvW4gzy4+SFFpzCmIaEomkuZV0fFi96ATkbx9xXlsvs4Nmc1FHd\n\tz/hQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=ZEIFVBxPBpaxjyp1iYHHlFX3tzI/If+jotUy4ZQt4/4=;\n\tb=J5UoWfo2JujnFH6Xz5GsoXSVyqK6fnpKrvra4AGslOk5dPlTeeplnVpGjDiYdBgYq7\n\tVXlIaN4uxBYPSmUaxQDsM0S0wGte4by5693clX0otLj8Nuh0iUiSKqeSbe+s70XaLdAR\n\tSvvwyFFLkf75cMAYM6tinpR/+BCd6LuHkd9OI2Ibu5PKSMAj42ymVkOKxCg8zwq7EpsR\n\tfM1gQbNmbfbxmD704oFraowedP26exh1DdQGkWpbGP/TkTwJJC9jW3kV2Eu06ILFyBlM\n\tU/wfnC/XSucJ8yT8C6pjaJxGTrQBQEdZcm4Iyjy97xgeRXIDiw/1w0wLtFzHyvkOdsKc\n\tsDLg==", "X-Gm-Message-State": "APt69E2useZMEO2i8wEaIqd9SSKugHXFT/B5PM72b3l2JpIZFIPrNvHk\n\tL6CK5qwbQHI+DsD6ghjPojvzyWklog==", "X-Google-Smtp-Source": "AAOMgpf16ETr8nctIzuMytQb1QOA62dUiAIJVI2wMe16P8nSatQ2+FVoFEBuebn2h5hXNbvDIjq8fg==", "X-Received": "by 2002:adf:fdcd:: with SMTP id\n\ti13-v6mr19058400wrs.276.1531293802077; \n\tWed, 11 Jul 2018 00:23:22 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org,\n\tYongseok Koh <yskoh@mellanox.com>", "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Date": "Wed, 11 Jul 2018 09:22:38 +0200", "Message-Id": "<d3d01c2289c25c3e6faa224ec59eff801a2076b8.1531293415.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1531293415.git.nelio.laranjeiro@6wind.com>", "References": "<cover.1530111623.git.nelio.laranjeiro@6wind.com>\n\t<cover.1531293415.git.nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH v3 05/21] net/mlx5: add flow queue action", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nAcked-by: Yongseok Koh <yskoh@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 97 ++++++++++++++++++++++++++++++++----\n 1 file changed, 86 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 036a8d440..6041a4573 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -50,6 +50,7 @@ extern const struct eth_dev_ops mlx5_dev_ops_isolate;\n \n /* Actions that modify the fate of matching traffic. */\n #define MLX5_FLOW_FATE_DROP (1u << 0)\n+#define MLX5_FLOW_FATE_QUEUE (1u << 1)\n \n /** Handles information leading to a drop fate. */\n struct mlx5_flow_verbs {\n@@ -71,7 +72,8 @@ struct rte_flow {\n \t/**< Bit-fields of present layers see MLX5_FLOW_LAYER_*. */\n \tuint32_t fate;\n \t/**< Bit-fields of present fate see MLX5_FLOW_FATE_*. */\n-\tstruct mlx5_flow_verbs verbs; /* Verbs drop flow. */\n+\tstruct mlx5_flow_verbs verbs; /* Verbs flow. */\n+\tuint16_t queue; /**< Destination queue to redirect traffic to. */\n };\n \n static const struct rte_flow_ops mlx5_flow_ops = {\n@@ -492,6 +494,52 @@ mlx5_flow_action_drop(const struct rte_flow_action *action,\n \treturn size;\n }\n \n+/**\n+ * Convert the @p action into @p flow after ensuring the NIC will understand\n+ * and process it correctly.\n+ *\n+ * @param[in] dev\n+ * Pointer to Ethernet device structure.\n+ * @param[in] action\n+ * Action configuration.\n+ * @param[in, out] flow\n+ * Pointer to flow structure.\n+ * @param[out] error\n+ * Pointer to error structure.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_flow_action_queue(struct rte_eth_dev *dev,\n+\t\t const struct rte_flow_action *action,\n+\t\t struct rte_flow *flow,\n+\t\t struct rte_flow_error *error)\n+{\n+\tstruct priv *priv = dev->data->dev_private;\n+\tconst struct rte_flow_action_queue *queue = action->conf;\n+\n+\tif (flow->fate)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t action,\n+\t\t\t\t\t \"multiple fate actions are not\"\n+\t\t\t\t\t \" supported\");\n+\tif (queue->index >= priv->rxqs_n)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n+\t\t\t\t\t &queue->index,\n+\t\t\t\t\t \"queue index out of range\");\n+\tif (!(*priv->rxqs)[queue->index])\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n+\t\t\t\t\t &queue->index,\n+\t\t\t\t\t \"queue is not configured\");\n+\tflow->queue = queue->index;\n+\tflow->fate |= MLX5_FLOW_FATE_QUEUE;\n+\treturn 0;\n+}\n+\n /**\n * Convert the @p action into @p flow after ensuring the NIC will understand\n * and process it correctly.\n@@ -520,7 +568,7 @@ mlx5_flow_action_drop(const struct rte_flow_action *action,\n * On error, a negative errno value is returned and rte_errno is set.\n */\n static int\n-mlx5_flow_actions(struct rte_eth_dev *dev __rte_unused,\n+mlx5_flow_actions(struct rte_eth_dev *dev,\n \t\t const struct rte_flow_action actions[],\n \t\t struct rte_flow *flow, const size_t flow_size,\n \t\t struct rte_flow_error *error)\n@@ -537,6 +585,9 @@ mlx5_flow_actions(struct rte_eth_dev *dev __rte_unused,\n \t\t\tret = mlx5_flow_action_drop(actions, flow, remain,\n \t\t\t\t\t\t error);\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ACTION_TYPE_QUEUE:\n+\t\t\tret = mlx5_flow_action_queue(dev, actions, flow, error);\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n@@ -661,7 +712,10 @@ mlx5_flow_remove(struct rte_eth_dev *dev, struct rte_flow *flow)\n \t\t}\n \t}\n \tif (flow->verbs.hrxq) {\n-\t\tmlx5_hrxq_drop_release(dev);\n+\t\tif (flow->fate & MLX5_FLOW_FATE_DROP)\n+\t\t\tmlx5_hrxq_drop_release(dev);\n+\t\telse if (flow->fate & MLX5_FLOW_FATE_QUEUE)\n+\t\t\tmlx5_hrxq_release(dev, flow->verbs.hrxq);\n \t\tflow->verbs.hrxq = NULL;\n \t}\n }\n@@ -683,17 +737,38 @@ static int\n mlx5_flow_apply(struct rte_eth_dev *dev, struct rte_flow *flow,\n \t\tstruct rte_flow_error *error)\n {\n-\tflow->verbs.hrxq = mlx5_hrxq_drop_new(dev);\n-\tif (!flow->verbs.hrxq)\n-\t\treturn rte_flow_error_set\n-\t\t\t(error, errno,\n-\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t NULL,\n-\t\t\t \"cannot allocate Drop queue\");\n+\tif (flow->fate & MLX5_FLOW_FATE_DROP) {\n+\t\tflow->verbs.hrxq = mlx5_hrxq_drop_new(dev);\n+\t\tif (!flow->verbs.hrxq)\n+\t\t\treturn rte_flow_error_set\n+\t\t\t\t(error, errno,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t NULL,\n+\t\t\t\t \"cannot allocate Drop queue\");\n+\t} else if (flow->fate & MLX5_FLOW_FATE_QUEUE) {\n+\t\tstruct mlx5_hrxq *hrxq;\n+\n+\t\thrxq = mlx5_hrxq_get(dev, rss_hash_default_key,\n+\t\t\t\t rss_hash_default_key_len, 0,\n+\t\t\t\t &flow->queue, 1, 0, 0);\n+\t\tif (!hrxq)\n+\t\t\thrxq = mlx5_hrxq_new(dev, rss_hash_default_key,\n+\t\t\t\t\t rss_hash_default_key_len, 0,\n+\t\t\t\t\t &flow->queue, 1, 0, 0);\n+\t\tif (!hrxq)\n+\t\t\treturn rte_flow_error_set(error, rte_errno,\n+\t\t\t\t\tRTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\tNULL,\n+\t\t\t\t\t\"cannot create flow\");\n+\t\tflow->verbs.hrxq = hrxq;\n+\t}\n \tflow->verbs.flow =\n \t\tmlx5_glue->create_flow(flow->verbs.hrxq->qp, flow->verbs.attr);\n \tif (!flow->verbs.flow) {\n-\t\tmlx5_hrxq_drop_release(dev);\n+\t\tif (flow->fate & MLX5_FLOW_FATE_DROP)\n+\t\t\tmlx5_hrxq_drop_release(dev);\n+\t\telse\n+\t\t\tmlx5_hrxq_release(dev, flow->verbs.hrxq);\n \t\tflow->verbs.hrxq = NULL;\n \t\treturn rte_flow_error_set(error, errno,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n", "prefixes": [ "v3", "05/21" ] }{ "id": 42798, "url": "