Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42796/?format=api
{ "id": 42796, "url": "http://patches.dpdk.org/api/patches/42796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/03092689aa33878a03193348a69bfbf0aeb091dd.1531293415.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<03092689aa33878a03193348a69bfbf0aeb091dd.1531293415.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/03092689aa33878a03193348a69bfbf0aeb091dd.1531293415.git.nelio.laranjeiro@6wind.com", "date": "2018-07-11T07:22:36", "name": "[v3,03/21] net/mlx5: replace verbs priorities by flow", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "609728b9efd2af56d429d250b2aabea0b6c34183", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/03092689aa33878a03193348a69bfbf0aeb091dd.1531293415.git.nelio.laranjeiro@6wind.com/mbox/", "series": [ { "id": 512, "url": "http://patches.dpdk.org/api/series/512/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=512", "date": "2018-07-11T07:22:33", "name": "net/mlx5: flow rework", "version": 3, "mbox": "http://patches.dpdk.org/series/512/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42796/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/42796/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A4E3F1B466;\n\tWed, 11 Jul 2018 09:23:27 +0200 (CEST)", "from mail-wr1-f67.google.com (mail-wr1-f67.google.com\n\t[209.85.221.67]) by dpdk.org (Postfix) with ESMTP id D56C81B484\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 09:23:20 +0200 (CEST)", "by mail-wr1-f67.google.com with SMTP id c13-v6so16974327wrt.1\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 00:23:20 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tt10-v6sm31314212wre.95.2018.07.11.00.23.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 11 Jul 2018 00:23:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=qjBo8v3AxKvoiPxec9Q3pQKBaqGYlE1KG6Z5NSIWHgI=;\n\tb=RJrvCjcmK6rz5w/Zp9w3O8OrkYS2FAr5GQUPmUclsndNy/jbOnwO11phfyaIryIdt1\n\tPm6hQtNwYm/PTfEkZ0OU0AxN3Q3gycDiMT0kIloWVZmRXqq/W+nU0dukrdt8xOYI9mCv\n\tU9nDEzB0Q7aazCN2iDKlg7DWHFamRc1D+5rss0oH8VmkylPwZK8avK+mkZsaNgX+C0TQ\n\t/uKSqbKwHhSIiM/i+KkyYzy1zx7PyBPxs0HKk4SRkAzGclObnBterhagWudkBBNED8yd\n\tcRzcemS3iZ5Pfs1XCNWlIT18v+ybLBj/sPsuFzaNJoBnLgY6pIM24CDTnFDFt7StV99O\n\tGKHQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=qjBo8v3AxKvoiPxec9Q3pQKBaqGYlE1KG6Z5NSIWHgI=;\n\tb=KvMy7CK3+i4FtZqJqdDLyP6qU1GLZZeUBJuZx8xeNGutnaKNZAWKJ6Ad0fnbXkL910\n\tF6b+q4QYm2xdU9d0SNGBd3AdJCy4nnO9JNxTlMn53GHOO/Irs63sCPi436gMGT5/563j\n\t5t8OChZ+M5+GM0Wxdb7jv+/msnqLaE5C8CLmi5XUYE1kVH2LKxH6gApvMQ5pH8fDHu7Y\n\toaGRME78umLZyj7C+Ge4z3MIAbD+k/eGIomXN6ct6uNtquiRmxSTgVZJpYYvFCxeYQa2\n\tnlQsfUA0JM5zECqSNnHxAwfg4HXWUX3vqUJGswhz/OV3vxbaudGk4n9j2KgrWeUu/eX0\n\tipCw==", "X-Gm-Message-State": "APt69E0dzZEm8x9FH5hyslLG7eLvABWtgXrIgdvq3kMjVovCvsu7skrn\n\tZASKlVgywuz/TRBKDnNE4UKWOLyfKA==", "X-Google-Smtp-Source": "AAOMgpdfWmX2q7iahavop6rbdCKNHS/5HVCSlOAsZhfpIkkaE198ImLKFZzNmC68kdvxdN4Dozs2Iw==", "X-Received": "by 2002:a5d:4e49:: with SMTP id\n\tr9-v6mr18529439wrt.27.1531293800446; \n\tWed, 11 Jul 2018 00:23:20 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org,\n\tYongseok Koh <yskoh@mellanox.com>", "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Date": "Wed, 11 Jul 2018 09:22:36 +0200", "Message-Id": "<03092689aa33878a03193348a69bfbf0aeb091dd.1531293415.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1531293415.git.nelio.laranjeiro@6wind.com>", "References": "<cover.1530111623.git.nelio.laranjeiro@6wind.com>\n\t<cover.1531293415.git.nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH v3 03/21] net/mlx5: replace verbs priorities by\n\tflow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previous work introduce verbs priorities, whereas the PMD is making\ntranslation between Flow priority into Verbs. Rename this to make more\nsense on what the PMD has to translate.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nAcked-by: Yongseok Koh <yskoh@mellanox.com>\n---\n drivers/net/mlx5/mlx5.c | 15 ++++-----------\n drivers/net/mlx5/mlx5.h | 4 ++--\n drivers/net/mlx5/mlx5_flow.c | 24 ++++++++++++------------\n 3 files changed, 18 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex e9780ac8f..74248f098 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -717,7 +717,6 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \tunsigned int tunnel_en = 0;\n \tunsigned int mpls_en = 0;\n \tunsigned int swp = 0;\n-\tunsigned int verb_priorities = 0;\n \tunsigned int mprq = 0;\n \tunsigned int mprq_min_stride_size_n = 0;\n \tunsigned int mprq_max_stride_size_n = 0;\n@@ -1139,16 +1138,10 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \t/* Store device configuration on private structure. */\n \tpriv->config = config;\n \t/* Supported Verbs flow priority number detection. */\n-\tif (verb_priorities == 0) {\n-\t\terr = mlx5_verbs_max_prio(eth_dev);\n-\t\tif (err < 0) {\n-\t\t\tDRV_LOG(ERR, \"port %u wrong Verbs flow priorities\",\n-\t\t\t\teth_dev->data->port_id);\n-\t\t\tgoto error;\n-\t\t}\n-\t\tverb_priorities = err;\n-\t}\n-\tpriv->config.max_verbs_prio = verb_priorities;\n+\terr = mlx5_flow_discover_priorities(eth_dev);\n+\tif (err < 0)\n+\t\tgoto error;\n+\tpriv->config.flow_prio = err;\n \t/*\n \t * Once the device is added to the list of memory event\n \t * callback, its global MR cache table cannot be expanded\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 227429848..9949cd3fa 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -122,7 +122,7 @@ struct mlx5_dev_config {\n \t\tunsigned int min_rxqs_num;\n \t\t/* Rx queue count threshold to enable MPRQ. */\n \t} mprq; /* Configurations for Multi-Packet RQ. */\n-\tunsigned int max_verbs_prio; /* Number of Verb flow priorities. */\n+\tunsigned int flow_prio; /* Number of flow priorities. */\n \tunsigned int tso_max_payload_sz; /* Maximum TCP payload for TSO. */\n \tunsigned int ind_table_max_size; /* Maximum indirection table size. */\n \tint txq_inline; /* Maximum packet size for inlining. */\n@@ -317,7 +317,7 @@ int mlx5_traffic_restart(struct rte_eth_dev *dev);\n \n /* mlx5_flow.c */\n \n-int mlx5_verbs_max_prio(struct rte_eth_dev *dev);\n+int mlx5_flow_discover_priorities(struct rte_eth_dev *dev);\n void mlx5_flow_print(struct rte_flow *flow);\n int mlx5_flow_validate(struct rte_eth_dev *dev,\n \t\t const struct rte_flow_attr *attr,\ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 5e325be37..8fdc6d7bb 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -76,17 +76,17 @@ struct ibv_spec_header {\n };\n \n /**\n- * Get the maximum number of priority available.\n+ * Discover the maximum number of priority available.\n *\n * @param[in] dev\n * Pointer to Ethernet device.\n *\n * @return\n- * number of supported Verbs flow priority on success, a negative errno\n- * value otherwise and rte_errno is set.\n+ * number of supported flow priority on success, a negative errno value\n+ * otherwise and rte_errno is set.\n */\n int\n-mlx5_verbs_max_prio(struct rte_eth_dev *dev)\n+mlx5_flow_discover_priorities(struct rte_eth_dev *dev)\n {\n \tstruct {\n \t\tstruct ibv_flow_attr attr;\n@@ -106,25 +106,25 @@ mlx5_verbs_max_prio(struct rte_eth_dev *dev)\n \t\t},\n \t};\n \tstruct ibv_flow *flow;\n-\tuint32_t verb_priorities;\n \tstruct mlx5_hrxq *drop = mlx5_hrxq_drop_new(dev);\n+\tuint16_t vprio[] = { 8, 16 };\n+\tint i;\n \n \tif (!drop) {\n \t\trte_errno = ENOTSUP;\n \t\treturn -rte_errno;\n \t}\n-\tfor (verb_priorities = 0; 1; verb_priorities++) {\n-\t\tflow_attr.attr.priority = verb_priorities;\n-\t\tflow = mlx5_glue->create_flow(drop->qp,\n-\t\t\t\t\t &flow_attr.attr);\n+\tfor (i = 0; i != RTE_DIM(vprio); i++) {\n+\t\tflow_attr.attr.priority = vprio[i] - 1;\n+\t\tflow = mlx5_glue->create_flow(drop->qp, &flow_attr.attr);\n \t\tif (!flow)\n \t\t\tbreak;\n \t\tclaim_zero(mlx5_glue->destroy_flow(flow));\n \t}\n \tmlx5_hrxq_drop_release(dev);\n \tDRV_LOG(INFO, \"port %u flow maximum priority: %d\",\n-\t\tdev->data->port_id, verb_priorities);\n-\treturn verb_priorities;\n+\t\tdev->data->port_id, vprio[i - 1]);\n+\treturn vprio[i - 1];\n }\n \n /**\n@@ -318,7 +318,7 @@ mlx5_ctrl_flow_vlan(struct rte_eth_dev *dev,\n \tstruct priv *priv = dev->data->dev_private;\n \tconst struct rte_flow_attr attr = {\n \t\t.ingress = 1,\n-\t\t.priority = priv->config.max_verbs_prio - 1,\n+\t\t.priority = priv->config.flow_prio - 1,\n \t};\n \tstruct rte_flow_item items[] = {\n \t\t{\n", "prefixes": [ "v3", "03/21" ] }