Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42792/?format=api
{ "id": 42792, "url": "http://patches.dpdk.org/api/patches/42792/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1531293723-930-1-git-send-email-kkokkilagadda@caviumnetworks.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1531293723-930-1-git-send-email-kkokkilagadda@caviumnetworks.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1531293723-930-1-git-send-email-kkokkilagadda@caviumnetworks.com", "date": "2018-07-11T07:22:03", "name": "net/thunderx: Block sq door writes on zero pkts", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3a9df8e64188775c5764d629a2e5710f59914177", "submitter": { "id": 1075, "url": "http://patches.dpdk.org/api/people/1075/?format=api", "name": "Kiran Kumar", "email": "kkokkilagadda@caviumnetworks.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1531293723-930-1-git-send-email-kkokkilagadda@caviumnetworks.com/mbox/", "series": [ { "id": 511, "url": "http://patches.dpdk.org/api/series/511/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=511", "date": "2018-07-11T07:22:03", "name": "net/thunderx: Block sq door writes on zero pkts", "version": 1, "mbox": "http://patches.dpdk.org/series/511/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42792/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42792/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2434E1B427;\n\tWed, 11 Jul 2018 09:22:34 +0200 (CEST)", "from NAM01-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam01on0043.outbound.protection.outlook.com [104.47.32.43])\n\tby dpdk.org (Postfix) with ESMTP id 17DDA548B\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 09:22:32 +0200 (CEST)", "from kkokkilagadda.caveonetworks.com (111.93.218.67) by\n\tDM6PR07MB4954.namprd07.prod.outlook.com (2603:10b6:5:25::11) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.952.17; Wed, 11 Jul 2018 07:22:27 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=y5pqlEm76KAiXgMnAATB9zNZzQcgPR+Tqt8xiXKnEMo=;\n\tb=lzCGRKJk5DL8CPmSVv3IACG3C8HASYf71B7K1SdNkqEe1HC/wugP2Y45QhT+iD9HKEBf2RbuaPs2ce1CbjKVV48XWX7fqyto4YbErTj/wBwx7K4h3ZSHRGlZQPIUbI8oe1IWeLt/oDWHYahTRY3u6QLIOBeMmFRM3vH099zU5IE=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Kiran.Kokkilagadda@cavium.com; ", "From": "Kiran Kumar <kkokkilagadda@caviumnetworks.com>", "To": "dev@dpdk.org", "Cc": "jerin.jacob@caviumnetworks.com, maciej.czekaj@caviumnetworks.com,\n\tKiran Kumar <kkokkilagadda@caviumnetworks.com>", "Date": "Wed, 11 Jul 2018 12:52:03 +0530", "Message-Id": "<1531293723-930-1-git-send-email-kkokkilagadda@caviumnetworks.com>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[111.93.218.67]", "X-ClientProxiedBy": "BMXPR01CA0015.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:d::25) To DM6PR07MB4954.namprd07.prod.outlook.com\n\t(2603:10b6:5:25::11)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "2b95ebde-e25f-4858-6add-08d5e6ff0fa9", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);\n\tSRVR:DM6PR07MB4954; ", "X-Microsoft-Exchange-Diagnostics": [ "1; DM6PR07MB4954;\n\t3:Bw1T0ks2/E+uY7Y6sIqNTpKYvyrtnqbtWHUrzVNg/rkvjc1zslosYEAnRAn3Rqw3UMe3ArXcEzd6zkLccivkUdbiiUoEpqf8FSwdVaQTu8/Ioe3AJx0XyriJcCzy5GSr0OtCd/Q3sXIsXFEm27jVrAz8yoNzmemK1jicy+zvi5YRTpNqcQs2T4NGkFEuoBglV++V2K/K9Tc7tN8DJu/UYd/efL/WgNvdC0XecY5N0beft+xdpZN480L6seEAMxy3;\n\t25:9cIiw+RljnItf/eGOVjeVK1N4ITOVXkXqGNVk10ihgDphKj62FOvfuECQklPMv+eDpSksPL3DFHrBToWlsJo2u3/vGeOe1UPpwfM7H8LsNvll+PG3ZovXzzkwgiY/+cW800lf9ssryusjm/YL3gMib6J5mbdUwyUSC0GVo9dksBtCs85t1fxrFU0pClz5yPQLXBxBT/g7xum2HRUBmCK0e5vTRDC90OQtyaQrVVTCi5QwUT7nMs0QE8r1WZ4u1sXgDZbV+cGZe7tFuz3XfhuCQwu0uzpgcuxBoMjWQwbmBFCkdGn+6YtTR4yxxkm+SbfQ2mJaePmf8irO2BkcPFFEA==;\n\t31:3kvFoZ5IwWl/yRtecN9eynPZRama8rGRSQkbaIqjXA2+yQmhenBSZp9EBmro0E6KcMkEWaJt/ldJibhPp3XXxh9TXNF5+vsCiFqK2qswSytjeMaSMgEcAnFQmjhtxDtTqEjyx3VbbRvkQplCq4t6KTUyXGr2gX0KIL8n3UsjsXz0peU2u1WmqWLC8pmzU0Q4P1CQ9DzUp+R7EYCDt1ZyyFCa2mAIWiFwzR0FksErEYk=", "1; DM6PR07MB4954;\n\t20:2475u3zVY4t1PWBcgK55iF7A1iOstT2pAk8CygLmKzZW8GwbmujpuFlmVn3A8Q2kbJdlhIYmlmdlOzRLRfD8iZjlJ/TNayDka2pcUYenVkmDT4cyIJ63fBvyqYPIjMneZXrg10l5rnhgd30ElB/BnA/VVcG486mbD3nICQmyGE6RoU/pOJE6zinMtFhkwyZ1k6zYV4qGaNfAp8Zos1LPPpsi3Zf50Q2kPj4oI8/hMwa+M11ONdOsu/4onSKfYM7aegwTZYVzJwF9x6K5QMKtxnRXITXJ36b/NV2UJxCPJhqdhZT1SOFdG7PkeRaVtX+tmaccTbpga3FCqC3U//li/lAyPnOE61okEPImJAOItHqEvWbCWW9CbINn7nGF3pfpotQg1Q64cUnNbOs17UjbE2XcH7Dh2PKBNUksEbaKRKvtImKb8vi3F8V2T8Wgr07wAhE8CIg76/JPBbEJAnzPsAGbe3RhFc2zSb4QEnV14d3tzLO8cb0ZX8iz5kd3hnpflZjwxVs8kEdhieI2bOSs+cVYE3CsAFr/ERCFkcts5bjMyGwHbj1CNjU9lSbuYiksMEOx48O+DWkkcGz9bCWMhwOF3w65UpUHj3SnTBaypaQ=;\n\t4:UDbC/LAbT+ZrUPD61fQizECwU1mlt2piWqafGNbqIdptKWXnszcL16gK8ZI1YNFuqnwxR31Z+oCMlUejkLsrWSGZweWzjcAMU8d0WLAFwWdxzBxFvgIKyi094QpWmTl6NZApD4r1B9ypWBEREyvIS3VnM84AT8LdQqzxHJCZazMYU2zhoc/TkfT1yPw5bCToNHxs4/dIb1XZhcMhWHLMk4MxpuR5HYp8yTF3cvFXKNecM+xPk6OLgDZtdVKqLK9zSpwSAR1uv1M+j74pQNZAgw==", "=?us-ascii?Q?1; DM6PR07MB4954;\n\t23:28QcVOgPTpX939Gc5JX0J1yRp/RyUc24XkjVV7Ofo?=\n\tKV/CnhWefUrUIEBDJwAeCGEmbY5QUQ96pOwZFnNwSCMUBzeTWpMNuezeUbfySSotYDl0rXLlm2fKIwXHebxJLOCJeJrGhFnZCvhWOAeRD9Fv7/2Rt2OeuBkdgbeRx8dN1gfTvevANu6YRzU7Wps+Uzmm0Mohbd4FhQp2v5IipFRSBxgnzmOWGh5nbflF3SXqBrI7nl0EzpvSlBA2XoMvULxctwveitm8IJQJirS753IW/2ug+4BCE4KGlekR/vvftjFKwl1PIqE0XVnvpFVwzaVCfkFgXvOFtJLOBzDscF5BsTaALNwQFzgAKEaLl+qP4OhXdRjBjrk+//GfkRw+9e5XiejlZjUlWpvGEf2swOwENe+bzFmZ1MT56lknnixFQox7eoZJp/fbQE/5lgF8wk85NnbuCQ0zN9ZCntnWk0aanpxCN9+Zj1Y62OBnnhfp7/kY1L8QEhPJjP6SG/aNZ75i7U9oRGYQaUzK7zZYWk7+7g0qIRZl+QsHSYnDXpDc8goKYk1kuMxuuHFHFYU1csgtiPM/VfCny28vUABjk3sfJO0RIVyT13MKXxoFgY93P5XLLx3f+GVrqnFXWdDyRdtApqLrIKi3aEvVaHREphllpFU7NjGNar3avSQrubPl8r6vXpZnAr0iwfTv/jNFFP0lfuCqLPfNswyRdCfUAntnS+EdnujL6FMSzQZIj79N/U++JJEKjetyAMzYKhfHVJK8qQUM9utGzuL/8A5HPOJmLjcp3XiT7mRpcRUvmyyeSSdmVajodUeOG0CaK6sHV4WU34dj60+3IlRhOK40yMsbe6W81kkJnLherju5cJk6m+d30zfLSxM2VM+vLBqFgL8Gi8eJQMQox96TLiwFFXdOCKx5tn4HCnmiQq0FoiSlCY+g1n/OY8+0dOH/HSLwLAT1QdJbpxrnEpPLEYTIKi/zmVg7kGX0G8HuJHVaC1LRjyYcG1lSyc65QoRF6bIKnmOxnhAGJNiN1CbjzfFatqDrfDByTA10MhabuZffW3eS2V3iWQ5bBC4SoHvK75U8RF2ObcAsjum5ThsjlOPJYLGevkohHILfgERzQJA5hrG48HwDX+DoaCi+cE3Q2Tdmz0kOZKjTB9VQ0tIyTqiXTvaw3H0p9iy8q7w5takFa00r0UKg/qINHrt+ojQwGrCn+YGz9lVrUzt+7V3QP/13Ms7S93VQ9LK4Bsem870Zo0Xxx3EyW2tAszL3uL5I6BY8WzK2+OtRwrGq85RoTXQDDkbGQSC7nrCZJkOEvXey8Edfiw=", "1; DM6PR07MB4954;\n\t6:L6p1aRjgwtKL4s+IudpuJjltQuj8pML1dubxtE8WXusJjvyRY51vXSDFQp2kDGbalWKACHzK8o/bY2mZ9SNOuIo/GtPgQfwKFFg+mb0tbeF6iIaQ8aGngKLXKG9xZCcfvaGW/J1GOyojRxtdU6DSuT5yzNyjVlCP9cLmehvwjpbhbaR9TZSc8wh4yncY3wPytbQxO8CCvdGDGBuyF5wT8Rn5B1Ox4P6C6MZhEnS3ApKvHY24Wv0gJt0eugeb1vGj7Rffa8bbIzLRFS3B5QHtyIURkcIy3X7WGb8DIaQnn8zkNq8ODtsUdOirZSanlTb+Z0hxAOL8ysGWB/UCkxk9iO+X58VvDc61nie1RlzqAwYogLoUDjQZ8Yl2bzn17fq1543ZFBH7j3gjdCx3ZQdxZETOpDYj875aCqqwBMNshZekdbZ7dNcNl+aY+7FY9LOuYpVCQ76Di0Ou1W+ncz+bgg==;\n\t5:274oeck/vJEDMGGh8kYN9Jkr3Ml+PA1BicXXismcva9Z9aTD38Krcqg5hzjfAcF8tYq7eZb0srDwZ1HEK8gS6BAKqcMQ1wZD8RJaAsL850ROGyR3UVCh27V3vysMT+XwUPe0LrE+QxQfcBUBitYWLfY+0qSTNWxMC0rLLTuDHnI=;\n\t24:Tr7MgiHaj+Mv6b8PRAeFFB3L/UvOXDfgsj3uFc0Eh0dJGzumkHsvsHrNpL/7wYNsxfT79wXgwYlBoFXLtlJAym+eVk4a0hhr7S47uRGQ1ro=", "1; DM6PR07MB4954;\n\t7:HfwZQSw8GqV1LnKVKkpXspIacQVpe9bbwgBUucU4T172RK2DfGgXrx0fs1xCOUW6TiRe7i5Q/MO+OBaWM63vf/UQvu+JVfzZlP/HkZ/aDPCeND2VbDo69doUZ0sNzdRQbcr8jB/WGS82QTly5sEB0TkAz6yF6nchN9AfrO8tfaUeLQSW3mLlgLN4xyXQqdF8HIx3/RdJ9wlX4FWKd+NEf6bgp/1ZDKzm4V8JhaxShwIAn0zbpCJqm/gpqfS6OA9I" ], "X-MS-TrafficTypeDiagnostic": "DM6PR07MB4954:", "X-Microsoft-Antispam-PRVS": "<DM6PR07MB4954B801565140721B3BCFDCE65A0@DM6PR07MB4954.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231311)(944501410)(52105095)(10201501046)(93006095)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);\n\tSRVR:DM6PR07MB4954; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB4954; ", "X-Forefront-PRVS": "0730093765", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(376002)(39860400002)(366004)(346002)(136003)(189003)(199004)(97736004)(48376002)(50466002)(68736007)(107886003)(6486002)(53936002)(50226002)(2361001)(6116002)(25786009)(3846002)(5009440100003)(36756003)(6512007)(4326008)(66066001)(105586002)(106356001)(42882007)(956004)(2616005)(486006)(476003)(69596002)(16586007)(386003)(6506007)(2351001)(6666003)(6916009)(1857600001)(305945005)(7736002)(5660300001)(16526019)(186003)(26005)(47776003)(52116002)(81166006)(53416004)(81156014)(8676002)(2906002)(8936002)(72206003)(316002)(51416003)(478600001)(42262002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB4954;\n\tH:kkokkilagadda.caveonetworks.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "Received-SPF": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "dulrPnyclifoN7/rl1UAXWikuuu0R0vKjGI73KzWmU53BouuAMX1rlcrrnpnasrjYhGkePN1fCSzmmKhT8EYzujKMLbi0++SZspHblXGmJphDRqaJCFylIEzTccga9CMm8SUMWjXD4jaHfg8ko7y7vEGM+k4xCNN9TkpzceuQnjWXl8MxYhxZ0z4JzCw5EhIef1ICb3DE/WqwGNGBLynHCO5V6bZ2ijsdYUC52XY8eG+Dcv989DEnaQotHp+4JgSqQz8fnE/AO+lWnnlWHXOS/w9ZnyVBwrENOU3TV9v4kLH8kl2jP9sz5+s4y1DulSuyz9s5+2kV3lOzYLfWPIBH/hvBVylBybo/negoafTniU=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "caviumnetworks.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 Jul 2018 07:22:27.8250\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "2b95ebde-e25f-4858-6add-08d5e6ff0fa9", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR07MB4954", "Subject": "[dpdk-dev] [PATCH] net/thunderx: Block sq door writes on zero pkts", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "With current code, we are performing sq door writes even with 0 pkts.\nthis will create pressure on register bus. This patch will block these\nwrites.\n\nFixes: 1c421f18e0 (\"net/thunderx: add single and multi-segment Tx\")\n\nSigned-off-by: Kiran Kumar <kkokkilagadda@caviumnetworks.com>\n---\n drivers/net/thunderx/nicvf_rxtx.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/thunderx/nicvf_rxtx.c b/drivers/net/thunderx/nicvf_rxtx.c\nindex 72305d9..8075a8e 100644\n--- a/drivers/net/thunderx/nicvf_rxtx.c\n+++ b/drivers/net/thunderx/nicvf_rxtx.c\n@@ -162,12 +162,14 @@ nicvf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\tfree_desc -= TX_DESC_PER_PKT;\n \t}\n \n-\tsq->tail = tail;\n-\tsq->xmit_bufs += i;\n-\trte_wmb();\n+\tif (likely(i)) {\n+\t\tsq->tail = tail;\n+\t\tsq->xmit_bufs += i;\n+\t\trte_wmb();\n \n-\t/* Inform HW to xmit the packets */\n-\tnicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT);\n+\t\t/* Inform HW to xmit the packets */\n+\t\tnicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT);\n+\t}\n \treturn i;\n }\n \n", "prefixes": [] }