Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42709/?format=api
{ "id": 42709, "url": "http://patches.dpdk.org/api/patches/42709/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1531227098-29564-3-git-send-email-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1531227098-29564-3-git-send-email-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1531227098-29564-3-git-send-email-jia.guo@intel.com", "date": "2018-07-10T12:51:36", "name": "[v4,2/4] net/ixgbe: install ethdev hotplug handler in ixgbe", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d20895d09f239836830caf368096ab273fcac3d6", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1531227098-29564-3-git-send-email-jia.guo@intel.com/mbox/", "series": [ { "id": 494, "url": "http://patches.dpdk.org/api/series/494/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=494", "date": "2018-07-10T12:51:34", "name": "Enable eal hotplug event handler in ethdev", "version": 4, "mbox": "http://patches.dpdk.org/series/494/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42709/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/42709/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4D3641B42D;\n\tTue, 10 Jul 2018 14:54:01 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id A190A1B3AA\n\tfor <dev@dpdk.org>; Tue, 10 Jul 2018 14:53:59 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t10 Jul 2018 05:53:59 -0700", "from jeffguo-z170x-ud5.sh.intel.com (HELO localhost.localdomain)\n\t([10.67.104.10])\n\tby fmsmga004.fm.intel.com with ESMTP; 10 Jul 2018 05:53:55 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,334,1526367600\"; d=\"scan'208\";a=\"70159590\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tgaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,\n\tmotih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com,\n\tbernard.iremonger@intel.com, arybchenko@solarflare.com", "Cc": "jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\tjia.guo@intel.com, helin.zhang@intel.com", "Date": "Tue, 10 Jul 2018 20:51:36 +0800", "Message-Id": "<1531227098-29564-3-git-send-email-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1531227098-29564-1-git-send-email-jia.guo@intel.com>", "References": "<1530787185-5915-1-git-send-email-jia.guo@intel.com>\n\t<1531227098-29564-1-git-send-email-jia.guo@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 2/4] net/ixgbe: install ethdev hotplug handler\n\tin ixgbe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch aim to enable hotplug detect in ixgbe PMD. Firstly it\nset the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug\nability, and then use rte_eth_dev_event_handler_install to install\nthe hotplug event handler for ethdev. When eal detect the hotplug event,\nit will call the ethdev callback to process it. If the event is hotplug\nremoval, it will trigger the RTE_ETH_EVENT_INTR_RMV event into ethdev\ncallback to let app process the hotplug for this ethdev.\n\nThis is an example for other driver, that if any driver support hotplug\nfeature could be use this way to install hotplug handler.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\nv4->v3:\nchange to use eal device event handler install api\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 87d2ad0..e7ae9bf 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1678,6 +1678,9 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev)\n \trte_intr_enable(intr_handle);\n \tixgbevf_intr_enable(eth_dev);\n \n+\t/* install the dev event handler for ethdev. */\n+\trte_eth_dev_event_handler_install(eth_dev);\n+\n \tPMD_INIT_LOG(DEBUG, \"port %d vendorID=0x%x deviceID=0x%x mac.type=%s\",\n \t\t eth_dev->data->port_id, pci_dev->id.vendor_id,\n \t\t pci_dev->id.device_id, \"ixgbe_mac_82599_vf\");\n@@ -1718,6 +1721,9 @@ eth_ixgbevf_dev_uninit(struct rte_eth_dev *eth_dev)\n \trte_intr_callback_unregister(intr_handle,\n \t\t\t\t ixgbevf_dev_interrupt_handler, eth_dev);\n \n+\t/* uninstall the dev event handler for ethdev. */\n+\trte_eth_dev_event_handler_uninstall(eth_dev);\n+\n \treturn 0;\n }\n \n@@ -1801,7 +1807,7 @@ static int eth_ixgbe_pci_remove(struct rte_pci_device *pci_dev)\n static struct rte_pci_driver rte_ixgbe_pmd = {\n \t.id_table = pci_id_ixgbe_map,\n \t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |\n-\t\t RTE_PCI_DRV_IOVA_AS_VA,\n+\t\t RTE_PCI_DRV_IOVA_AS_VA | RTE_PCI_DRV_INTR_RMV,\n \t.probe = eth_ixgbe_pci_probe,\n \t.remove = eth_ixgbe_pci_remove,\n };\n", "prefixes": [ "v4", "2/4" ] }