Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42482/?format=api
{ "id": 42482, "url": "http://patches.dpdk.org/api/patches/42482/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1530864613-11754-5-git-send-email-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530864613-11754-5-git-send-email-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530864613-11754-5-git-send-email-hemant.agrawal@nxp.com", "date": "2018-07-06T08:10:02", "name": "[v3,05/16] net/dpaa2: fix the prefetch Rx to honor nb pkts", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "94e7cb91895996ebb08ebc8ef4f92f6ce4b55716", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1530864613-11754-5-git-send-email-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 451, "url": "http://patches.dpdk.org/api/series/451/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=451", "date": "2018-07-06T08:09:58", "name": "[v3,01/16] bus/dpaa: fix phandle support for kernel 4.16", "version": 3, "mbox": "http://patches.dpdk.org/series/451/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42482/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42482/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 962531C460;\n\tFri, 6 Jul 2018 10:12:09 +0200 (CEST)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00088.outbound.protection.outlook.com [40.107.0.88])\n\tby dpdk.org (Postfix) with ESMTP id F27B71C43F;\n\tFri, 6 Jul 2018 10:12:03 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (14.142.187.166) by\n\tAM2PR04MB0755.eurprd04.prod.outlook.com (2a01:111:e400:8411::15) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.23;\n\tFri, 6 Jul 2018 08:12:01 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=MWTxpKvReQoRM5Ph77r1ZW302bvBShlMaY0A1PlFdos=;\n\tb=dLcl7MZ8gaXH3fMADSin8FChi+OGTguaAcxnCdP9yfzALcaiSM4bvKym0dHmL0V4cSzlZp06BqxXx2ZdVEw58tFYg8a3J0sJKAZ2muIdPLuEgT+ZXV1dpVUzyLRi91wbG3edzapJak/OaTNBWwDGxEQDf/PRUqHRBLPwblpZpWU=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=hemant.agrawal@nxp.com; ", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "shreyansh.jain@nxp.com,\n\tstable@dpdk.org", "Date": "Fri, 6 Jul 2018 13:40:02 +0530", "Message-Id": "<1530864613-11754-5-git-send-email-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com>", "References": "<1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com>\n\t<1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[14.142.187.166]", "X-ClientProxiedBy": "PN1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:c00:1::16) To AM2PR04MB0755.eurprd04.prod.outlook.com\n\t(2a01:111:e400:8411::15)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "e92f36c2-d669-4f71-e3f7-08d5e3182783", "X-MS-Office365-Filtering-HT": "Tenant", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);\n\tSRVR:AM2PR04MB0755; ", "X-Microsoft-Exchange-Diagnostics": [ "1; AM2PR04MB0755;\n\t3:1mRuNNsGOc5I9wS3U0GJ+hrb14sp1Cbg+3UHlkKN9DFk9ByCyk0Tn1hYNVTpRQmGoubczEhaN0BCndmQfJUowjxsX5JQ03G2Gc/OQk039Bt4iOUKcC3m8XAf4zIFH/aEvyKgGQmttPXuPJiZA4ipBtXV/QWdfQbdGcwK0JJWfD8jqaat7SYSnrlBdWO+5/EmFvBfrezUaVor9v+CbYa0OTPXBbBindfCJzVGZiGI7HwhXXD4YqgHTioeMVKY5n17;\n\t25:L8WyMt0wM66TpwWwj5MwNUMna0PSdkTn0+atLcZTsSk39uuxqCRnHDFMEnxTYRLSEmKJFTmkgbsEOIMwU3bPsZ9szjvKI8LMOIMeOKHS8PlvjtENZMHfV3uggdXKE9hFA4RmQByTid2u6ZgQJPx52foAmt/1kyWHjTSt2Wf6UICMltdm6TOis92jzderdNhmtFoOP3DTc83wOXOfpNipZYw7GYXo6jBe9cpGD8geU761Wm1LQMq+93xHTdU/8by5LxC+LyrJhD+SmRV5RSPcW4wzG0Zmv2Od3YSzwfIqqrjvc8K1Of6sttKyd+owuEwFl6iTItwRbEQNJPSlKKUtyQ==;\n\t31:hVfxLpw1VMre/REfM+z8aqS+sbPLqYkcdAxrTkltMchk6MpWMkFzLB/IeK5PxEll6S43w9njuS5iY4wFpnnih5Dk3nB2L5AEcXm/nu+q1KdOtyybg5ujfcqPLZGH25MEjyckfr1dk1DQgs+/NWZfC3AVWzJ2MWxJPXqGwpUSuKcO3W3XDQyCx6If6KklNkQUvvcxZs3rcJtwlJPMKuKtjFg1IGwW+0So0gQa6mtK1Hw=", "1; AM2PR04MB0755;\n\t20:al1glhk+qWkWTrts4ZLkX0t5TWR0KPqoB+CdKX3u/F/Nkzsh9Pg7CsflvC/CjxEV3QMziyQKHaGmYHVTSfcFfKbFARmePGiQvz3f40TUSh/mOiPo7v5+S9RP6r9MvvTmR/PgLoBJdbCHcjt2x6FA5Pp/DZPpVWBe5ncNNzn2tlEFOKjp+IvMBMQrnjoY/mG4AJ6aoHWP/pP1ailDyS0zkZJyAhi2L35qNuBRh306IaEW4hVc2WM6uqOEmj6yD9SKc8MOk+OGvraw5QRRIuQYTfQyqE/JdgYZcaR3xzYmJvCStsbRQ/G3mlk99b6zVYTc7oCBC5NZ5BDgdP+ekUkJjB9qkh36bjPr7DuiEHXIsX1i5oKMW8SfJHWY0RVV1Js50HnLs6YhL8Y1LOQOi0dMUUbGlV71wQeSfVzLErqeDXBHyglg3KEs/ZkSqP+1nxRfyumfxue6hfzGzDwy1EENB4LI1AXfuNU+gf3q1RiEZWCmeA6v6YZUqea7O9BedaUI;\n\t4:O2QyFfPHy2l6pcLompx20vzkTpVFpGbNf0LGqbMguOV1H00PanumeWtBtkf7Yg0XRVSpoC/KY/m2C2I55S2gIhTX0ru/6fBCOjyVCkOJ+ekDpl2VXMNRmgjync3LxzdirLeIQTu/TzKDKFuCeGo+uirDqGwgL2ceF5ec8Bs7MJ62QCt9apOKa8jBMh3RrD8gbxJhKD6SFQ4+EofhCQynsHdmmHFuHGihIQyzP7yLaROhQP8o0kM8Ct9kpDOPqR+85ciC05NdCVvVBnidjqRy2jDmE8ffA+xVFt8RCPHMLBbMYxuPmfERjCGTkVl/jluy", "=?us-ascii?Q?1; AM2PR04MB0755;\n\t23:0eGnOqlGF6miKwEj0GUFwAtxt5jmfngQzllfB+8tC?=\n\tuVwZop7D9qSNYMjD8X5/PsTZelRq1yLs9JSoWWVChhRkUN2O0ma/vjjnJVqWazsKbjXi0BphALmi06SPPq9MIp++NcGt+b/HeJWwvQgAFDe+tNmvNehaP43TdUojbUN1NjALUbxsnUjiEHfoLHSFhevjNWs8BtJOU0FuYhsUvtx9tnjvuYMjFPSHgNjk3ZgQqYs/qEQztc1Kr6EOtcB0eHHRXcMRHl5MP503iEPXG86ibd9SiZF14X18SIp64wcKZlByGUS74ttCmMVhl0uTboC5UodC6QRDS+teiTPc6E6Yl0TkHshX5jZ39bY56ytuLsQ9o/cxLJIISk62RRPHcXjDPP1Ov/8ywYqPzrJv5A84whSOo7dgfp+3dyzv4IOqDAYhsmeewhjodLAEMJTBqlQnduJ0Vzxu66ySWelg0yi1A99Tr+OUXzyVDDrvE86VD+U4vJ4eFL0f6PT3xqnrD1xmgKvWolrTQWJulpRJwynEXJZ2PdRMnOBPdqZKoIwPtdbKL2jq2+kBHbZ1+1DVi14CC7DJ8I49ZygZP+Qkz7YQJ4LD9MlLM7XLWdi5dpoY6OZa356SQxGBktkZPzQg4BH2CLQs6nxgl4ALdCqyHKxE3nEAJalY1eOTDaT77W4lRLrF1rtX//f5nTV/c00UW8EOvAo3to2DP+k8uaRACLUyauRKKxmTaOdhArBEkl+EefrEDJ13z/Y6D3YTbQlmS9KAE3wdXCndU23+5au6G236jkdHDLo77LyS9kNxMrSsQt9cFniBIUk5OohxNg25E7wiGgGNJw2o5NiP9MQCjbTResoeg928/AR+INc9V9f0OsuAXB0cp1Bi5lUafz53Pf5pV1OZoLQ2wGTpUOklyUb1qSWwVSp83sZjVPPhgObpMBqwRzZI0Og4dLOmQBQbKrvcdxdv1Dq4QKy7WR/6YkVZzZVYT/Gp7wQyENEEJSN4HUMQpmTU1X6Yn/7hnLPJn/DYOqUxorlMdTvChxcRc9nBUcxHIvkSss+aWEfmkbslArd/AczPzJGm2hbgstyDE1xLZIrvIAmCPUieo64TEhVowpJgWqT6jNvWuuPNKsx4BaUDshSFLXn8EXi3qTw9UPQJDEHOf33WUC2S8u554PfH/4a9px8yzXUj9SyRz0IWG9/HrW9MZnHQK5rMLmmZMRGaWAZEI3ni1s0VEGexznLQd+9osIHxdNwzQQ4M7/86e++VeJISrx2v6H7RswKs/JgGE0ygRl0Ygi0P1JaOzPvWhHl1kpD5EGkUJ30vH8hORdKvRTMycOSOZ2QXJoNa65a", "1; AM2PR04MB0755;\n\t6:x7eBAyPJBLSAJZqx8kqvU+pFd+rx8Kf0hdMfASrPSXWJHL/EvQ86TcJ/gKGEdWqqfNdCE2U7lOz8q3VYWkSY4UV0DU4tqetlhP/Oalz4l3oICBXHHLu666Ih1Ck8xnspKtGcmFij82LHmYs9aaARwkVyg2DsXtgiXl/JKIoDWF2Jmq8U8lIa3Ndc87opBly9074/m7drYeqvW2FaR/uT7zEhcC8VUXYgKtMDfwNLYqCJQX7NddP8jNVHXRqKc7xIbsIwbIc9XShLWV3QhE2aZBKQIgWr18d2XfixNR+we4mlnDsLXLvUQ5talXEExzG/wAS8MTGmvTepeK4+jN4jTcU8ytWFG02jBDTYienufl5cSBozMJUl1G65Tk5NIN7evCetAks7wttZXrvYlx3Llru1SVuk1yJE6HTJgl0Y8uLGg87qlxGFExT/3U3hU2LWABfz/y1AsFcLelD3xu/2XQ==;\n\t5:rgGR82qrz0qzQbUqhmhXWZsf55M3m85vR7X5/lKm0rc0J4t9/R/3pJn5jvpL4OX6Iwp1ymKhGWeA7pcCyP0qAoHKueb0VbFReg8mzljmYJhDmqm/N/ATzaS3jCoUTf5AAsC6eF79J1H5CBzkVqHQdG1QRI7MhOVFmrv2XuHi9hk=;\n\t24:E0487VEZUS8XoF5nRMpD221ftzeM0bdEhzbasktH1DSFd15cm3j+K5Ofg62ojYDxJ0QHzsxwFQRubSppqr2kjENh6WtaBbhdvg9uLXwaj/Q=", "1; AM2PR04MB0755;\n\t7:bvaSi90BJFqNBjdrcML+DzLUqoQaGTalAC7V0TrBQw6MzYXEG6jPkUPlyQOLtoyJ+6F4/dBX9m46KQyR3g3/2oOccegtxz7Ig5kI4EJ0PtdC/5/dJjw0JGeA36VBR+18Nn/gxUb4iGGlK41M1F+/hYPnUoRwM32OInbwv170bEtzbk/gDDIv5XfCNNKuRJAYC0MWQnpCzGtvSVGRlVGpes1yO4Z1Kde8bB+qBzkdhlnJ439Bfm/if8nSmyzWyHVJ" ], "X-MS-TrafficTypeDiagnostic": "AM2PR04MB0755:", "X-Microsoft-Antispam-PRVS": "<AM2PR04MB07552FA4E64F34D8E3DFF56289470@AM2PR04MB0755.eurprd04.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:(185117386973197);", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);\n\tSRVR:AM2PR04MB0755; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0755; ", "X-Forefront-PRVS": "0725D9E8D0", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(39860400002)(396003)(136003)(366004)(346002)(376002)(199004)(189003)(956004)(66066001)(446003)(6116002)(2616005)(476003)(5009440100003)(6916009)(76176011)(186003)(16586007)(14444005)(16526019)(105586002)(478600001)(86362001)(450100002)(44832011)(106356001)(3846002)(4326008)(486006)(11346002)(6486002)(2906002)(25786009)(305945005)(47776003)(50466002)(2361001)(7736002)(5660300001)(6512007)(48376002)(8936002)(68736007)(36756003)(97736004)(55236004)(6506007)(53936002)(26005)(51416003)(50226002)(8676002)(2351001)(81156014)(81166006)(386003)(52116002)(316002)(110426005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0755;\n\tH:bf-netperf1.ap.freescale.net; \n\tFPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; ", "Received-SPF": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "BB+q1/mpFca5TrhERcX3YFBV4XR2yOKG2ge7Ai4Gub7IArxlDUCsh3x4YqSdDx8LNgyUsIr5FoIUcRPH/I83RSqhdhVsfz5F1BFJNT1TD5ZflhFHf/m0PQPelHuFlJTC1ocwGDD6teQZprmacBs9HVbRMwguXN42ZZWy9fU+ROWFjkDLpUp5H1N9jVFElYhyy1keuFpCq905RD2GjjVcxJ0KApOEND5YqnrBi3Ho7z6juiEFZRBFFMU1guiivXOxLgkw8ipjeLhpjB+ElA+3dZh3u2irzQWwE169Bqb7dktyjotiEf+gCLZVMMjhK0bToHkPtwyAb0Hb4SqGnIRbpjOQorEuOB6C45GLzLJ2fak=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "06 Jul 2018 08:12:01.5661\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "e92f36c2-d669-4f71-e3f7-08d5e3182783", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM2PR04MB0755", "Subject": "[dpdk-dev] [PATCH v3 05/16] net/dpaa2: fix the prefetch Rx to honor\n\tnb pkts", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes prefetch rx routine to\nset the next prefetch request to the size of nb_pkts.\nIt assumes that next request would ideally be\nof same size.\n\nFixes: 4bc5ab88dbd6 (\"net/dpaa2: fix Tx only mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\nAcked-by: Shreyansh Jain <shreyansh.jain@nxp.com>\n---\n drivers/net/dpaa2/dpaa2_rxtx.c | 16 +++++++++++-----\n 1 file changed, 11 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c\nindex dac086d..ef109a6 100644\n--- a/drivers/net/dpaa2/dpaa2_rxtx.c\n+++ b/drivers/net/dpaa2/dpaa2_rxtx.c\n@@ -447,6 +447,12 @@ eth_copy_mbuf_to_fd(struct rte_mbuf *mbuf,\n return 0;\n }\n \n+/* This function assumes that caller will be keep the same value for nb_pkts\n+ * across calls per queue, if that is not the case, better use non-prefetch\n+ * version of rx call.\n+ * It will return the packets as requested in previous call without honoring\n+ * the current nb_pkts or bufs space.\n+ */\n uint16_t\n dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n {\n@@ -454,7 +460,7 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tstruct dpaa2_queue *dpaa2_q = (struct dpaa2_queue *)queue;\n \tstruct qbman_result *dq_storage, *dq_storage1 = NULL;\n \tuint32_t fqid = dpaa2_q->fqid;\n-\tint ret, num_rx = 0;\n+\tint ret, num_rx = 0, pull_size;\n \tuint8_t pending, status;\n \tstruct qbman_swp *swp;\n \tconst struct qbman_fd *fd, *next_fd;\n@@ -470,12 +476,12 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t}\n \t}\n \tswp = DPAA2_PER_LCORE_ETHRX_PORTAL;\n-\n+\tpull_size = (nb_pkts > DPAA2_DQRR_RING_SIZE) ?\n+\t\t\t\t\t DPAA2_DQRR_RING_SIZE : nb_pkts;\n \tif (unlikely(!q_storage->active_dqs)) {\n \t\tq_storage->toggle = 0;\n \t\tdq_storage = q_storage->dq_storage[q_storage->toggle];\n-\t\tq_storage->last_num_pkts = (nb_pkts > DPAA2_DQRR_RING_SIZE) ?\n-\t\t\t\t\t DPAA2_DQRR_RING_SIZE : nb_pkts;\n+\t\tq_storage->last_num_pkts = pull_size;\n \t\tqbman_pull_desc_clear(&pulldesc);\n \t\tqbman_pull_desc_set_numframes(&pulldesc,\n \t\t\t\t\t q_storage->last_num_pkts);\n@@ -514,7 +520,7 @@ dpaa2_dev_prefetch_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \tq_storage->toggle ^= 1;\n \tdq_storage1 = q_storage->dq_storage[q_storage->toggle];\n \tqbman_pull_desc_clear(&pulldesc);\n-\tqbman_pull_desc_set_numframes(&pulldesc, DPAA2_DQRR_RING_SIZE);\n+\tqbman_pull_desc_set_numframes(&pulldesc, pull_size);\n \tqbman_pull_desc_set_fq(&pulldesc, fqid);\n \tqbman_pull_desc_set_storage(&pulldesc, dq_storage1,\n \t\t(uint64_t)(DPAA2_VADDR_TO_IOVA(dq_storage1)), 1);\n", "prefixes": [ "v3", "05/16" ] }