Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42457/?format=api
{ "id": 42457, "url": "http://patches.dpdk.org/api/patches/42457/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180706070449.1946-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180706070449.1946-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180706070449.1946-2-maxime.coquelin@redhat.com", "date": "2018-07-06T07:04:45", "name": "[v4,1/5] vhost: use shadow used ring in dequeue path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7d75870e889608ff311cc31beff38bc5c54a55f3", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180706070449.1946-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 449, "url": "http://patches.dpdk.org/api/series/449/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=449", "date": "2018-07-06T07:04:44", "name": "vhost: generalize buffer vectors", "version": 4, "mbox": "http://patches.dpdk.org/series/449/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42457/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42457/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D944B1B567;\n\tFri, 6 Jul 2018 09:04:56 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id AE5171B468\n\tfor <dev@dpdk.org>; Fri, 6 Jul 2018 09:04:54 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4176B4075637;\n\tFri, 6 Jul 2018 07:04:54 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.112.10])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 36A652166BA9;\n\tFri, 6 Jul 2018 07:04:53 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "tiwei.bie@intel.com,\n\tzhihong.wang@intel.com,\n\tdev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Fri, 6 Jul 2018 09:04:45 +0200", "Message-Id": "<20180706070449.1946-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180706070449.1946-1-maxime.coquelin@redhat.com>", "References": "<20180706070449.1946-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.5]); Fri, 06 Jul 2018 07:04:54 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.5]); \n\tFri, 06 Jul 2018 07:04:54 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [PATCH v4 1/5] vhost: use shadow used ring in dequeue\n\tpath", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Relax used ring contention by reusing the shadow used\nring feature used by enqueue path.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/virtio_net.c | 50 +++++++++----------------------------------\n 1 file changed, 10 insertions(+), 40 deletions(-)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 98ad8e936..741267345 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -1019,35 +1019,6 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \treturn error;\n }\n \n-static __rte_always_inline void\n-update_used_ring(struct virtio_net *dev, struct vhost_virtqueue *vq,\n-\t\t uint32_t used_idx, uint32_t desc_idx)\n-{\n-\tvq->used->ring[used_idx].id = desc_idx;\n-\tvq->used->ring[used_idx].len = 0;\n-\tvhost_log_cache_used_vring(dev, vq,\n-\t\t\toffsetof(struct vring_used, ring[used_idx]),\n-\t\t\tsizeof(vq->used->ring[used_idx]));\n-}\n-\n-static __rte_always_inline void\n-update_used_idx(struct virtio_net *dev, struct vhost_virtqueue *vq,\n-\t\tuint32_t count)\n-{\n-\tif (unlikely(count == 0))\n-\t\treturn;\n-\n-\trte_smp_wmb();\n-\trte_smp_rmb();\n-\n-\tvhost_log_cache_sync(dev, vq);\n-\n-\tvq->used->idx += count;\n-\tvhost_log_used_vring(dev, vq, offsetof(struct vring_used, idx),\n-\t\t\tsizeof(vq->used->idx));\n-\tvhost_vring_call(dev, vq);\n-}\n-\n static __rte_always_inline struct zcopy_mbuf *\n get_zmbuf(struct vhost_virtqueue *vq)\n {\n@@ -1115,7 +1086,6 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,\n \tstruct rte_mbuf *rarp_mbuf = NULL;\n \tstruct vhost_virtqueue *vq;\n \tuint32_t desc_indexes[MAX_PKT_BURST];\n-\tuint32_t used_idx;\n \tuint32_t i = 0;\n \tuint16_t free_entries;\n \tuint16_t avail_idx;\n@@ -1146,6 +1116,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,\n \t\tgoto out_access_unlock;\n \n \tvq->batch_copy_nb_elems = 0;\n+\tvq->shadow_used_idx = 0;\n \n \tif (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))\n \t\tvhost_user_iotlb_rd_lock(vq);\n@@ -1163,9 +1134,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,\n \t\t\tnext = TAILQ_NEXT(zmbuf, next);\n \n \t\t\tif (mbuf_is_consumed(zmbuf->mbuf)) {\n-\t\t\t\tused_idx = vq->last_used_idx++ & (vq->size - 1);\n-\t\t\t\tupdate_used_ring(dev, vq, used_idx,\n-\t\t\t\t\t\t zmbuf->desc_idx);\n+\t\t\t\tupdate_shadow_used_ring(vq, zmbuf->desc_idx, 0);\n \t\t\t\tnr_updated += 1;\n \n \t\t\t\tTAILQ_REMOVE(&vq->zmbuf_list, zmbuf, next);\n@@ -1176,7 +1145,9 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,\n \t\t\t}\n \t\t}\n \n-\t\tupdate_used_idx(dev, vq, nr_updated);\n+\t\tflush_shadow_used_ring(dev, vq);\n+\t\tvhost_vring_call(dev, vq);\n+\t\tvq->shadow_used_idx = 0;\n \t}\n \n \t/*\n@@ -1217,9 +1188,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,\n \n \t/* Prefetch available and used ring */\n \tavail_idx = vq->last_avail_idx & (vq->size - 1);\n-\tused_idx = vq->last_used_idx & (vq->size - 1);\n \trte_prefetch0(&vq->avail->ring[avail_idx]);\n-\trte_prefetch0(&vq->used->ring[used_idx]);\n \n \tcount = RTE_MIN(count, MAX_PKT_BURST);\n \tcount = RTE_MIN(count, free_entries);\n@@ -1229,11 +1198,10 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,\n \t/* Retrieve all of the head indexes first to avoid caching issues. */\n \tfor (i = 0; i < count; i++) {\n \t\tavail_idx = (vq->last_avail_idx + i) & (vq->size - 1);\n-\t\tused_idx = (vq->last_used_idx + i) & (vq->size - 1);\n \t\tdesc_indexes[i] = vq->avail->ring[avail_idx];\n \n \t\tif (likely(dev->dequeue_zero_copy == 0))\n-\t\t\tupdate_used_ring(dev, vq, used_idx, desc_indexes[i]);\n+\t\t\tupdate_shadow_used_ring(vq, desc_indexes[i], 0);\n \t}\n \n \t/* Prefetch descriptor index. */\n@@ -1326,8 +1294,10 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,\n \n \tif (likely(dev->dequeue_zero_copy == 0)) {\n \t\tdo_data_copy_dequeue(vq);\n-\t\tvq->last_used_idx += i;\n-\t\tupdate_used_idx(dev, vq, i);\n+\t\tif (unlikely(i < count))\n+\t\t\tvq->shadow_used_idx = i;\n+\t\tflush_shadow_used_ring(dev, vq);\n+\t\tvhost_vring_call(dev, vq);\n \t}\n \n out:\n", "prefixes": [ "v4", "1/5" ] }