Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42433/?format=api
{ "id": 42433, "url": "http://patches.dpdk.org/api/patches/42433/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180705210741.17974-6-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180705210741.17974-6-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180705210741.17974-6-maxime.coquelin@redhat.com", "date": "2018-07-05T21:07:31", "name": "[v8,05/15] vhost: make indirect desc table copy desc type agnostic", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d90fc09ab84db9ca5977400eee60407f955cb2fb", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180705210741.17974-6-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 443, "url": "http://patches.dpdk.org/api/series/443/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=443", "date": "2018-07-05T21:07:26", "name": "Vhost: add support to packed ring layout", "version": 8, "mbox": "http://patches.dpdk.org/series/443/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42433/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/42433/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E62751BF37;\n\tThu, 5 Jul 2018 23:07:57 +0200 (CEST)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id 752101BF27\n\tfor <dev@dpdk.org>; Thu, 5 Jul 2018 23:07:55 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 16BA8400ADE4;\n\tThu, 5 Jul 2018 21:07:55 +0000 (UTC)", "from localhost.localdomain (ovpn-112-37.ams2.redhat.com\n\t[10.36.112.37])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 73DF32166BA9;\n\tThu, 5 Jul 2018 21:07:53 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com,\n\tdev@dpdk.org", "Cc": "mst@redhat.com, jasowang@redhat.com, wexu@redhat.com,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 5 Jul 2018 23:07:31 +0200", "Message-Id": "<20180705210741.17974-6-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180705210741.17974-1-maxime.coquelin@redhat.com>", "References": "<20180705210741.17974-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.6", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.6]); Thu, 05 Jul 2018 21:07:55 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.6]); \n\tThu, 05 Jul 2018 21:07:55 +0000 (UTC) for IP:'10.11.54.6'\n\tDOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [PATCH v8 05/15] vhost: make indirect desc table copy\n\tdesc type agnostic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/virtio_net.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex e189cbb2c..85b7ca02f 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -37,16 +37,15 @@ is_valid_virt_queue_idx(uint32_t idx, int is_tx, uint32_t nr_vring)\n \treturn (is_tx ^ (idx & 1)) == 0 && idx < nr_vring;\n }\n \n-static __rte_always_inline struct vring_desc *\n+static __rte_always_inline void *\n alloc_copy_ind_table(struct virtio_net *dev, struct vhost_virtqueue *vq,\n-\t\t\t\t\t struct vring_desc *desc)\n+\t\t\t\t\t uint64_t desc_addr, uint64_t desc_len)\n {\n-\tstruct vring_desc *idesc;\n+\tvoid *idesc;\n \tuint64_t src, dst;\n-\tuint64_t len, remain = desc->len;\n-\tuint64_t desc_addr = desc->addr;\n+\tuint64_t len, remain = desc_len;\n \n-\tidesc = rte_malloc(__func__, desc->len, 0);\n+\tidesc = rte_malloc(__func__, desc_len, 0);\n \tif (unlikely(!idesc))\n \t\treturn 0;\n \n@@ -72,7 +71,7 @@ alloc_copy_ind_table(struct virtio_net *dev, struct vhost_virtqueue *vq,\n }\n \n static __rte_always_inline void\n-free_ind_table(struct vring_desc *idesc)\n+free_ind_table(void *idesc)\n {\n \trte_free(idesc);\n }\n@@ -251,7 +250,8 @@ fill_vec_buf(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t\t * The indirect desc table is not contiguous\n \t\t\t * in process VA space, we have to copy it.\n \t\t\t */\n-\t\t\tidesc = alloc_copy_ind_table(dev, vq, &vq->desc[idx]);\n+\t\t\tidesc = alloc_copy_ind_table(dev, vq,\n+\t\t\t\t\tvq->desc[idx].addr, vq->desc[idx].len);\n \t\t\tif (unlikely(!idesc))\n \t\t\t\treturn -1;\n \n", "prefixes": [ "v8", "05/15" ] }