Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42359/?format=api
{ "id": 42359, "url": "http://patches.dpdk.org/api/patches/42359/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/41669072ea5a9a6a6487f5a814a88446e1f7f2b7.1530791217.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<41669072ea5a9a6a6487f5a814a88446e1f7f2b7.1530791217.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/41669072ea5a9a6a6487f5a814a88446e1f7f2b7.1530791217.git.gaetan.rivet@6wind.com", "date": "2018-07-05T11:48:31", "name": "[v10,24/27] bus/vdev: pre-process declarative vdev devargs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "75f2570ac1fb6378bd2c06222ced1be2a13035d6", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/41669072ea5a9a6a6487f5a814a88446e1f7f2b7.1530791217.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 419, "url": "http://patches.dpdk.org/api/series/419/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=419", "date": "2018-07-05T11:48:07", "name": "Device querying", "version": 10, "mbox": "http://patches.dpdk.org/series/419/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42359/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42359/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CCF931B5EA;\n\tThu, 5 Jul 2018 13:49:50 +0200 (CEST)", "from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 5711C1BF10\n\tfor <dev@dpdk.org>; Thu, 5 Jul 2018 13:49:28 +0200 (CEST)", "by mail-wm0-f68.google.com with SMTP id v25-v6so10657552wmc.0\n\tfor <dev@dpdk.org>; Thu, 05 Jul 2018 04:49:28 -0700 (PDT)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\to42-v6sm15809183wrc.50.2018.07.05.04.49.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 05 Jul 2018 04:49:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=zJGbgVjVaw9EdvCV9Eh/VFk/xXnt32MFrGHHYkSwD0o=;\n\tb=LmzgxOPnMs6uBuUYYZ9ijUSZUx9q9RyXZa9V2fqdjuS/hAuDT/IyEPoE5SEWd5mTOy\n\td1/zpraNhqMFTh2i6MdBju2j38tJy2MzMuEpWyfdFpTZ2Ud1SAX9wN3v6PhB3mSlTxUA\n\tFFLKjI4KxsmpeaJ6uC4b19ObDdkpPm4lLRYKz7mk+QyPVe1JZI8WLAoN+YkC/koKelYl\n\tyiXtnySJ1z5yEWiWXO+ddccOJeL6lAmXfyPiBLf4cP7JJZhBiJSY3K8A7ndZwI1xZLiF\n\td8Gz1lUpvc0nSP62/OZJZRQl57RtlH6Bj7WvGD2u44IRzMKqbqupj1YDYuo1JYu94Job\n\t/NCA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=zJGbgVjVaw9EdvCV9Eh/VFk/xXnt32MFrGHHYkSwD0o=;\n\tb=Gx84PY5vVx6Jw/XOF4WGPCP4Z37pDWFNRWhsLPbvpQYjhjkEY39mw2Gf/x5XTmhMgj\n\tVFwh3utYMbkwymto4GeQ7qsptasQ/LzVJxCQPVkTHl9Yh5ivkZ1H6jiY00j0wR6i39RN\n\tYvo4gDIOB54g9Cy8mZmul8vwX5ULWqE+d/IjjPBgTmlitPToC3eRrwwknMd5h8CW4re1\n\tSdEMLBmZZrggQ2If9EBEb3cuz6AaB2OGVjQnL7EVeP00SnLDxgNq1XrzG0EgzdTmio3q\n\tiqoX2hlYuXNg2fcG59yIhaYj4CiXYtPGROp4Yp1GLk8pRhVU4kY7/RcT4IqalUaCp4Xv\n\tJTrQ==", "X-Gm-Message-State": "APt69E14liN+KQC/vLNsk/PcpfziHFX8iTtZHJMjbvaKeTnVJoJvfmGj\n\tE4w3a0fyFu6wL15WCYiAzRe3GMY2", "X-Google-Smtp-Source": "AAOMgpcEpNQAMFtRbgB7noqwToOh1/elRODC2z3xBR8LXkIbO30Iyt3rxSc5vbfIFUUz7W7jOifddA==", "X-Received": "by 2002:a1c:894f:: with SMTP id\n\tl76-v6mr3818077wmd.103.1530791367743; \n\tThu, 05 Jul 2018 04:49:27 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Thu, 5 Jul 2018 13:48:31 +0200", "Message-Id": "<41669072ea5a9a6a6487f5a814a88446e1f7f2b7.1530791217.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1530791217.git.gaetan.rivet@6wind.com>", "References": "<cover.1530791217.git.gaetan.rivet@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v10 24/27] bus/vdev: pre-process declarative vdev\n\tdevargs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The new devargs format does not recognize a particular device name.\nEach bus uses its specific format.\n\nProcess each devargs privately prior to attempting a bus scan.\nPrepare them if they are using the new devargs format.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n drivers/bus/vdev/vdev.c | 10 ++++---\n drivers/bus/vdev/vdev_params.c | 50 +++++++++++++++++++++++++++++++++\n drivers/bus/vdev/vdev_private.h | 6 ++++\n 3 files changed, 62 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex e8518833d..f2dace245 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -115,8 +115,8 @@ rte_vdev_remove_custom_scan(rte_vdev_scan_callback callback, void *user_arg)\n \treturn 0;\n }\n \n-static int\n-vdev_parse(const char *name, void *addr)\n+int\n+rte_vdev_parse(const char *name, void *addr)\n {\n \tstruct rte_vdev_driver **out = addr;\n \tstruct rte_vdev_driver *driver = NULL;\n@@ -148,7 +148,7 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev)\n \tVDEV_LOG(DEBUG, \"Search driver %s to probe device %s\", name,\n \t\trte_vdev_device_name(dev));\n \n-\tif (vdev_parse(name, &driver))\n+\tif (rte_vdev_parse(name, &driver))\n \t\treturn -1;\n \tdev->device.driver = &driver->driver;\n \tret = driver->probe(dev);\n@@ -443,6 +443,8 @@ vdev_scan(void)\n \n \t/* for virtual devices we scan the devargs_list populated via cmdline */\n \tRTE_EAL_DEVARGS_FOREACH(\"vdev\", devargs) {\n+\t\tif (rte_vdev_devargs_prepare(devargs))\n+\t\t\tcontinue;\n \n \t\tdev = calloc(1, sizeof(*dev));\n \t\tif (!dev)\n@@ -536,7 +538,7 @@ static struct rte_bus rte_vdev_bus = {\n \t.find_device = rte_vdev_find_device,\n \t.plug = vdev_plug,\n \t.unplug = vdev_unplug,\n-\t.parse = vdev_parse,\n+\t.parse = rte_vdev_parse,\n \t.dev_iterate = rte_vdev_dev_iterate,\n };\n \ndiff --git a/drivers/bus/vdev/vdev_params.c b/drivers/bus/vdev/vdev_params.c\nindex 2f55f451f..7ad11b092 100644\n--- a/drivers/bus/vdev/vdev_params.c\n+++ b/drivers/bus/vdev/vdev_params.c\n@@ -2,11 +2,14 @@\n * Copyright 2018 Gaëtan Rivet\n */\n \n+#include <string.h>\n+\n #include <rte_dev.h>\n #include <rte_bus.h>\n #include <rte_bus_vdev.h>\n #include <rte_kvargs.h>\n #include <rte_errno.h>\n+#include <rte_devargs.h>\n \n #include \"vdev_logs.h\"\n #include \"vdev_private.h\"\n@@ -60,3 +63,50 @@ rte_vdev_dev_iterate(const void *start,\n \trte_kvargs_free(kvargs);\n \treturn dev;\n }\n+\n+static int\n+vdev_driver_kv_parse(const char *key __rte_unused,\n+\t\t const char *value,\n+\t\t void *_da)\n+{\n+\tstruct rte_devargs *da = _da;\n+\tstruct rte_vdev_driver *driver;\n+\n+\t/* Verify that the driver matches. */\n+\tif (rte_vdev_parse(value, &driver))\n+\t\treturn -1;\n+\n+\t/* Copy the driver name as-is. */\n+\tsnprintf(da->name, sizeof(da->name), \"%s\", value);\n+\treturn 0;\n+}\n+\n+int\n+rte_vdev_devargs_prepare(struct rte_devargs *da)\n+{\n+\tstruct rte_kvargs *kvargs = NULL;\n+\tchar *args;\n+\tint ret;\n+\n+\tif (da->busstr == NULL)\n+\t\treturn 0;\n+\n+\targs = strchr(da->busstr, ',');\n+\tif (args == NULL)\n+\t\treturn 0;\n+\targs++;\n+\n+\tkvargs = rte_kvargs_parse(args, vdev_params_keys);\n+\tif (kvargs == NULL) {\n+\t\tVDEV_LOG(ERR, \"unable to parse parameter list: %s\\n\",\n+\t\t\t da->busstr);\n+\t\trte_errno = EINVAL;\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_kvargs_process(kvargs, \"driver\",\n+\t\t\t\t vdev_driver_kv_parse, da);\n+\n+\trte_kvargs_free(kvargs);\n+\treturn ret;\n+}\ndiff --git a/drivers/bus/vdev/vdev_private.h b/drivers/bus/vdev/vdev_private.h\nindex ba6dc48ff..da57b84dd 100644\n--- a/drivers/bus/vdev/vdev_private.h\n+++ b/drivers/bus/vdev/vdev_private.h\n@@ -19,6 +19,12 @@ rte_vdev_dev_iterate(const void *start,\n \t\t const char *str,\n \t\t const struct rte_dev_iterator *it);\n \n+int\n+rte_vdev_parse(const char *name, void *addr);\n+\n+int\n+rte_vdev_devargs_prepare(struct rte_devargs *da);\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "v10", "24/27" ] }