Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42254/?format=api
http://patches.dpdk.org/api/patches/42254/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180704085154.37828-17-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180704085154.37828-17-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180704085154.37828-17-pablo.de.lara.guarch@intel.com", "date": "2018-07-04T08:51:54", "name": "[v4,16/16] cryptodev: check if symmetric sessions are supported", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ba3e66833450bfee7ae81c1f96b73146481151d1", "submitter": { "id": 9, "url": "http://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180704085154.37828-17-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 401, "url": "http://patches.dpdk.org/api/series/401/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=401", "date": "2018-07-04T08:51:38", "name": "Cryptodev API changes", "version": 4, "mbox": "http://patches.dpdk.org/series/401/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42254/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 688C61BF67;\n\tWed, 4 Jul 2018 18:58:33 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 722D81BF5A\n\tfor <dev@dpdk.org>; Wed, 4 Jul 2018 18:58:32 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Jul 2018 09:58:31 -0700", "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby fmsmga008.fm.intel.com with ESMTP; 04 Jul 2018 09:58:16 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,306,1526367600\"; d=\"scan'208\";a=\"52630857\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com, akhil.goyal@nxp.com,\n\tshally.verma@caviumnetworks.com, ravi1.kumar@amd.com,\n\tjerin.jacob@caviumnetworks.com, roy.fan.zhang@intel.com,\n\tfiona.trahe@intel.com, tdu@semihalf.com, jianjay.zhou@huawei.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Wed, 4 Jul 2018 09:51:54 +0100", "Message-Id": "<20180704085154.37828-17-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.14.4", "In-Reply-To": "<20180704085154.37828-1-pablo.de.lara.guarch@intel.com>", "References": "<20180608220234.10170-1-pablo.de.lara.guarch@intel.com>\n\t<20180704085154.37828-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 16/16] cryptodev: check if symmetric sessions\n\tare supported", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since asymmetric functionality will be implemented soon,\nnot all PMDs must support symmetric sessions.\nTherefore, a check is added if a device does not implement\nthe symmetric functions, meaning that the device does not\nsupport symmetric operations.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nAcked-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n lib/librte_cryptodev/rte_cryptodev.c | 4 ++++\n lib/librte_cryptodev/rte_cryptodev.h | 4 +++-\n 2 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex 3860b0b23..26d43fd3d 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -1063,6 +1063,8 @@ rte_cryptodev_sym_session_init(uint8_t dev_id,\n \n \tindex = dev->driver_id;\n \n+\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->sym_session_configure, -ENOTSUP);\n+\n \tif (sess->sess_private_data[index] == NULL) {\n \t\tret = dev->dev_ops->sym_session_configure(dev, xforms,\n \t\t\t\t\t\t\tsess, mp);\n@@ -1107,6 +1109,8 @@ rte_cryptodev_sym_session_clear(uint8_t dev_id,\n \tif (dev == NULL || sess == NULL)\n \t\treturn -EINVAL;\n \n+\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->sym_session_clear, -ENOTSUP);\n+\n \tdev->dev_ops->sym_session_clear(dev, sess);\n \n \treturn 0;\ndiff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h\nindex 2049a745d..27dc7a297 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.h\n+++ b/lib/librte_cryptodev/rte_cryptodev.h\n@@ -888,7 +888,8 @@ rte_cryptodev_sym_session_free(struct rte_cryptodev_sym_session *sess);\n * @return\n * - On success, zero.\n * - -EINVAL if input parameters are invalid.\n- * - -ENOTSUP if crypto device does not support the crypto transform.\n+ * - -ENOTSUP if crypto device does not support the crypto transform or\n+ * does not support symmetric operations.\n * - -ENOMEM if the private session could not be allocated.\n */\n int\n@@ -909,6 +910,7 @@ rte_cryptodev_sym_session_init(uint8_t dev_id,\n * @return\n * - 0 if successful.\n * - -EINVAL if device is invalid or session is NULL.\n+ * - -ENOTSUP if crypto device does not support symmetric operations.\n */\n int\n rte_cryptodev_sym_session_clear(uint8_t dev_id,\n", "prefixes": [ "v4", "16/16" ] }{ "id": 42254, "url": "