Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42223/?format=api
{ "id": 42223, "url": "http://patches.dpdk.org/api/patches/42223/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1530699495-6937-1-git-send-email-nithin.dabilpuram@cavium.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530699495-6937-1-git-send-email-nithin.dabilpuram@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530699495-6937-1-git-send-email-nithin.dabilpuram@cavium.com", "date": "2018-07-04T10:18:15", "name": "app/test-pmd: Fix buffer leak in tm cmdline", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3beff9389a2725b76ac728460e13976533e9495a", "submitter": { "id": 924, "url": "http://patches.dpdk.org/api/people/924/?format=api", "name": "Nithin Dabilpuram", "email": "Nithin.Dabilpuram@cavium.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1530699495-6937-1-git-send-email-nithin.dabilpuram@cavium.com/mbox/", "series": [ { "id": 395, "url": "http://patches.dpdk.org/api/series/395/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=395", "date": "2018-07-04T10:18:15", "name": "app/test-pmd: Fix buffer leak in tm cmdline", "version": 1, "mbox": "http://patches.dpdk.org/series/395/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42223/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/42223/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0F7521BE95;\n\tWed, 4 Jul 2018 12:19:00 +0200 (CEST)", "from NAM02-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam02on0048.outbound.protection.outlook.com [104.47.36.48])\n\tby dpdk.org (Postfix) with ESMTP id EE20D1BE94\n\tfor <dev@dpdk.org>; Wed, 4 Jul 2018 12:18:57 +0200 (CEST)", "from hyd1351t110.caveonetworks.com.com (115.113.156.2) by\n\tMWHPR07MB3182.namprd07.prod.outlook.com (2603:10b6:300:e1::12) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.906.25; Wed, 4 Jul 2018 10:18:54 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=1jv0Bp3WErf9UaZ7FwwDF54wUAhgNpvyJahWjkIVgbU=;\n\tb=WC3Dh5Y12W+K7HlVY7CAxKKZ+/gXkJxqNX9swAbyfvb6E69xUuv39NRFYwpy7EOT4i7na3B3+tNRUOmyqq0kc7ALWRr4bfTgFPn21oFf7s8IZ46Bmjk7KMqG5hkQkBNRkm/w5fp3AMQSpI/eDbDynrpwg5aZexltG4xyZ+SSUb4=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Nithin.Dabilpuram@cavium.com; ", "From": "Nithin Dabilpuram <nithin.dabilpuram@cavium.com>", "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, \n\tBernard Iremonger <bernard.iremonger@intel.com>", "Cc": "dev@dpdk.org, kkanas@caviumnetworks.com,\n\tNithin Dabilpuram <nithin.dabilpuram@cavium.com>", "Date": "Wed, 4 Jul 2018 15:48:15 +0530", "Message-Id": "<1530699495-6937-1-git-send-email-nithin.dabilpuram@cavium.com>", "X-Mailer": "git-send-email 1.8.3.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[115.113.156.2]", "X-ClientProxiedBy": "BM1PR0101CA0005.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:18::15) To MWHPR07MB3182.namprd07.prod.outlook.com\n\t(2603:10b6:300:e1::12)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "9b300162-e1b5-4e42-2c53-08d5e1978cf1", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);\n\tSRVR:MWHPR07MB3182; ", "X-Microsoft-Exchange-Diagnostics": [ "1; MWHPR07MB3182;\n\t3:QTYgR1NBj2eu6zs5yI3BKqwpDfCqK8Sxs3oCaBQyBXt8gm+8Y57Ou509FEMFhp4JYf1KnVJUr1W0qruxtmS6wokYaduu/ThsvkDAoCKgFOyCQjGJsjjPYH1Ad2o+cv1+8VqsNhabhoCy0b9rsd+Co0FF9zvoJXMLIoyxUkKqVjcd5fANhDzBx2iYdQACICnDR3+fG7dhAg12UozeBXZp6iPnbKDoMK83UZPxr31ZnefYGPgRbEyPaXjk7LMmd9ip;\n\t25:ltqPg8yxOcmlLrAyoQRoEsWbKCpZ1H7kpEimulEEKCZiPno1uUkGOGJcouFCrzqGvfTO6CmGvgedMBpU7Bssw1PILqaO29QTYOxcsMEYVMqq3GLuXJEFL126tl5nX3Pfklqgd8X/NjkI9z4ni/8edBLGQhDo13hBJZnLLFUqBRoLcGSULCRSH/k3ypA97FUb2BwPNmI/yLbmki5xJNY8TGiJkxPx5V5JaP7qgnOX42LpcPNOpYklTmUKKUh49IHO7xAcow8BhhAPDRsZ8NME9sdtpGu7CSci5TdLHTyV9CSsey74I4gzoME+l6j20e9m87jxYvFrrZ98wnoIub5KSg==;\n\t31:CZwx4AOhbs37nWg6x0SNvDA06wr2W+bOxeczoL/2HGmWYn1kbXLJCrk/87ze5pj8dZ4p2ut1sXU7TGA4XW7Hse5D6FxxRJHSaiDiu7l6gbqBEEkkpYWXiqwy0uAXmf0AhqDUQA5xVgy6o7rt9m+xBoColELr1L3Za23NMv+3jmkvFo2cqMhYTNfIkyJkuMc2mISllGuAEkhosb6bsqqnkB7ZOZMexf7+ocRzj+Hjn3k=", "1; MWHPR07MB3182;\n\t20:i/4R9MUGIcZrDwYdMzssSzvV1fZieAW2MC+Yfc2SCuzgkyM9MzXn50/EhfuBko4/VdaN0UyOl37jZQZurFbCUCPULezJqRVGkm17uVDhw/u0uzaX1f5DACICImQRY+AwD4LHUOkM5PE7oeBLqUfgYYxY1Vgg90RppBwKT/cJQnDZZQHDouQmOfKgONF4ZSZpK23jMzH10EnkyzXRU3JkyiEtbWsmycgbgxikiIh7NupoUThRrjA6FHSAO7t0Vg2PY9Hx39M42zqEeTs/Xp8PfFggP20KNC6ly+Qe7ruUWEzTuo2dhqmCwfS73n/Z+1xgg6WA6DIQbXZTVCga9G5vlImHnxBMY1pKWhKLUsZpwqIzHmsskpVA0R6GHILNLT50FB/mSRKFFRAojnPAbDAMDeuJBPq66j2INglzEhFeVIOMtCdDCjqcdXqT59W97uxYG65L+wA5d6tIggQEp6ANeBHuSXgkY+2LmAZQ2AAC0KDThcX8hSwfoLo0J9Pcm+YB;\n\t4:A8KEXNlxng7pspGrcKFv6zeM9sYRIGD5pIhPlZmAVJZNkv30QvAbrKWDsiC/p2MP2741CISWG3Z7+yXHxvZrn5pa9/EvpLFfiyBdnPPwRPCboT0C/BqUz5xJNE6tgQ59KGc5od0pyWnieeiFVbliAGfCJYkd631APZj1iRXp3PeDoJ68zcdXPapicTcbeS0eZgsxaLnsqjm5/qejUkIZN/SW3bP0w76UYGaX+6eNhGpLM+lVuGAY8K88Ui+svWMenKfG0tuBlYupmoulmO5fCw==", "=?us-ascii?Q?1; MWHPR07MB3182;\n\t23:QA0VoYdeoavbSw9p6hHBSj0T81gB+EKoXsPPgXnm5?=\n\t8D5h41Inj0571sNsEHisBo3nmjjIhfCQ3DUtHABaMinwfRAldGaZkemGLPbB2u1OPmgymO6f0iBXcPQ00Ls9FyamPS3BvYUyuMg+QeWAbSxTyiAOSJ/8rmJyHs34Z7UvvrK1+UgLQ+auDteX/8L5PS5BaqnQGf6EKFxPvpdcn/yJAaU0IzptNusJHFy24W1iUUPmMmVystsTpPDaXMAVCs5cqGl6S6tqjzF3/R91hCjSyN8/MoDpt9g4nXxLiwBDadLExwsxGTj6A5FW6uHwrPpjqlna/Wco6B6ftMD9IWpl8x/T8KnuiQsIA/MSyqqirO1oZYHqzQkj7njn1+GUzDKsrmVhxDpDEA35zNYhurO0K8j/g0uweCayfo5WOEG+IfIgFHfF9hfBpWZouGb7hoW5DpV8vP80QPjfAR0jq/jzFBVBGRc2En5XEXWQSMrim8H7Jh+ufzXK4qud4TK/zQRaqRlywTR6P+yP88XH+3b+auKrRKoB+mtYSANhtwGIoDnDwXBA9W3U/IKY8LUhp0XJte1jUBa3cyOwlhpRPK8T1bIqUnuvoztMHe2+cPGUqyYLGTvEhIMM9Z2db6+kyqGZjTGCe7GMA2Y5VAf5FfXZuEMw5RCRKStR68S5daDsSGlzt8VguIhjBkivMN0oaT+1zEC1QLxUFIcznw18FZxkd4fqSHRCBIWbkPVvnY66x+aKi5piol9Zo7aNkYl2WhacnoWedL1MAW3i9shqwzgm5CGpoLUP1NyNFdVxGhLICNuYPlSiIv68w5WIZ5MUwjX7YfHCqVMDYziIOGyZXy9SI+R5lXnrZ4H8yZhZotS8qXi7ZJcYxnJP3SiLnu+vMzlhttYlNxwPaIWtPauV3qGsZGDXR4xhCm61cWUQ/NTy8+GXGzasO8tUWIM0mz8hNSTMR1ZGG5abHVgrO9PhSUIYnQmoMqBvayp23xXs9nMIVfQMRfPGZtBSzq0uod6kmMe+RYpTlHthOvUY/ibmrnwndhfdT5uutyddYCnHT/EXeVhm4kIGls4ylIjO7tafLEAe31EFGJq/BMBzMwzsvCzSCBm2muPTMVZ66Ni8IaJFCzOglgjgLhQhT/brf7+haL3LAgpwfTdRutmQTE6YVHUYczJVOudaQ431QgQSAsgWxS1G7OOLfeoWnT/IRdHXqR8/60K9xgpjg04S1GqAXFZZ+sHBVIQECKqxZLNdosSANE=", "1; MWHPR07MB3182;\n\t6:J8F54qrwBtit/wrDTfO5CZR8j4Rzbc3w9orKZiXNAUU77jlPQKoi4P5bfbAVMxm4aJTwRna8KqEbpt2LO0BbydK8sbqqeFRc6MyR9Y1Me3RD974o7SmSnfWiBV/O4kWc7LyUPbzUVJcq+Q1tSTFqtQxUwBC2kfRyxOmjH5JXniH1l9IiMi85utP6ozrJd18OSZ6sdYe5mH8CbQ+pFFyylnjgSg4vwhuymgqnssLc6NbuBLtlyUfruS++IRCf1iTWQKhy+m++ejI+Fx4dhwjx+L+8CaZBiNpa9IvJkm15QkUf/xdOJq1KICDBAJX+5aq4JtlKQ942Qr+wyPhrHP0F2h+54Qp0Iq8uRQDOr63Om1803fAHY71LuIjVXsCXsZZC0IJmADLCiWDdMPJcrLsDAvLwO3tOHzPGRE14MAc4d2SgC3kUK8QOFKqM2vcQk2Tti9BOE/wgKB2i+nc6hd90Qw==;\n\t5:64IhWhfHIlN7eSnvHEh/SQqdu6ML5UHXJrixSbRz8Xqat3v/dujMskZZi5PyrA7gGTj9IC1XeE5Kbq2q59JbvrsLoGWRPD5dtADv93SVom363LHq0Z8rnur+bpfZX7sxyaPombDoIKHrodD30bgD2QCbsic0gIcwZcn4gv/xYgQ=;\n\t24:no2Qt83NPQn65N/D8g4nOZWk07p3HfbiIQ2dgae38U5Qkgpg0+XcJ1HMyQ1eqnaHeeroSBL4mp2YET0HIk58XfWP4dAbXw82aS6b7ChXftw=", "1; MWHPR07MB3182;\n\t7:EzEuv5w1BrahLy6408N3t+3pxumZS45tdPOsJ0hO5MMg00t7dZhn7VDKhBJ6f1B6jCthiAkEwwxVRAhOyCEs/IVoZxfPazS3E0bDtCQG8UTItZcyVp2+0k7CZJz6Ofr2TDKbhWk/XVzz6f+1dXxP50lpcyV/K8Djz4altH1tuiz+m9ue9y+Pi5E1Iwrs1E3fnjHtUNp46L7a6ct9cwOU3fQhGvCM0O2cZJk39lKsj7eKzC7eMYQdiMwYQmH1FSec" ], "X-MS-TrafficTypeDiagnostic": "MWHPR07MB3182:", "X-Microsoft-Antispam-PRVS": "<MWHPR07MB31826B5EB39B30724BF15A749B410@MWHPR07MB3182.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016);\n\tSRVR:MWHPR07MB3182; BCL:0; PCL:0; RULEID:; SRVR:MWHPR07MB3182; ", "X-Forefront-PRVS": "0723A02764", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(376002)(39850400004)(136003)(346002)(366004)(189003)(199004)(2616005)(4720700003)(36756003)(16586007)(4326008)(6486002)(316002)(81156014)(6666003)(81166006)(1857600001)(486006)(476003)(26005)(6116002)(186003)(3846002)(16526019)(107886003)(53936002)(956004)(305945005)(7736002)(5660300001)(8936002)(55236004)(6512007)(68736007)(50466002)(2906002)(66066001)(110136005)(25786009)(8676002)(47776003)(86362001)(6506007)(386003)(48376002)(52116002)(72206003)(97736004)(105586002)(51416003)(106356001)(44832011)(50226002)(478600001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3182;\n\tH:hyd1351t110.caveonetworks.com.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "Received-SPF": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "wAPziEWAn1WyfarxUjR7/76ZvV4JWcXM6j3rUhYZZqXm0UzsuZ4W6sSduQS6xKZ7EbcsPc3p+Wo/qqL8R69Ab5nirf9Hg/hXabz8ZqCzBDu50MIaNVr3JtvF+B3I0qGEgND490Ede2lW1amlAYoLi0UvILWCZBZ7bDGhN10sRumHslmPf83vKJL9XdM2nleIbflVKF5PrO8ZBbccbOrq1TGq/Bc2sJ7Wl/lSmLHpc/v9nNzUZlXPsYIACE+A2vRj6qxV8NTVBniWqoGci9fl7P0jqmHZ9pK9V3rpZgC/vwHiphOsGiK7qXuvCYw3Apslzt6HFIm+39jYrr0XZIP98gCnylQ4/jDRypIfvR4p6Os=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "cavium.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Jul 2018 10:18:54.4334\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "9b300162-e1b5-4e42-2c53-08d5e1978cf1", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MWHPR07MB3182", "Subject": "[dpdk-dev] [PATCH] app/test-pmd: Fix buffer leak in tm cmdline", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Free the buffer allocated for shared_shaper_id array in\ncase of configuration without shared shapers.\n\nSigned-off-by: Nithin Dabilpuram <nithin.dabilpuram@cavium.com>\n---\n app/test-pmd/cmdline_tm.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c\nindex c904e44..7c1601f 100644\n--- a/app/test-pmd/cmdline_tm.c\n+++ b/app/test-pmd/cmdline_tm.c\n@@ -1599,10 +1599,12 @@ static void cmd_add_port_tm_nonleaf_node_parsed(void *parsed_result,\n \t\tnp.shaper_profile_id = res->shaper_profile_id;\n \n \tnp.n_shared_shapers = n_shared_shapers;\n-\tif (np.n_shared_shapers)\n+\tif (np.n_shared_shapers) {\n \t\tnp.shared_shaper_id = &shared_shaper_id[0];\n-\telse\n-\t\tnp.shared_shaper_id = NULL;\n+\t} else {\n+\t\tfree(shared_shaper_id);\n+\t\tshared_shaper_id = NULL;\n+\t}\n \n \tnp.nonleaf.n_sp_priorities = res->n_sp_priorities;\n \tnp.stats_mask = res->stats_mask;\n@@ -1758,10 +1760,12 @@ static void cmd_add_port_tm_leaf_node_parsed(void *parsed_result,\n \n \tnp.n_shared_shapers = n_shared_shapers;\n \n-\tif (np.n_shared_shapers)\n+\tif (np.n_shared_shapers) {\n \t\tnp.shared_shaper_id = &shared_shaper_id[0];\n-\telse\n-\t\tnp.shared_shaper_id = NULL;\n+\t} else {\n+\t\tfree(shared_shaper_id);\n+\t\tshared_shaper_id = NULL;\n+\t}\n \n \tnp.leaf.cman = res->cman_mode;\n \tnp.leaf.wred.wred_profile_id = res->wred_profile_id;\n", "prefixes": [] }