Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42199/?format=api
{ "id": 42199, "url": "http://patches.dpdk.org/api/patches/42199/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180704105625.39462-1-yong.liu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180704105625.39462-1-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180704105625.39462-1-yong.liu@intel.com", "date": "2018-07-04T10:56:25", "name": "net/virtio: fix build with gcc optimization on", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "3e0b4c4062608d975e5d496a69c23a988f293211", "submitter": { "id": 17, "url": "http://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180704105625.39462-1-yong.liu@intel.com/mbox/", "series": [ { "id": 386, "url": "http://patches.dpdk.org/api/series/386/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=386", "date": "2018-07-04T10:56:25", "name": "net/virtio: fix build with gcc optimization on", "version": 1, "mbox": "http://patches.dpdk.org/series/386/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/42199/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/42199/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DEA051BE8F;\n\tWed, 4 Jul 2018 05:10:58 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id A3D6B1BE8E\n\tfor <dev@dpdk.org>; Wed, 4 Jul 2018 05:10:56 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Jul 2018 20:10:55 -0700", "from dpdk-test32.sh.intel.com ([10.67.119.193])\n\tby fmsmga001.fm.intel.com with ESMTP; 03 Jul 2018 20:10:54 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,306,1526367600\"; d=\"scan'208\";a=\"69462644\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\ttiwei.bie@intel.com,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Wed, 4 Jul 2018 18:56:25 +0800", "Message-Id": "<20180704105625.39462-1-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/virtio: fix build with gcc optimization on", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "build error on gcc version 8.1.1 20180502 (Red Hat 8.1.1-1),\nwith optimization level >= O2\n\n.../drivers/net/virtio/virtio_rxtx.c:\n In function ‘virtio_xmit_cleanup_inorder’:\n.../drivers/net/virtio/virtio_rxtx.c:195:24:\n error: ‘desc_idx’ may be used uninitialized in this function\n [-Werror=maybe-uninitialized]\n uint16_t i, used_idx, desc_idx, last_idx;\n ^~~~~~~~\nOptimization option fcode-hoisting will cause error on gcc 8.x.x.\nInitialize desc_idx before using can fix build error.\n\nFixes: e3851816e63c (\"net/virtio: support in-order Rx and Tx\")\n\nReported-by: Ferruh Yigit <ferruh.yigit@intel.com>\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 6394071b8..19beb4bf4 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -192,7 +192,8 @@ virtio_xmit_cleanup(struct virtqueue *vq, uint16_t num)\n static void\n virtio_xmit_cleanup_inorder(struct virtqueue *vq, uint16_t num)\n {\n-\tuint16_t i, used_idx, desc_idx, last_idx;\n+\tuint16_t i, used_idx, last_idx;\n+\tuint16_t desc_idx = 0;\n \tint16_t free_cnt = 0;\n \tstruct vq_desc_extra *dxp = NULL;\n \n", "prefixes": [] }